Re: [COMMITTERS] pgsql: Error out in pg_rewind if lstat() fails.

2015-04-15 Thread Heikki Linnakangas
On 04/16/2015 04:17 AM, Michael Paquier wrote: On Thu, Apr 16, 2015 at 5:15 AM, Heikki Linnakangas wrote: Error out in pg_rewind if lstat() fails. A "file not found" is expected if the source server is running, so don't complain about that. But any other error is definitely not expected. Nit

Re: [COMMITTERS] pgsql: Error out in pg_rewind if lstat() fails.

2015-04-15 Thread Michael Paquier
On Thu, Apr 16, 2015 at 5:15 AM, Heikki Linnakangas wrote: > Error out in pg_rewind if lstat() fails. > > A "file not found" is expected if the source server is running, so don't > complain about that. But any other error is definitely not expected. Nitpicking: strings of pg_fatal need to have a

[COMMITTERS] pgsql: Error out in pg_rewind if lstat() fails.

2015-04-15 Thread Heikki Linnakangas
Error out in pg_rewind if lstat() fails. A "file not found" is expected if the source server is running, so don't complain about that. But any other error is definitely not expected. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b5e560c24603e5325a81055c8f36cc45d486