Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-05 Thread Amit Kapila
On Wed, Oct 5, 2016 at 5:53 PM, Amit Kapila wrote: > On Tue, Oct 4, 2016 at 8:32 PM, Robert Haas wrote: >> Extend framework from commit 53be0b1ad to report latch waits. >> > > I am facing windows below compilation error: > > 1>pgstat.h(726): warning C4005: 'WAIT_TIMEOUT' : macro redefinition > 1>

Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-05 Thread Amit Kapila
On Tue, Oct 4, 2016 at 8:32 PM, Robert Haas wrote: > Extend framework from commit 53be0b1ad to report latch waits. > I am facing windows below compilation error: 1>pgstat.h(726): warning C4005: 'WAIT_TIMEOUT' : macro redefinition 1>c:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\include\wine

Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-04 Thread Robert Haas
On Tue, Oct 4, 2016 at 11:17 AM, Robert Haas wrote: > On Tue, Oct 4, 2016 at 11:12 AM, Tom Lane wrote: >> Robert Haas writes: >>> Extend framework from commit 53be0b1ad to report latch waits. >> >> Buildfarm doesn't like this one bit. > > Hmm, and for good reason. But I swear I ran 'make check-

Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-04 Thread Robert Haas
On Tue, Oct 4, 2016 at 11:12 AM, Tom Lane wrote: > Robert Haas writes: >> Extend framework from commit 53be0b1ad to report latch waits. > > Buildfarm doesn't like this one bit. Hmm, and for good reason. But I swear I ran 'make check-world' before pushing. Argh. -- Robert Haas EnterpriseDB: h

Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-04 Thread Tom Lane
Robert Haas writes: > Extend framework from commit 53be0b1ad to report latch waits. Buildfarm doesn't like this one bit. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postg

[COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-04 Thread Robert Haas
Extend framework from commit 53be0b1ad to report latch waits. WaitLatch, WaitLatchOrSocket, and WaitEventSetWait now taken an additional wait_event_info parameter; legal values are defined in pgstat.h. This makes it possible to uniquely identify every point in the core code where we are waiting f