Re: [COMMITTERS] pgsql: Fix CreatePolicy, pg_dump -v; psql and doc updates

2014-10-03 Thread Stephen Frost
Tom, On Friday, October 3, 2014, Tom Lane wrote: > > Just as a note, this should've included a catversion bump. The rule of > thumb is that if you need to do an initdb (not just a recompile) to get > the regression tests to pass, there should be a catversion bump. And > that applies here, becau

Re: [COMMITTERS] pgsql: Fix CreatePolicy, pg_dump -v; psql and doc updates

2014-10-03 Thread Peter Geoghegan
On Fri, Oct 3, 2014 at 3:06 PM, Tom Lane wrote: > It's not important enough to go back and change catversion.h now, but > please keep it in mind for the future. One of the main values of > catversion is to prevent developers from wasting time chasing regression > test failures that are just code-

Re: [COMMITTERS] pgsql: Fix CreatePolicy, pg_dump -v; psql and doc updates

2014-10-03 Thread Tom Lane
Stephen Frost writes: > Fix CreatePolicy, pg_dump -v; psql and doc updates Just as a note, this should've included a catversion bump. The rule of thumb is that if you need to do an initdb (not just a recompile) to get the regression tests to pass, there should be a catversion bump. And that app

[COMMITTERS] pgsql: Fix CreatePolicy, pg_dump -v; psql and doc updates

2014-10-03 Thread Stephen Frost
Fix CreatePolicy, pg_dump -v; psql and doc updates Peter G pointed out that valgrind was, rightfully, complaining about CreatePolicy() ending up copying beyond the end of the parsed policy name. Name is a fixed-size type and we need to use namein (through DirectFunctionCall1()) to flush out the e