Re: [COMMITTERS] pgsql: Fix building of large (bigger than shared_buffers) hash indexes.

2016-06-27 Thread Tom Lane
Bruce Momjian writes: > On Fri, Jun 24, 2016 at 08:57:47PM +, Tom Lane wrote: >> Fix building of large (bigger than shared_buffers) hash indexes. > Do we have any way of helping people find out if they need to recreate > their hash indexes? I do not think that's much of an issue. The failur

Re: [COMMITTERS] pgsql: Fix building of large (bigger than shared_buffers) hash indexes.

2016-06-27 Thread Peter Geoghegan
On Mon, Jun 27, 2016 at 2:27 PM, Bruce Momjian wrote: > Do we have any way of helping people find out if they need to recreate > their hash indexes? No, but I don't think that it's especially needed. It ought to be completely obvious when the problem arises, because the resulting index is total g

Re: [COMMITTERS] pgsql: Fix building of large (bigger than shared_buffers) hash indexes.

2016-06-27 Thread Bruce Momjian
On Fri, Jun 24, 2016 at 08:57:47PM +, Tom Lane wrote: > Fix building of large (bigger than shared_buffers) hash indexes. > > When the index is predicted to need more than NBuffers buckets, > CREATE INDEX attempts to sort the index entries by hash key before > insertion, so as to reduce thrashi

[COMMITTERS] pgsql: Fix building of large (bigger than shared_buffers) hash indexes.

2016-06-24 Thread Tom Lane
Fix building of large (bigger than shared_buffers) hash indexes. When the index is predicted to need more than NBuffers buckets, CREATE INDEX attempts to sort the index entries by hash key before insertion, so as to reduce thrashing. This code path got broken by commit 9f03ca915196dfc8, which ove

[COMMITTERS] pgsql: Fix building of large (bigger than shared_buffers) hash indexes.

2016-06-24 Thread Tom Lane
Fix building of large (bigger than shared_buffers) hash indexes. When the index is predicted to need more than NBuffers buckets, CREATE INDEX attempts to sort the index entries by hash key before insertion, so as to reduce thrashing. This code path got broken by commit 9f03ca915196dfc8, which ove