Re: [COMMITTERS] pgsql: Identity columns

2017-04-07 Thread Peter Eisentraut
On 4/6/17 23:13, David Rowley wrote: > On 7 April 2017 at 00:44, Peter Eisentraut wrote: >> Identity columns >> >> This is the SQL standard-conforming variant of PostgreSQL's serial >> columns. It fixes a few usability issues that serial columns have: >> >> - CREATE TABLE / LIKE copies default bu

Re: [COMMITTERS] pgsql: Identity columns

2017-04-06 Thread David Rowley
On 7 April 2017 at 00:44, Peter Eisentraut wrote: > Identity columns > > This is the SQL standard-conforming variant of PostgreSQL's serial > columns. It fixes a few usability issues that serial columns have: > > - CREATE TABLE / LIKE copies default but refers to same sequence > - cannot add/drop

Re: [COMMITTERS] pgsql: Identity columns

2017-04-06 Thread Peter Eisentraut
On 4/6/17 10:24, Tom Lane wrote: > This commit is causing a compiler warning for me: > > tablecmds.c: In function 'ATExecSetIdentity': > tablecmds.c:5936: warning: 'address.objectSubId' may be used uninitialized in > this function > tablecmds.c:5936: warning: 'address.objectId' may be used uninit

Re: [COMMITTERS] pgsql: Identity columns

2017-04-06 Thread Tom Lane
Peter Eisentraut writes: > Identity columns This commit is causing a compiler warning for me: tablecmds.c: In function 'ATExecSetIdentity': tablecmds.c:5936: warning: 'address.objectSubId' may be used uninitialized in this function tablecmds.c:5936: warning: 'address.objectId' may be used unini

[COMMITTERS] pgsql: Identity columns

2017-04-06 Thread Peter Eisentraut
Identity columns This is the SQL standard-conforming variant of PostgreSQL's serial columns. It fixes a few usability issues that serial columns have: - CREATE TABLE / LIKE copies default but refers to same sequence - cannot add/drop serialness with ALTER TABLE - dropping default does not drop s