Re: [COMMITTERS] pgsql: Improve index AMs' opclass validation procedures.

2016-01-21 Thread Tom Lane
David Rowley writes: > I'm getting 3 new warnings with this change which mention about 32-bit > bit shifting then bitwise anding to a 64-bit variable. > The attached fixes the warnings Pushed, thanks. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-c

Re: [COMMITTERS] pgsql: Improve index AMs' opclass validation procedures.

2016-01-21 Thread David Rowley
On 22 January 2016 at 13:47, Tom Lane wrote: > Improve index AMs' opclass validation procedures. > > The amvalidate functions added in commit 65c5fcd353a859da were on the > crude side. Improve them in a few ways: > > * Perform signature checking for operators and support functions. > > * Apply mo

[COMMITTERS] pgsql: Improve index AMs' opclass validation procedures.

2016-01-21 Thread Tom Lane
Improve index AMs' opclass validation procedures. The amvalidate functions added in commit 65c5fcd353a859da were on the crude side. Improve them in a few ways: * Perform signature checking for operators and support functions. * Apply more thorough checks for missing operators and functions, whe