Re: [COMMITTERS] pgsql: Improve internationalization of messages involving type names

2016-04-01 Thread Tom Lane
Alvaro Herrera writes: > Alvaro Herrera wrote: >> Tom Lane wrote: >>> Actually, I think the general convention is to NOT quote type names >>> in error messages. >> Ok, I'll change it. > Done. Thanks. Should we make a push to get rid of hard-wired type names in other messages? There's still qu

Re: [COMMITTERS] pgsql: Improve internationalization of messages involving type names

2016-04-01 Thread Alvaro Herrera
Alvaro Herrera wrote: > Tom Lane wrote: > > Actually, I think the general convention is to NOT quote type names > > in error messages. Certainly that's so when using format_type_be() > > to produce a name for a not-known-at-compile-time type. I would > > argue that these messages should be writt

Re: [COMMITTERS] pgsql: Improve internationalization of messages involving type names

2016-03-30 Thread Alvaro Herrera
Tom Lane wrote: > Alvaro Herrera writes: > > Also, change them all to use the same quoting convention, namely that > > the function name is not to be quoted but the type name is. (I'm not > > quite sure why this is so, but it's the clear majority.) > > Actually, I think the general convention is

Re: [COMMITTERS] pgsql: Improve internationalization of messages involving type names

2016-03-28 Thread Tom Lane
Alvaro Herrera writes: > Also, change them all to use the same quoting convention, namely that > the function name is not to be quoted but the type name is. (I'm not > quite sure why this is so, but it's the clear majority.) Actually, I think the general convention is to NOT quote type names in

Re: [COMMITTERS] pgsql: Improve internationalization of messages involving type names

2016-03-28 Thread Stephen Frost
Alvaro, * Alvaro Herrera (alvhe...@alvh.no-ip.org) wrote: > Improve internationalization of messages involving type names > > Change the slightly different variations of the message > function FOO must return type BAR > to a single wording, removing the variability in type name so that they > a

[COMMITTERS] pgsql: Improve internationalization of messages involving type names

2016-03-28 Thread Alvaro Herrera
Improve internationalization of messages involving type names Change the slightly different variations of the message function FOO must return type BAR to a single wording, removing the variability in type name so that they all create a single translation entry; since the type name is not to be