Re: [COMMITTERS] pgsql: Improve tests for postmaster death in auxiliary processes.

2012-05-10 Thread Tom Lane
Peter Geoghegan writes: > On 10 May 2012 05:55, Tom Lane wrote: >> I had already removed the unconditional >> PostmasterIsAlive calls in bgwriter and pgstat in previous patches, but >> forgot that WL_POSTMASTER_DEATH is supposed to be treated as untrustworthy >> (per comment in unix_latch.c); so

Re: [COMMITTERS] pgsql: Improve tests for postmaster death in auxiliary processes.

2012-05-10 Thread Peter Geoghegan
On 10 May 2012 05:55, Tom Lane wrote: > In checkpointer and walwriter, avoid calling PostmasterIsAlive unless > WaitLatch has reported WL_POSTMASTER_DEATH.  This saves a kernel call per > iteration of the process's outer loop, which is not all that much, but a > cycle shaved is a cycle earned.  I

[COMMITTERS] pgsql: Improve tests for postmaster death in auxiliary processes.

2012-05-09 Thread Tom Lane
Improve tests for postmaster death in auxiliary processes. In checkpointer and walwriter, avoid calling PostmasterIsAlive unless WaitLatch has reported WL_POSTMASTER_DEATH. This saves a kernel call per iteration of the process's outer loop, which is not all that much, but a cycle shaved is a cycl