[COMMITTERS] pgsql: Introduce replication slots.

2014-01-31 Thread Robert Haas
Introduce replication slots. Replication slots are a crash-safe data structure which can be created on either a master or a standby to prevent premature removal of write-ahead log segments needed by a standby, as well as (with hot_standby_feedback=on) pruning of tuples whose removal would cause re

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-01-31 Thread Fujii Masao
On Sat, Feb 1, 2014 at 12:50 PM, Robert Haas wrote: > Introduce replication slots. > > Replication slots are a crash-safe data structure which can be created > on either a master or a standby to prevent premature removal of > write-ahead log segments needed by a standby, as well as (with > hot_sta

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-01 Thread Andres Freund
On 2014-02-01 16:47:47 +0900, Fujii Masao wrote: > On Sat, Feb 1, 2014 at 12:50 PM, Robert Haas wrote: > > Introduce replication slots. > > > > Replication slots are a crash-safe data structure which can be created > > on either a master or a standby to prevent premature removal of > > write-ahead

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-01 Thread Fujii Masao
On Sat, Feb 1, 2014 at 6:09 PM, Andres Freund wrote: > On 2014-02-01 16:47:47 +0900, Fujii Masao wrote: >> On Sat, Feb 1, 2014 at 12:50 PM, Robert Haas wrote: >> > Introduce replication slots. >> > >> > Replication slots are a crash-safe data structure which can be created >> > on either a master

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-01 Thread Andres Freund
On 2014-02-01 18:33:08 +0900, Fujii Masao wrote: > On Sat, Feb 1, 2014 at 6:09 PM, Andres Freund wrote: > > On 2014-02-01 16:47:47 +0900, Fujii Masao wrote: > >> This patch changed basebackup.c so that it skips pg_replslot. It's OK > >> to skip all files in that directory, but an empty pg_replslot

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-01 Thread Thom Brown
On 1 February 2014 04:50, Robert Haas wrote: > doc/src/sgml/high-availability.sgml| 94 +- s/configuration a replication slot/configuring a replication/ > doc/src/sgml/ref/pg_receivexlog.sgml s/paramter/parameter/ > src/backend/replication/slot.c | 1066 +

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-01 Thread Fujii Masao
On Sat, Feb 1, 2014 at 6:37 PM, Andres Freund wrote: > On 2014-02-01 18:33:08 +0900, Fujii Masao wrote: >> On Sat, Feb 1, 2014 at 6:09 PM, Andres Freund wrote: >> > On 2014-02-01 16:47:47 +0900, Fujii Masao wrote: >> >> This patch changed basebackup.c so that it skips pg_replslot. It's OK >> >> t

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-01 Thread Fujii Masao
On Sun, Feb 2, 2014 at 8:19 AM, Thom Brown wrote: > On 1 February 2014 04:50, Robert Haas wrote: >> doc/src/sgml/high-availability.sgml| 94 +- > > s/configuration a replication slot/configuring a replication/ > > >> doc/src/sgml/ref/pg_receivexlog.sgml > > s/paramter/parameter/

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-02 Thread Andres Freund
On 2014-02-02 14:44:17 +0900, Fujii Masao wrote: > On Sat, Feb 1, 2014 at 6:37 PM, Andres Freund wrote: > > On 2014-02-01 18:33:08 +0900, Fujii Masao wrote: > >> On Sat, Feb 1, 2014 at 6:09 PM, Andres Freund > >> wrote: > >> > On 2014-02-01 16:47:47 +0900, Fujii Masao wrote: > >> >> This patch c

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-02 Thread Fujii Masao
On Sun, Feb 2, 2014 at 11:06 PM, Andres Freund wrote: > On 2014-02-02 14:44:17 +0900, Fujii Masao wrote: >> On Sat, Feb 1, 2014 at 6:37 PM, Andres Freund wrote: >> > On 2014-02-01 18:33:08 +0900, Fujii Masao wrote: >> >> On Sat, Feb 1, 2014 at 6:09 PM, Andres Freund >> >> wrote: >> >> > On 2014

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-03 Thread Michael Paquier
On Sat, Feb 1, 2014 at 6:33 PM, Fujii Masao wrote: > On Sat, Feb 1, 2014 at 6:09 PM, Andres Freund wrote: >> On 2014-02-01 16:47:47 +0900, Fujii Masao wrote: >>> On Sat, Feb 1, 2014 at 12:50 PM, Robert Haas wrote: >>> > Introduce replication slots. >>> > >>> > Replication slots are a crash-safe

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-04 Thread Jeff Davis
Also, in 25.2.6: "or by storing the segments in an archive using restore_command". I think you meant "archive_command", right? Jeff Davis -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailp

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-05 Thread Robert Haas
On Tue, Feb 4, 2014 at 2:29 PM, Jeff Davis wrote: > Also, in 25.2.6: > > "or by storing the segments in an archive using restore_command". > > I think you meant "archive_command", right? Yep, thanks. Fixed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Comp

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-06 Thread Thom Brown
On 4 February 2014 05:19, Michael Paquier wrote: > On Sat, Feb 1, 2014 at 6:33 PM, Fujii Masao wrote: >> On Sat, Feb 1, 2014 at 6:09 PM, Andres Freund wrote: >>> On 2014-02-01 16:47:47 +0900, Fujii Masao wrote: On Sat, Feb 1, 2014 at 12:50 PM, Robert Haas wrote: > Introduce replicatio

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-06 Thread Andres Freund
Hi Fujii, On 2014-02-01 16:47:47 +0900, Fujii Masao wrote: > This patch changed basebackup.c so that it skips pg_replslot. It's OK > to skip all files in that directory, but an empty pg_replslot must be > included in the backup. Otherwise we cannot start PostgreSQL from > the backup taken via pg_b

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-25 Thread Thom Brown
On 6 February 2014 10:29, Andres Freund wrote: > Hi Fujii, > > On 2014-02-01 16:47:47 +0900, Fujii Masao wrote: > > This patch changed basebackup.c so that it skips pg_replslot. It's OK > > to skip all files in that directory, but an empty pg_replslot must be > > included in the backup. Otherwise

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-25 Thread Robert Haas
On Tue, Feb 25, 2014 at 10:11 AM, Thom Brown wrote: > On 6 February 2014 10:29, Andres Freund wrote: >> Hi Fujii, >> >> On 2014-02-01 16:47:47 +0900, Fujii Masao wrote: >> > This patch changed basebackup.c so that it skips pg_replslot. It's OK >> > to skip all files in that directory, but an empt

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-27 Thread Andres Freund
Hi, Vik Faering noticed a couple of oversights in the replication slot function reference, and I noticed some more, including using the text type instead of name, while looking. Patch attached. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ Postgre

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-28 Thread Thom Brown
On 1 February 2014 03:50, Robert Haas wrote: > Introduce replication slots. > > Replication slots are a crash-safe data structure which can be created > on either a master or a standby to prevent premature removal of > write-ahead log segments needed by a standby, as well as (with > hot_standby_f

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-28 Thread Andres Freund
On 2014-02-28 19:05:40 +, Thom Brown wrote: > On 1 February 2014 03:50, Robert Haas wrote: > > > Introduce replication slots. > > > > Replication slots are a crash-safe data structure which can be created > > on either a master or a standby to prevent premature removal of > > write-ahead log

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-28 Thread Thom Brown
On 28 February 2014 19:22, Andres Freund wrote: > On 2014-02-28 19:05:40 +, Thom Brown wrote: > > On 1 February 2014 03:50, Robert Haas wrote: > > > > > Introduce replication slots. > > > > > > Replication slots are a crash-safe data structure which can be created > > > on either a master or

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-03-03 Thread Robert Haas
On Fri, Feb 28, 2014 at 2:22 PM, Andres Freund wrote: >> So now that I've actually gone to use physical replication slots, I can't >> get them working. > > Aw yuck. Try a shorter name. libpqrcv_startstreaming is truncating the > identifier if it's too long... > > Patch fixing that attached. Commi

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-03-05 Thread Thom Brown
On 25 February 2014 16:25, Robert Haas wrote: > Since Fujii Masao doesn't seem to be around, I'll commit this. But > don't we need to update the documentation as well, for those using the > file-copy method of taking a backup? > Yes, that sounds like a sensible idea. -- Thom