Re: [COMMITTERS] pgsql: Introduce timeout handling framework

2012-07-17 Thread Tom Lane
Peter Geoghegan writes: > Perhaps I'm asking a naive question, but wouldn't it be easier if > people had the opportunity to use the buildfarm without actually > committing something? Why? The whole point of the buildfarm is to break, as it were. I don't see the value of adding more bureaucracy i

Re: [COMMITTERS] pgsql: Introduce timeout handling framework

2012-07-17 Thread Andrew Dunstan
On 07/17/2012 11:08 AM, Peter Geoghegan wrote: On 17 July 2012 14:43, Andrew Dunstan wrote: This seems to have broken Windows builds. (And if people need reminding, cross-compiling is pretty easy:

Re: [COMMITTERS] pgsql: Introduce timeout handling framework

2012-07-17 Thread Tom Lane
Alvaro Herrera writes: > Excerpts from Tom Lane's message of mar jul 17 10:07:53 -0400 2012: >> Yeah, my fault I think. I took out proc.h from postmaster.h, thinking >> it wasn't needed anymore, but the EXEC_BACKEND code needs it. > Will fix. Oh, I did it already. regar

Re: [COMMITTERS] pgsql: Introduce timeout handling framework

2012-07-17 Thread Alvaro Herrera
Excerpts from Tom Lane's message of mar jul 17 10:07:53 -0400 2012: > Andrew Dunstan writes: > > On 07/17/2012 12:03 AM, Alvaro Herrera wrote: > >> Introduce timeout handling framework > > > This seems to have broken Windows builds. > > Yeah, my fault I think. I took out proc.h from postmaster

Re: [COMMITTERS] pgsql: Introduce timeout handling framework

2012-07-17 Thread Peter Geoghegan
On 17 July 2012 14:43, Andrew Dunstan wrote: > This seems to have broken Windows builds. (And if people need reminding, > cross-compiling is pretty easy: > > ) Perhaps I'm asking a naiv

Re: [COMMITTERS] pgsql: Introduce timeout handling framework

2012-07-17 Thread Tom Lane
Andrew Dunstan writes: > On 07/17/2012 12:03 AM, Alvaro Herrera wrote: >> Introduce timeout handling framework > This seems to have broken Windows builds. Yeah, my fault I think. I took out proc.h from postmaster.h, thinking it wasn't needed anymore, but the EXEC_BACKEND code needs it.

Re: [COMMITTERS] pgsql: Introduce timeout handling framework

2012-07-17 Thread Andrew Dunstan
On 07/17/2012 12:03 AM, Alvaro Herrera wrote: Introduce timeout handling framework This seems to have broken Windows builds. (And if people need reminding, cross-compiling is pretty easy:

[COMMITTERS] pgsql: Introduce timeout handling framework

2012-07-16 Thread Alvaro Herrera
Introduce timeout handling framework Management of timeouts was getting a little cumbersome; what we originally had was more than enough back when we were only concerned about deadlocks and query cancel; however, when we added timeouts for standby processes, the code got considerably messier. Sin