Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file

2015-05-12 Thread Amit Kapila
On Tue, May 12, 2015 at 9:02 PM, Andrew Dunstan wrote: > > On 05/12/2015 10:33 AM, Heikki Linnakangas wrote: > >> On 05/12/2015 04:42 PM, Andrew Dunstan wrote: >> >>> + >>> + /* >>> +* Remove the existing symlink if any and Create the >>> symlink >>> +

Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file

2015-05-12 Thread Andrew Dunstan
On 05/12/2015 10:33 AM, Heikki Linnakangas wrote: On 05/12/2015 04:42 PM, Andrew Dunstan wrote: + + /* +* Remove the existing symlink if any and Create the symlink +* under PGDATA. We need to use rmtree instead of rmdir as +* the

Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file

2015-05-12 Thread Heikki Linnakangas
On 05/12/2015 04:42 PM, Andrew Dunstan wrote: + + /* +* Remove the existing symlink if any and Create the symlink +* under PGDATA. We need to use rmtree instead of rmdir as +* the link location might contain directories or files +

[COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file

2015-05-12 Thread Andrew Dunstan
Map basebackup tablespaces using a tablespace_map file Windows can't reliably restore symbolic links from a tar format, so instead during backup start we create a tablespace_map file, which is used by the restoring postgres to create the correct links in pg_tblspc. The backup protocol also now has