Re: [COMMITTERS] pgsql: Properly handle empty arrays returned from plperl functions.

2011-08-18 Thread Robert Haas
On Wed, Aug 17, 2011 at 5:17 PM, Andrew Dunstan wrote: > It's not a script. "git commit -F filename" is the culprit. It seems if you > intend to reuse the message file that git carefully saves for you, you need > to trim the comment lines. What I did was in the master branch, "git commit > -a" and

Re: [COMMITTERS] pgsql: Properly handle empty arrays returned from plperl functions.

2011-08-17 Thread Andrew Dunstan
On 08/17/2011 04:59 PM, David Fetter wrote: On Wed, Aug 17, 2011 at 01:29:01PM -0400, Andrew Dunstan wrote: On 08/17/2011 12:53 PM, Alvaro Herrera wrote: Excerpts from Andrew Dunstan's message of mié ago 17 12:41:47 -0400 2011: Wow, sorry for the noise. I guess I'll be more careful about re

Re: [COMMITTERS] pgsql: Properly handle empty arrays returned from plperl functions.

2011-08-17 Thread David Fetter
On Wed, Aug 17, 2011 at 01:29:01PM -0400, Andrew Dunstan wrote: > > > On 08/17/2011 12:53 PM, Alvaro Herrera wrote: > >Excerpts from Andrew Dunstan's message of mié ago 17 12:41:47 -0400 2011: > >>Wow, sorry for the noise. I guess I'll be more careful about reusing a > >>commit-message file. > >H

Re: [COMMITTERS] pgsql: Properly handle empty arrays returned from plperl functions.

2011-08-17 Thread Andrew Dunstan
On 08/17/2011 12:53 PM, Alvaro Herrera wrote: Excerpts from Andrew Dunstan's message of mié ago 17 12:41:47 -0400 2011: Wow, sorry for the noise. I guess I'll be more careful about reusing a commit-message file. Happened to me once too (back when we used CVS). It seems the filter to remove u

Re: [COMMITTERS] pgsql: Properly handle empty arrays returned from plperl functions.

2011-08-17 Thread Alvaro Herrera
Excerpts from Andrew Dunstan's message of mié ago 17 12:41:47 -0400 2011: > > Wow, sorry for the noise. I guess I'll be more careful about reusing a > commit-message file. Happened to me once too (back when we used CVS). It seems the filter to remove unwanted lines is not applied when the file

Re: [COMMITTERS] pgsql: Properly handle empty arrays returned from plperl functions.

2011-08-17 Thread Andrew Dunstan
Wow, sorry for the noise. I guess I'll be more careful about reusing a commit-message file. cheers andrew On 08/17/2011 12:04 PM, Andrew Dunstan wrote: Properly handle empty arrays returned from plperl functions. Bug reported by David Wheeler, fix by Alex Hunsaker. # Please enter the comm

[COMMITTERS] pgsql: Properly handle empty arrays returned from plperl functions.

2011-08-17 Thread Andrew Dunstan
Properly handle empty arrays returned from plperl functions. Bug reported by David Wheeler, fix by Alex Hunsaker. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/68c903a66ce6f766a8c99d07034374109859624f Modified Files -- src/pl/plperl/plperl.c | 10 +++

[COMMITTERS] pgsql: Properly handle empty arrays returned from plperl functions.

2011-08-17 Thread Andrew Dunstan
Properly handle empty arrays returned from plperl functions. Bug reported by David Wheeler, fix by Alex Hunsaker. # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # On branch master # Changes to be committed: #