[COMMITTERS] pgsql: Provide errno-translation wrappers around bind() and listen() on

2016-04-12 Thread Tom Lane
Provide errno-translation wrappers around bind() and listen() on Windows. I've seen one too many "could not bind IPv4 socket: No error" log entries from the Windows buildfarm members. Per previous discussion, this is likely caused by the fact that we're doing nothing to translate WSAGetLastError(

[COMMITTERS] pgsql: Provide errno-translation wrappers around bind() and listen() on

2016-04-21 Thread Tom Lane
Provide errno-translation wrappers around bind() and listen() on Windows. Fix Windows builds to report something useful rather than "could not bind IPv4 socket: No error" when bind() fails. Back-patch of commits d1b7d4877b9a71f4 and 22989a8e34168f57. Discussion: <4065.1452450...@sss.pgh.pa.us>

[COMMITTERS] pgsql: Provide errno-translation wrappers around bind() and listen() on

2016-04-21 Thread Tom Lane
Provide errno-translation wrappers around bind() and listen() on Windows. Fix Windows builds to report something useful rather than "could not bind IPv4 socket: No error" when bind() fails. Back-patch of commits d1b7d4877b9a71f4 and 22989a8e34168f57. Discussion: <4065.1452450...@sss.pgh.pa.us>

[COMMITTERS] pgsql: Provide errno-translation wrappers around bind() and listen() on

2016-04-21 Thread Tom Lane
Provide errno-translation wrappers around bind() and listen() on Windows. Fix Windows builds to report something useful rather than "could not bind IPv4 socket: No error" when bind() fails. Back-patch of commits d1b7d4877b9a71f4 and 22989a8e34168f57. Discussion: <4065.1452450...@sss.pgh.pa.us>

[COMMITTERS] pgsql: Provide errno-translation wrappers around bind() and listen() on

2016-04-21 Thread Tom Lane
Provide errno-translation wrappers around bind() and listen() on Windows. Fix Windows builds to report something useful rather than "could not bind IPv4 socket: No error" when bind() fails. Back-patch of commits d1b7d4877b9a71f4 and 22989a8e34168f57. Discussion: <4065.1452450...@sss.pgh.pa.us>

[COMMITTERS] pgsql: Provide errno-translation wrappers around bind() and listen() on

2016-04-21 Thread Tom Lane
Provide errno-translation wrappers around bind() and listen() on Windows. Fix Windows builds to report something useful rather than "could not bind IPv4 socket: No error" when bind() fails. Back-patch of commits d1b7d4877b9a71f4 and 22989a8e34168f57. Discussion: <4065.1452450...@sss.pgh.pa.us>

Re: [COMMITTERS] pgsql: Provide errno-translation wrappers around bind() and listen() on

2016-04-13 Thread David Rowley
On 13 April 2016 at 11:52, Tom Lane wrote: > Provide errno-translation wrappers around bind() and listen() on Windows. > > I've seen one too many "could not bind IPv4 socket: No error" log entries > from the Windows buildfarm members. Per previous discussion, this is > likely caused by the fact t

Re: [COMMITTERS] pgsql: Provide errno-translation wrappers around bind() and listen() on

2016-04-14 Thread Tom Lane
David Rowley writes: > On 13 April 2016 at 11:52, Tom Lane wrote: >> Provide errno-translation wrappers around bind() and listen() on Windows. > I'm not really sure why you made pgwin32_bind take a pointer to an > int, instead of just an int. I assume a mistake? Sheer brain fade, exacerbated by