Re: [COMMITTERS] pgsql: Remove secondary checkpoint

2017-11-11 Thread Andreas Seltenreich
Hi, sqlsmith doesn't like commit 4b0d28de06: , | regression=> select * from pg_control_checkpoint(); | server closed the connection unexpectedly | TRAP: FailedAssertion("!((atti->attalign) == 's')", File: "heaptuple.c", Line: 126) ` On a build with assertions disabled, the statement fai

Re: [COMMITTERS] pgsql: Remove secondary checkpoint

2017-11-07 Thread Michael Paquier
On Wed, Nov 8, 2017 at 4:43 AM, Tom Lane wrote: > Andres Freund writes: >> I think you misunderstand my point - I'm saying that pg_resetxlog should >> be able to force the use of older checkpoints, basically as a fallback >> to cases where the previous approach might actually have worked, not >>

Re: [COMMITTERS] pgsql: Remove secondary checkpoint

2017-11-07 Thread Tom Lane
Andres Freund writes: > I think you misunderstand my point - I'm saying that pg_resetxlog should > be able to force the use of older checkpoints, basically as a fallback > to cases where the previous approach might actually have worked, not > that it needs to work across format changes. That seem

Re: [COMMITTERS] pgsql: Remove secondary checkpoint

2017-11-07 Thread Andres Freund
On 2017-11-07 14:12:19 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2017-11-07 17:57:31 +, Simon Riggs wrote: > >> Remove secondary checkpoint > > > FWIW, I don't think this should be applied without a pg_resetxlog > > feature allowing to manually use older checkpoints. > > Uh, what

Re: [COMMITTERS] pgsql: Remove secondary checkpoint

2017-11-07 Thread Tom Lane
Andres Freund writes: > On 2017-11-07 17:57:31 +, Simon Riggs wrote: >> Remove secondary checkpoint > FWIW, I don't think this should be applied without a pg_resetxlog > feature allowing to manually use older checkpoints. Uh, what? We have never before insisted on pg_resetxlog being able to

Re: [COMMITTERS] pgsql: Remove secondary checkpoint

2017-11-07 Thread Andres Freund
On 2017-11-07 17:57:31 +, Simon Riggs wrote: > Remove secondary checkpoint > > Previously server reserved WAL for last two checkpoints, > which used too much disk space for small servers. > > Bumps PG_CONTROL_VERSION FWIW, I don't think this should be applied without a pg_resetxlog feature a

[COMMITTERS] pgsql: Remove secondary checkpoint

2017-11-07 Thread Simon Riggs
Remove secondary checkpoint Previously server reserved WAL for last two checkpoints, which used too much disk space for small servers. Bumps PG_CONTROL_VERSION Author: Simon Riggs Reviewed-by: Michael Paquier Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4b0d2