Re: [COMMITTERS] pgsql: Replace PostmasterRandom() with a stronger source, second attemp

2016-12-06 Thread Heikki Linnakangas
On 12/07/2016 02:30 AM, Michael Paquier wrote: With the logs complaining as well: [1-1] db=[unknown],user=[unknown],app=[unknown],client=[local] LOG: wrong key in cancel request for process 57361 As far as I can see processCancelRequest uses a long variable, and it gets compared with an int32. M

Re: [COMMITTERS] pgsql: Replace PostmasterRandom() with a stronger source, second attemp

2016-12-06 Thread Heikki Linnakangas
On 12/07/2016 01:56 AM, Thomas Munro wrote: On Tue, Dec 6, 2016 at 12:44 AM, Heikki Linnakangas wrote: src/backend/storage/lmgr/lwlocknames.txt | 1 + Missing one tab? Fixed, thanks. I missed this because my editor is set up to use 4-space tabs for .c and .h files, but not for

Re: [COMMITTERS] pgsql: Replace PostmasterRandom() with a stronger source, second attemp

2016-12-06 Thread Michael Paquier
On Wed, Dec 7, 2016 at 7:46 AM, Andres Freund wrote: > On 2016-12-05 11:44:37 +, Heikki Linnakangas wrote: >> Replace PostmasterRandom() with a stronger source, second attempt. > > Since this went in I've seen > 2016-12-06 14:42:17.005 PST [23658][] LOG: wrong key in cancel request for > pro

Re: [COMMITTERS] pgsql: Replace PostmasterRandom() with a stronger source, second attemp

2016-12-06 Thread Thomas Munro
On Tue, Dec 6, 2016 at 12:44 AM, Heikki Linnakangas wrote: > src/backend/storage/lmgr/lwlocknames.txt | 1 + Missing one tab? -- Thomas Munro http://www.enterprisedb.com whitespace.patch Description: Binary data -- Sent via pgsql-committers mailing list (pgsql-committers@postgres

Re: [COMMITTERS] pgsql: Replace PostmasterRandom() with a stronger source, second attemp

2016-12-06 Thread Andres Freund
On 2016-12-05 11:44:37 +, Heikki Linnakangas wrote: > Replace PostmasterRandom() with a stronger source, second attempt. Since this went in I've seen 2016-12-06 14:42:17.005 PST [23658][] LOG: wrong key in cancel request for process 23657 2016-12-06 14:42:19.010 PST [23662][] LOG: wrong key

[COMMITTERS] pgsql: Replace PostmasterRandom() with a stronger source, second attemp

2016-12-05 Thread Heikki Linnakangas
Replace PostmasterRandom() with a stronger source, second attempt. This adds a new routine, pg_strong_random() for generating random bytes, for use in both frontend and backend. At the moment, it's only used in the backend, but the upcoming SCRAM authentication patches need strong random numbers i