On Fri, Jul 17, 2015 at 11:16 PM, Kevin Grittner wrote:
> Heikki Linnakangas wrote:
>
>> This fixes bug #13126, reported by Kirill Simonov.
>
> It looks like you missed something with the addition of
> AT_ReAddComment:
>
> test_ddl_deparse.c:80:11: warning: enumeration value 'AT_ReAddComment' not
Heikki Linnakangas wrote:
> This fixes bug #13126, reported by Kirill Simonov.
It looks like you missed something with the addition of
AT_ReAddComment:
test_ddl_deparse.c:80:11: warning: enumeration value 'AT_ReAddComment' not
handled in switch [-Wswitch]
switch (subcmd->subtyp
On 07/14/2015 04:02 PM, Tom Lane wrote:
Heikki Linnakangas writes:
Retain comments on indexes and constraints at ALTER TABLE ... TYPE ...
One or the other of these patches has broken the majority of the
buildfarm.
Ah, the order of the rows in the test queries was not stable. Added
ORDER BY
On Tue, Jul 14, 2015 at 10:02 PM, Tom Lane wrote:
> Heikki Linnakangas writes:
>> Retain comments on indexes and constraints at ALTER TABLE ... TYPE ...
>
> One or the other of these patches has broken the majority of the
> buildfarm.
Some ORDER BY clauses are missing to make the output consiste
Heikki Linnakangas writes:
> Retain comments on indexes and constraints at ALTER TABLE ... TYPE ...
One or the other of these patches has broken the majority of the
buildfarm.
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
Retain comments on indexes and constraints at ALTER TABLE ... TYPE ...
When a column's datatype is changed, ATExecAlterColumnType() rebuilds all
the affected indexes and constraints, and the comments from the old
indexes/constraints were not carried over.
To fix, create a synthetic COMMENT ON com
Retain comments on indexes and constraints at ALTER TABLE ... TYPE ...
When a column's datatype is changed, ATExecAlterColumnType() rebuilds all
the affected indexes and constraints, and the comments from the old
indexes/constraints were not carried over.
To fix, create a synthetic COMMENT ON com
