[COMMITTERS] pgsql: Silence compiler warning.

2017-02-02 Thread Heikki Linnakangas
Silence compiler warning. Not all compilers understand that the elog(ERROR) never returns. David Rowley Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cb695ae993a38a0600a907154cfcc71285a9b9ef Modified Files -- src/backend/libpq/crypt.c | 1 + 1 file

[COMMITTERS] pgsql: Silence compiler warning

2017-01-01 Thread Magnus Hagander
Silence compiler warning Caused by the backpatch of f650882 past the point where interrupt handling was changed. Noted by Dean Rasheed Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/f832a1e9e9a889c1c08a60db5520327bc0569fd6 Modified Files --

[COMMITTERS] pgsql: Silence compiler warning.

2016-12-08 Thread Robert Haas
Silence compiler warning. Per report from Stephen Frost. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ab4575dcf18fad1bc20d4a1bde6dc33c8d2561b6 Modified Files -- src/backend/catalog/partition.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --

[COMMITTERS] pgsql: Silence compiler warning

2016-04-04 Thread Alvaro Herrera
Silence compiler warning Reported by Peter Eisentraut to occur on 32bit systems Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c9ff752a854b687fc0a05fd4aba1066028ec5495 Modified Files -- src/backend/access/transam/xlogreader.c | 8 1 file

[COMMITTERS] pgsql: Silence compiler warning about variable being used uninitialized

2014-11-20 Thread Heikki Linnakangas
Silence compiler warning about variable being used uninitialized. It's a false positive - the variable is only used when 'onleft' is true, and it is initialized in that case. But the compiler doesn't necessarily see that. Branch -- master Details ---

[COMMITTERS] pgsql: Silence compiler warning on Windows.

2014-09-11 Thread Heikki Linnakangas
Silence compiler warning on Windows. David Rowley. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0ed41529f6ab92b836336fdd096f924838eea1d7 Modified Files -- src/backend/utils/adt/arrayfuncs.c |3 +++ 1 file changed, 3 insertions(+) -- Sent via

[COMMITTERS] pgsql: Silence compiler warning.

2014-01-23 Thread Heikki Linnakangas
Silence compiler warning. Not all compilers understand that elog(ERROR, ...) never returns. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0fdb2f7d7c0059a1621710206ed506124cf98f77 Modified Files -- src/backend/access/gin/ginbtree.c |3 +++ 1 file

[COMMITTERS] pgsql: Silence compiler warning on MSVC.

2014-01-07 Thread Heikki Linnakangas
Silence compiler warning on MSVC. MSVC doesn't know that elog(ERROR) doesn't return, and gives a warning about missing return. Silence that. Amit Kapila Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f68220df92cb56f0452919f51eeef16262ec8f3b Modified Files

[COMMITTERS] pgsql: Silence compiler warning on an unused variable

2013-07-22 Thread Alvaro Herrera
Silence compiler warning on an unused variable Also, tweak wording in comments (per Andres) and documentation (myself) to point out that it's the database's default tablespace that can be passed as 0, not DEFAULTTABLESPACE_OID. Robert Haas noticed the bug in the code, but didn't update the

[COMMITTERS] pgsql: Silence compiler warning in assertion-enabled builds.

2013-07-02 Thread Heikki Linnakangas
Silence compiler warning in assertion-enabled builds. With -Wtype-limits, gcc correctly points out that size_t can never be 0. Backpatch to 9.3 and 9.2. It's been like this forever, but in = 9.1 you got a lot other warnings with -Wtype-limits anyway (at least with my version of gcc). Andres

[COMMITTERS] pgsql: Silence compiler warning in assertion-enabled builds.

2013-07-02 Thread Heikki Linnakangas
Silence compiler warning in assertion-enabled builds. With -Wtype-limits, gcc correctly points out that size_t can never be 0. Backpatch to 9.3 and 9.2. It's been like this forever, but in = 9.1 you got a lot other warnings with -Wtype-limits anyway (at least with my version of gcc). Andres

[COMMITTERS] pgsql: Silence compiler warning in assertion-enabled builds.

2013-07-02 Thread Heikki Linnakangas
Silence compiler warning in assertion-enabled builds. With -Wtype-limits, gcc correctly points out that size_t can never be 0. Backpatch to 9.3 and 9.2. It's been like this forever, but in = 9.1 you got a lot other warnings with -Wtype-limits anyway (at least with my version of gcc). Andres

[COMMITTERS] pgsql: Silence compiler warning about pointer type mismatch on some pla

2012-10-02 Thread Heikki Linnakangas
Silence compiler warning about pointer type mismatch on some platforms. timeval.t_sec is of type time_t, which is not always compatible with long. I'm not sure if this was just harmless warning or a real bug, but this fixes it, anyway. Branch -- REL9_2_STABLE Details ---

[COMMITTERS] pgsql: Silence compiler warning about pointer type mismatch on some pla

2012-10-02 Thread Heikki Linnakangas
Silence compiler warning about pointer type mismatch on some platforms. timeval.t_sec is of type time_t, which is not always compatible with long. I'm not sure if this was just harmless warning or a real bug, but this fixes it, anyway. Branch -- master Details ---

Re: [COMMITTERS] pgsql: Silence compiler warning about pointer type mismatch on some pla

2012-10-02 Thread Fujii Masao
On Tue, Oct 2, 2012 at 11:47 PM, Heikki Linnakangas heikki.linnakan...@iki.fi wrote: Silence compiler warning about pointer type mismatch on some platforms. timeval.t_sec is of type time_t, which is not always compatible with long. I'm not sure if this was just harmless warning or a real bug,

Re: [COMMITTERS] pgsql: Silence compiler warning about pointer type mismatch on some pla

2012-10-02 Thread Heikki Linnakangas
On 02.10.2012 19:33, Fujii Masao wrote: On Tue, Oct 2, 2012 at 11:47 PM, Heikki Linnakangas heikki.linnakan...@iki.fi wrote: Silence compiler warning about pointer type mismatch on some platforms. timeval.t_sec is of type time_t, which is not always compatible with long. I'm not sure if this

[COMMITTERS] pgsql: Silence compiler warning about uninitialized variable.

2012-03-27 Thread Tom Lane
Silence compiler warning about uninitialized variable. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/98316e211b60cb160247171e3557b40a247c4610 Modified Files -- contrib/pg_upgrade/exec.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) --

[COMMITTERS] pgsql: Silence compiler warning about uninitialized variable.

2011-07-25 Thread Andrew Dunstan
Silence compiler warning about uninitialized variable. It is set correctly on the only path that uses it, but the compiler can't know that. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/74e6d37276564d4be1f60d9edb76d7d066395773 Modified Files --

[COMMITTERS] pgsql: Silence compiler warning about unused variable on Windows.

2011-04-19 Thread Heikki Linnakangas
Silence compiler warning about unused variable on Windows. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a7cb69a5a345fe9ba481a035559d77abd07791d9 Modified Files -- src/interfaces/libpq/fe-connect.c |2 ++ 1 files changed, 2 insertions(+), 0

[COMMITTERS] pgsql: Silence compiler warning about unused variable on Windows.

2011-04-19 Thread Heikki Linnakangas
Silence compiler warning about unused variable on Windows. Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/b2e2d3a3781c717ee826d01d83e55009321ac24d Modified Files -- src/interfaces/libpq/fe-connect.c |2 ++ 1 files changed, 2 insertions(+), 0

[COMMITTERS] pgsql: Silence compiler warning about undefined function when compiling

2011-03-07 Thread Heikki Linnakangas
Silence compiler warning about undefined function when compiling without assertions. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/baabf05196922164db80bdc45fd0660c8700f1f7 Modified Files -- src/backend/replication/syncrep.c |2 ++ 1 files changed, 2

[COMMITTERS] pgsql: Silence compiler warning about uninitialized variable, noted by

2011-01-23 Thread Heikki Linnakangas
Silence compiler warning about uninitialized variable, noted by Itagaki Takahiro Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=56d77c9e56adbd856beba00af3dc607687d30198 Modified Files -- src/bin/pg_dump/pg_backup_archiver.c |

[COMMITTERS] pgsql: Silence compiler warning, noted by Stefan Kaltenbrunner

2010-01-17 Thread Magnus Hagander
Log Message: --- Silence compiler warning, noted by Stefan Kaltenbrunner Modified Files: -- pgsql/contrib/xml2: xpath.c (r1.24 - r1.25) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/xml2/xpath.c?r1=1.24r2=1.25) -- Sent via pgsql-committers

[COMMITTERS] pgsql: Silence compiler warning about uninitialized variables.

2010-01-06 Thread Takahiro Itagaki
Log Message: --- Silence compiler warning about uninitialized variables. This initialization is not necessary needed, but some compilers complain about it. Modified Files: -- pgsql/src/backend/commands: cluster.c (r1.191 - r1.192)

[COMMITTERS] pgsql: Silence compiler warning about printf format for HANDLE.

2010-01-03 Thread Takahiro Itagaki
Log Message: --- Silence compiler warning about printf format for HANDLE. Modified Files: -- pgsql/src/backend/port: win32_shmem.c (r1.14 - r1.15) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/port/win32_shmem.c?r1=1.14r2=1.15) -- Sent via

[COMMITTERS] pgsql: Silence compiler warning on 64-bit windows build

2010-01-01 Thread Magnus Hagander
Log Message: --- Silence compiler warning on 64-bit windows build Modified Files: -- pgsql/src/backend/utils/mmgr: aset.c (r1.80 - r1.81) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/mmgr/aset.c?r1=1.80r2=1.81) -- Sent via

[COMMITTERS] pgsql: Silence compiler warning on win32.

2009-01-27 Thread Magnus Hagander
Log Message: --- Silence compiler warning on win32. ITAGAKI Takahiro Modified Files: -- pgsql/src/test/regress: pg_regress.c (r1.57 - r1.58) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/pg_regress.c?r1=1.57r2=1.58) -- Sent via

Re: [COMMITTERS] pgsql: Silence compiler warning on win32.

2009-01-27 Thread Tom Lane
m...@postgresql.org (Magnus Hagander) writes: pgsql/src/test/regress: pg_regress.c (r1.57 - r1.58) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/pg_regress.c?r1=1.57r2=1.58) Surely this patch is wrong. It is suppressing, not fixing, a critical warning

Re: [COMMITTERS] pgsql: Silence compiler warning on win32.

2009-01-27 Thread Magnus Hagander
Tom Lane wrote: m...@postgresql.org (Magnus Hagander) writes: pgsql/src/test/regress: pg_regress.c (r1.57 - r1.58) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/pg_regress.c?r1=1.57r2=1.58) Surely this patch is wrong. It is suppressing, not fixing,

Re: [COMMITTERS] pgsql: Silence compiler warning on win32.

2009-01-27 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: Tom Lane wrote: Surely this patch is wrong. It is suppressing, not fixing, a critical warning about a datatype mismatch. You mean the signed vs unsigned part? Other than that, int and dword are always the same on win32... Hmm, need more caffeine

[COMMITTERS] pgsql: Silence compiler warning about ignored return value.

2008-11-20 Thread Magnus Hagander
Log Message: --- Silence compiler warning about ignored return value. Our comment already clearly stated that we are aware that we're ignoring it. Modified Files: -- pgsql/src/test/regress: pg_regress.c (r1.49 - r1.50)

[COMMITTERS] pgsql: Silence compiler warning on mingw

2007-07-24 Thread Magnus Hagander
Log Message: --- Silence compiler warning on mingw Modified Files: -- pgsql/src/backend/libpq: pqcomm.c (r1.194 - r1.195) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/libpq/pqcomm.c.diff?r1=1.194r2=1.195) ---(end

[COMMITTERS] pgsql: Silence compiler warning about signed vs unsigned chars.

2006-09-05 Thread Tom Lane
Log Message: --- Silence compiler warning about signed vs unsigned chars. Modified Files: -- pgsql/contrib/sslinfo: sslinfo.c (r1.1 - r1.2) (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/sslinfo/sslinfo.c.diff?r1=1.1r2=1.2)