Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2017-10-06 Thread Dave Page
On Fri, Oct 6, 2017 at 5:07 AM, Tom Lane wrote: > Dave Page writes: > > On Mon, Oct 24, 2016 at 4:21 PM, Andrew Dunstan > wrote: > >> On 10/24/2016 08:56 AM, Tom Lane wrote: > >>> I'd prefer the solution of disabling --with-openssl. If you just nuke > >>> those members, we never will find out

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2017-10-05 Thread Tom Lane
Dave Page writes: > On Mon, Oct 24, 2016 at 4:21 PM, Andrew Dunstan wrote: >> On 10/24/2016 08:56 AM, Tom Lane wrote: >>> I'd prefer the solution of disabling --with-openssl. If you just nuke >>> those members, we never will find out whether the recent postgres_fdw >>> changes pass on them. Bes

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-26 Thread Dave Page
On Tue, Oct 25, 2016 at 10:22 PM, Andrew Dunstan wrote: > > > On 10/25/2016 10:26 AM, Dave Page wrote: >> >> >> OK, I think I got the perl stuff right - running test builds now. >> > > > Ping me if you need help. Thanks - looks like I got it though, they're all green again :-) -- Dave Page Post

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-25 Thread Andrew Dunstan
On 10/25/2016 10:26 AM, Dave Page wrote: OK, I think I got the perl stuff right - running test builds now. Ping me if you need help. cheers andrew -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-25 Thread Dave Page
On Mon, Oct 24, 2016 at 4:21 PM, Andrew Dunstan wrote: > > > On 10/24/2016 08:56 AM, Tom Lane wrote: >> >> Dave Page writes: >>> >>> On Mon, Oct 24, 2016 at 12:30 PM, Heikki Linnakangas >>> wrote: I'm ok with removing them from the buildfarm, if you feel that way. >>> >>> Andrew, Tom -

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-24 Thread Andrew Dunstan
On 10/24/2016 08:56 AM, Tom Lane wrote: Dave Page writes: On Mon, Oct 24, 2016 at 12:30 PM, Heikki Linnakangas wrote: I'm ok with removing them from the buildfarm, if you feel that way. Andrew, Tom - any thoughts on removing them (just from head and future branches)? I'd prefer the soluti

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-24 Thread Tom Lane
Dave Page writes: > On Mon, Oct 24, 2016 at 12:30 PM, Heikki Linnakangas wrote: >> I'm ok with removing them from the buildfarm, if you feel that way. > Andrew, Tom - any thoughts on removing them (just from head and future > branches)? I'd prefer the solution of disabling --with-openssl. If y

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-24 Thread Dave Page
On Mon, Oct 24, 2016 at 12:30 PM, Heikki Linnakangas wrote: > > > On 24 October 2016 12:33:49 EEST, Dave Page wrote: >>Hi >> >>On Sun, Oct 23, 2016 at 8:22 PM, Heikki Linnakangas >>wrote: >>> Any chance you could update the OpenSSL versions on those systems, or >>> failing that, remove --with-op

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-24 Thread Heikki Linnakangas
On 24 October 2016 12:33:49 EEST, Dave Page wrote: >Hi > >On Sun, Oct 23, 2016 at 8:22 PM, Heikki Linnakangas >wrote: >> Any chance you could update the OpenSSL versions on those systems, or >> failing that, remove --with-openssl? > >Well I could. But really, how useful is that given that it's

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-24 Thread Dave Page
Hi On Sun, Oct 23, 2016 at 8:22 PM, Heikki Linnakangas wrote: > On 10/22/2016 07:11 PM, Tom Lane wrote: >> >> I wrote: >>> >>> The only other Windows machines in the buildfarm that are building >>> with openssl are Andrew's bowerbird and frogmouth; they're both passing. >>> I wonder what openssl

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-23 Thread Heikki Linnakangas
On 10/22/2016 07:11 PM, Tom Lane wrote: I wrote: The only other Windows machines in the buildfarm that are building with openssl are Andrew's bowerbird and frogmouth; they're both passing. I wonder what openssl version is on those. What's the plan for getting the buildfarm back to green in the

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-22 Thread Andrew Dunstan
On 10/22/2016 12:11 PM, Tom Lane wrote: I wrote: The only other Windows machines in the buildfarm that are building with openssl are Andrew's bowerbird and frogmouth; they're both passing. I wonder what openssl version is on those. What's the plan for getting the buildfarm back to green in th

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-22 Thread Tom Lane
I wrote: > The only other Windows machines in the buildfarm that are building > with openssl are Andrew's bowerbird and frogmouth; they're both passing. > I wonder what openssl version is on those. What's the plan for getting the buildfarm back to green in the wake of this patch? If there isn't o

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-18 Thread Tom Lane
Dave Page writes: > On Tue, Oct 18, 2016 at 9:10 AM, Heikki Linnakangas wrote: >> Dave, what version of OpenSSL are 'narwhal' and 'baiji' using? I've tried to >> reproduce this on my laptop, by compiling different versions of OpenSSL, >> between 0.9.8beta1 and 0.9.8 head, but without success.. >

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-18 Thread Dave Page
On Tue, Oct 18, 2016 at 2:34 PM, Heikki Linnakangas wrote: > On 10/18/2016 04:32 PM, Dave Page wrote: >> >> On Tue, Oct 18, 2016 at 1:41 PM, Tom Lane wrote: >>> >>> Dave Page writes: On Tue, Oct 18, 2016 at 12:18 PM, Heikki Linnakangas wrote: > > On 18 October 2016 12:52:

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-18 Thread Tom Lane
Dave Page writes: > On Tue, Oct 18, 2016 at 1:41 PM, Tom Lane wrote: >> Is it possible that there's a header-vs-executable version mismatch >> contributing to the problem here? (Although you'd think we'd have >> hit it before now, if so.) > We're not actually calling the openssl binary are we?

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-18 Thread Heikki Linnakangas
On 10/18/2016 04:32 PM, Dave Page wrote: On Tue, Oct 18, 2016 at 1:41 PM, Tom Lane wrote: Dave Page writes: On Tue, Oct 18, 2016 at 12:18 PM, Heikki Linnakangas wrote: On 18 October 2016 12:52:14 EEST, Dave Page wrote: Baiji: 0.9.8e Narwhal: 0.9.6b Hang on, I removed support for OpenSS

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-18 Thread Dave Page
On Tue, Oct 18, 2016 at 1:41 PM, Tom Lane wrote: > Dave Page writes: >> On Tue, Oct 18, 2016 at 12:18 PM, Heikki Linnakangas wrote: >>> On 18 October 2016 12:52:14 EEST, Dave Page wrote: Baiji: 0.9.8e Narwhal: 0.9.6b > >>> Hang on, I removed support for OpenSSL < 0.9.8 a while ago. Na

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-18 Thread Tom Lane
Dave Page writes: > On Tue, Oct 18, 2016 at 12:18 PM, Heikki Linnakangas wrote: >> On 18 October 2016 12:52:14 EEST, Dave Page wrote: >>> Baiji: 0.9.8e >>> Narwhal: 0.9.6b >> Hang on, I removed support for OpenSSL < 0.9.8 a while ago. Narwhal >> shouldn't even compile with 0.9.6. > Oops, sorr

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-18 Thread Dave Page
On Tue, Oct 18, 2016 at 12:18 PM, Heikki Linnakangas wrote: > > > On 18 October 2016 12:52:14 EEST, Dave Page wrote: >>On Tue, Oct 18, 2016 at 9:10 AM, Heikki Linnakangas >>wrote: >>> On 10/18/2016 12:28 AM, Tom Lane wrote: Heikki Linnakangas writes: > > Use OpenSSL EVP API fo

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-18 Thread Heikki Linnakangas
On 18 October 2016 12:52:14 EEST, Dave Page wrote: >On Tue, Oct 18, 2016 at 9:10 AM, Heikki Linnakangas >wrote: >> On 10/18/2016 12:28 AM, Tom Lane wrote: >>> >>> Heikki Linnakangas writes: Use OpenSSL EVP API for symmetric encryption in pgcrypto. >>> >>> >>> BTW, "narwhal" seems to

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-18 Thread Dave Page
On Tue, Oct 18, 2016 at 9:10 AM, Heikki Linnakangas wrote: > On 10/18/2016 12:28 AM, Tom Lane wrote: >> >> Heikki Linnakangas writes: >>> >>> Use OpenSSL EVP API for symmetric encryption in pgcrypto. >> >> >> BTW, "narwhal" seems to have a problem with this. >> Not very clear what, maybe an incom

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-18 Thread Heikki Linnakangas
On 10/18/2016 12:28 AM, Tom Lane wrote: Heikki Linnakangas writes: Use OpenSSL EVP API for symmetric encryption in pgcrypto. BTW, "narwhal" seems to have a problem with this. Not very clear what, maybe an incompatibility with old openssl versions? Dave, what version of OpenSSL are 'narwhal'

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-17 Thread Michael Paquier
On Tue, Oct 18, 2016 at 6:28 AM, Tom Lane wrote: > Heikki Linnakangas writes: >> Use OpenSSL EVP API for symmetric encryption in pgcrypto. > > BTW, "narwhal" seems to have a problem with this. > Not very clear what, maybe an incompatibility with old openssl versions? Details are here: http://bui

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-17 Thread Tom Lane
Heikki Linnakangas writes: > Use OpenSSL EVP API for symmetric encryption in pgcrypto. BTW, "narwhal" seems to have a problem with this. Not very clear what, maybe an incompatibility with old openssl versions? regards, tom lane -- Sent via pgsql-committers mailing list

[COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-17 Thread Heikki Linnakangas
Use OpenSSL EVP API for symmetric encryption in pgcrypto. The old "low-level" API is deprecated, and doesn't support hardware acceleration. And this makes the code simpler, too. Discussion: <561274f1.1030...@iki.fi> Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5f