Re: [COMMITTERS] pgsql: Use quicksort, not replacement selection, for external sorting.

2016-04-08 Thread Robert Haas
On Fri, Apr 8, 2016 at 10:47 AM, Tom Lane wrote: > I wrote: >> Robert Haas writes: >>> Use quicksort, not replacement selection, for external sorting. > >> This patch evidently broke several of the Windows buildfarm critters, > > On inspection, the problem is obviously "declaration in the middle

Re: [COMMITTERS] pgsql: Use quicksort, not replacement selection, for external sorting.

2016-04-08 Thread Tom Lane
I wrote: > Robert Haas writes: >> Use quicksort, not replacement selection, for external sorting. > This patch evidently broke several of the Windows buildfarm critters, On inspection, the problem is obviously "declaration in the middle of a code block". regards, tom lan

Re: [COMMITTERS] pgsql: Use quicksort, not replacement selection, for external sorting.

2016-04-08 Thread Tom Lane
Robert Haas writes: > Use quicksort, not replacement selection, for external sorting. This patch evidently broke several of the Windows buildfarm critters, eg on mastodon: Build FAILED. .\src\backend\utils\sort\tuplesort.c(2373): error C2143: syntax error : missing ';' before 'type' .\src\backe

[COMMITTERS] pgsql: Use quicksort, not replacement selection, for external sorting.

2016-04-07 Thread Robert Haas
Use quicksort, not replacement selection, for external sorting. We still use replacement selection for the first run of the sort only and only when the number of tuples is relatively small. Otherwise, the first run, and subsequent runs in all cases, are produced using quicksort. This tends to be