Re: [COMMITTERS] pgsql: dblink: Replace some macros by static functions

2017-04-05 Thread Peter Eisentraut
On 3/13/17 15:58, Tom Lane wrote: > In the same vein, I think this bit in dblink_open is pretty poor coding > practice: > > if (!rconn || !rconn->conn) > dblink_conn_not_avail(conname); > else > conn = rconn->conn; > > as it expects both the compiler and th

Re: [COMMITTERS] pgsql: dblink: Replace some macros by static functions

2017-03-13 Thread Tom Lane
Peter Eisentraut writes: > On 3/12/17 17:44, David Rowley wrote: >> Please accept a small patch which fixes a new compiler warning which >> started as a result of this commit. > Done. > Which compiler is that? Any compiler that didn't support pg_attribute_noreturn() could be expected to whine a

Re: [COMMITTERS] pgsql: dblink: Replace some macros by static functions

2017-03-13 Thread Peter Eisentraut
On 3/12/17 17:44, David Rowley wrote: > Please accept a small patch which fixes a new compiler warning which > started as a result of this commit. Done. Which compiler is that? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Traini

Re: [COMMITTERS] pgsql: dblink: Replace some macros by static functions

2017-03-12 Thread David Rowley
On 11 March 2017 at 03:46, Peter Eisentraut wrote: > dblink: Replace some macros by static functions > > Also remove some unused code and the no longer useful dblink.h file. > > Reviewed-by: Tsunakawa, Takayuki > > Branch > -- > master > > Details > --- > http://git.postgresql.org/pg/com

[COMMITTERS] pgsql: dblink: Replace some macros by static functions

2017-03-10 Thread Peter Eisentraut
dblink: Replace some macros by static functions Also remove some unused code and the no longer useful dblink.h file. Reviewed-by: Tsunakawa, Takayuki Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/acaf7ccb94a3916ea83712671a3563f0eb595558 Modified Files --