Re: [HACKERS] [COMMITTERS] pgsql: Add support for TCP keepalives on Windows, both for backend and

2010-07-08 Thread Tom Lane
Magnus Hagander writes: > On Thu, Jul 8, 2010 at 18:37, Tom Lane wrote: >> This is still going to need manual adjustment in the future, > And it's far from certain they'll actually add it to mstcpip.h - > sometimes they stick it in a different header... Yeah, that's the other reason for waiting

Re: [HACKERS] [COMMITTERS] pgsql: Add support for TCP keepalives on Windows, both for backend and

2010-07-08 Thread Magnus Hagander
On Thu, Jul 8, 2010 at 18:37, Tom Lane wrote: > Magnus Hagander writes: >> Here's what I came up with and will apply as soon as my msvc build >> completes. (the mingw one works with this) > > This is still going to need manual adjustment in the future, since > probably when mingw adds the #define

Re: [HACKERS] [COMMITTERS] pgsql: Add support for TCP keepalives on Windows, both for backend and

2010-07-08 Thread Tom Lane
Magnus Hagander writes: > Here's what I came up with and will apply as soon as my msvc build > completes. (the mingw one works with this) This is still going to need manual adjustment in the future, since probably when mingw adds the #define, they will put it in , and this code will not see it.

Re: [HACKERS] [COMMITTERS] pgsql: Add support for TCP keepalives on Windows, both for backend and

2010-07-08 Thread Magnus Hagander
On Thu, Jul 8, 2010 at 18:06, Magnus Hagander wrote: > On Thu, Jul 8, 2010 at 17:45, Andrew Dunstan wrote: >> >> >> Tom Lane wrote: >>> >>> Magnus Hagander writes: >>> Seems pretty simple - mingw doesn't have support for this. We have two ways to deal with that I think: 1) Di

Re: [HACKERS] [COMMITTERS] pgsql: Add support for TCP keepalives on Windows, both for backend and

2010-07-08 Thread Magnus Hagander
On Thu, Jul 8, 2010 at 17:45, Andrew Dunstan wrote: > > > Tom Lane wrote: >> >> Magnus Hagander writes: >> >>> >>> Seems pretty simple - mingw doesn't have support for this. We have two >>> ways to deal with that I think: >>> 1) Disable it on mingw. >>> 2) Include it in our custom headers. >>> >>

Re: [HACKERS] [COMMITTERS] pgsql: Add support for TCP keepalives on Windows, both for backend and

2010-07-08 Thread Andrew Dunstan
Tom Lane wrote: Magnus Hagander writes: Seems pretty simple - mingw doesn't have support for this. We have two ways to deal with that I think: 1) Disable it on mingw. 2) Include it in our custom headers. For #2, what we need to include is the define of SIO_KEEPALIVE_VALS as well