Re: [COMMITTERS] pgsql: Check dup2() results in syslogger

2014-01-28 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> In short, this patch was ill considered. Please revert. If we need > >> to silence a Coverity complaint, perhaps a cast-to-void will do? > > > Sure, I'll adjust it accordingly. > > Fe

Re: [COMMITTERS] pgsql: Check dup2() results in syslogger

2014-01-27 Thread Tom Lane
Stephen Frost writes: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> In short, this patch was ill considered. Please revert. If we need >> to silence a Coverity complaint, perhaps a cast-to-void will do? > Sure, I'll adjust it accordingly. Feel free to improve the comment if you think it could be

Re: [COMMITTERS] pgsql: Check dup2() results in syslogger

2014-01-27 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > You shouldn't really raise that argument against the guy who made the > original commit in question ;-). Figures. :) Not sure how I missed that. [...] Right, I had followed that. > Now ideally, the way we do that is to reconnect its stderr to /dev/null,

Re: [COMMITTERS] pgsql: Check dup2() results in syslogger

2014-01-27 Thread Tom Lane
Stephen Frost writes: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> Please note also that the comment just above >> this implies that we are deliberately ignoring any failures here, so I >> think FATAL was probably the wrong thing in any case. > We were explicitly ignoring the errors from the close

Re: [COMMITTERS] pgsql: Check dup2() results in syslogger

2014-01-27 Thread Heikki Linnakangas
On 01/27/2014 05:32 PM, Stephen Frost wrote: * Tom Lane (t...@sss.pgh.pa.us) wrote: Stephen Frost writes: Check dup2() results in syslogger Consistently check the dup2() call results throughout syslogger.c. It's pretty unlikely that they'll error out, but if they do, ereport(FATAL) instead of

Re: [COMMITTERS] pgsql: Check dup2() results in syslogger

2014-01-27 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > Check dup2() results in syslogger > > Consistently check the dup2() call results throughout syslogger.c. > > It's pretty unlikely that they'll error out, but if they do, > > ereport(FATAL) instead of blissfully continuing on. > >

Re: [COMMITTERS] pgsql: Check dup2() results in syslogger

2014-01-27 Thread Tom Lane
Stephen Frost writes: > Check dup2() results in syslogger > Consistently check the dup2() call results throughout syslogger.c. > It's pretty unlikely that they'll error out, but if they do, > ereport(FATAL) instead of blissfully continuing on. Meh. Have you actually tested that an ereport(FATAL)