[COMMITTERS] pgsql: expandRTE and get_rte_attribute_type mistakenly always imputed

2005-05-29 Thread Tom Lane
Log Message: --- expandRTE and get_rte_attribute_type mistakenly always imputed typmod -1 to columns of an RTE that was a function returning RECORD with a column definition list. Apparently no one has tried to use non-default typmod with a function returning RECORD before. Modified Files:

[COMMITTERS] pgsql: expandRTE and get_rte_attribute_type mistakenly always imputed

2005-05-29 Thread Tom Lane
Log Message: --- expandRTE and get_rte_attribute_type mistakenly always imputed typmod -1 to columns of an RTE that was a function returning RECORD with a column definition list. Apparently no one has tried to use non-default typmod with a function returning RECORD before. Tags: REL7

[COMMITTERS] pgsql: expandRTE and get_rte_attribute_type mistakenly always imputed

2005-05-29 Thread Tom Lane
Log Message: --- expandRTE and get_rte_attribute_type mistakenly always imputed typmod -1 to columns of an RTE that was a function returning RECORD with a column definition list. Apparently no one has tried to use non-default typmod with a function returning RECORD before. Tags: REL7

[COMMITTERS] pgsql: expandRTE and get_rte_attribute_type mistakenly always imputed

2005-05-29 Thread Tom Lane
Log Message: --- expandRTE and get_rte_attribute_type mistakenly always imputed typmod -1 to columns of an RTE that was a function returning RECORD with a column definition list. Apparently no one has tried to use non-default typmod with a function returning RECORD before. Tags: REL8

[COMMITTERS] pgsql: Avoid unnecessary call of rangeTableEntry_used() for the result

2005-05-29 Thread Tom Lane
Log Message: --- Avoid unnecessary call of rangeTableEntry_used() for the result relation of a query. Modified Files: -- pgsql/src/backend/rewrite: rewriteHandler.c (r1.151 -> r1.152) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/rewrite/rew

[COMMITTERS] pgsql: Remove typeidIsValid() checks in can_coerce_type().

2005-05-29 Thread Tom Lane
Log Message: --- Remove typeidIsValid() checks in can_coerce_type(). These checks were pretty expensive and I believe the case they were put in to defend against can no longer arise, now that we have dependency checks to prevent deletion of a type entry that is still referenced. Certainly

[COMMITTERS] pgsql: Marginal hack to save a little bit of time in bpcharin() when

2005-05-29 Thread Tom Lane
Log Message: --- Marginal hack to save a little bit of time in bpcharin() when typmod is -1, which is a common case. Modified Files: -- pgsql/src/backend/utils/adt: varchar.c (r1.109 -> r1.110) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/u

[COMMITTERS] pgsql: Make superuser.c maintain a simple one-entry cache holding the

2005-05-29 Thread Tom Lane
Log Message: --- Make superuser.c maintain a simple one-entry cache holding the superuser status of the most recently queried userid. Since the common pattern is many successive queries about the same user (ie, the current user) this can save a lot of syscache probes. Modified Files:

[COMMITTERS] pgswish - pgswish: logging to file in /tmp/ (not really best solution),

2005-05-29 Thread User Dpavlin
Log Message: --- logging to file in /tmp/ (not really best solution), removed pgswish2 Modified Files: -- pgswish: test.sql (r1.8 -> r1.9) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgswish/pgswish/test.sql.diff?r1=1.8&r2=1.9) pgswish.c (r1.11 ->

[COMMITTERS] pgswish - pgswish: subversion revision 21 commited to CVS

2005-05-29 Thread User Dpavlin
Log Message: --- subversion revision 21 commited to CVS Modified Files: -- pgswish: .svnrev (r1.21 -> r1.22) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgswish/pgswish/.svnrev.diff?r1=1.21&r2=1.22) ---(end of broadcast)---

[COMMITTERS] pgswish - pgswish: target to update pgFoundry using svn2cvs.pl

2005-05-29 Thread User Dpavlin
Log Message: --- target to update pgFoundry using svn2cvs.pl Modified Files: -- pgswish: Makefile (r1.8 -> r1.9) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgswish/pgswish/Makefile.diff?r1=1.8&r2=1.9) ---(end of broadcast)

[COMMITTERS] pgswish - pgswish: subversion revision 20 commited to CVS

2005-05-29 Thread User Dpavlin
Log Message: --- subversion revision 20 commited to CVS Modified Files: -- pgswish: .svnrev (r1.20 -> r1.21) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgswish/pgswish/.svnrev.diff?r1=1.20&r2=1.21) ---(end of broadcast)---

[COMMITTERS] pgswish - pgswish: subversion revision 22 commited to CVS

2005-05-29 Thread User Dpavlin
Log Message: --- subversion revision 22 commited to CVS Modified Files: -- pgswish: .svnrev (r1.22 -> r1.23) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgswish/pgswish/.svnrev.diff?r1=1.22&r2=1.23) ---(end of broadcast)---

[COMMITTERS] pgswish - pgswish: Added pgswish_arr function using SFRM_Materialize

2005-05-29 Thread User Dpavlin
Log Message: --- Added pgswish_arr function using SFRM_Materialize mode. Integer properties doesn't work yet. Modified Files: -- pgswish: test.sql (r1.9 -> r1.10) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgswish/pgswish/test.sql.diff?r1=1.9&r2=1.10)

[COMMITTERS] pgsql: Improve LockAcquire API per my recent proposal.

2005-05-29 Thread Tom Lane
Log Message: --- Improve LockAcquire API per my recent proposal. All error conditions are now reported via elog, eliminating the need to test the result code at most call sites. Make it possible for the caller to distinguish a freshly acquired lock from one already held in the current tra

[COMMITTERS] pgswish - pgswish: subversion revision 23 commited to CVS

2005-05-29 Thread User Dpavlin
Log Message: --- subversion revision 23 commited to CVS Modified Files: -- pgswish: .svnrev (r1.23 -> r1.24) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgswish/pgswish/.svnrev.diff?r1=1.23&r2=1.24) ---(end of broadcast)---

[COMMITTERS] pgswish - pgswish: make it less chatty at INFO logging level

2005-05-29 Thread User Dpavlin
Log Message: --- make it less chatty at INFO logging level Modified Files: -- pgswish: pgswish.c (r1.13 -> r1.14) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgswish/pgswish/pgswish.c.diff?r1=1.13&r2=1.14) ---(end of broadcast)

[COMMITTERS] pgsql: Avoid unnecessary fetch from pg_shadow in the normal case in

2005-05-29 Thread Tom Lane
Log Message: --- Avoid unnecessary fetch from pg_shadow in the normal case in pg_class_aclmask(). We only need to do this when we have to check pg_shadow.usecatupd, and that's not relevant unless the target table is a system catalog. So we can usually avoid one syscache lookup. Modified

[COMMITTERS] pgsql: Skip eval_const_expressions when the query is such that the

2005-05-29 Thread Tom Lane
Log Message: --- Skip eval_const_expressions when the query is such that the expression would be evaluated only once anyway (ie, it's just a SELECT with no FROM or an INSERT ... VALUES). The planner can't do it any faster than the executor, so no point in an extra copying of the expression

[COMMITTERS] pgsql: Change the UNKNOWN type to have an internal representation

2005-05-29 Thread Tom Lane
Log Message: --- Change the UNKNOWN type to have an internal representation matching cstring, rather than text, so as to eliminate useless conversions inside the parser. Per recent discussion. Modified Files: -- pgsql/src/backend/parser: parse_coerce.c (r2.129 -> r

[COMMITTERS] pgsql: Fix longstanding oversight in ruleutils.c: it doesn't regurgitate

2005-05-29 Thread Tom Lane
Log Message: --- Fix longstanding oversight in ruleutils.c: it doesn't regurgitate a FOR UPDATE clause, if one is present. Modified Files: -- pgsql/src/backend/utils/adt: ruleutils.c (r1.196 -> r1.197) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/b

[COMMITTERS] pgsql: Create separate ON INSERT and ON UPDATE triggers on tables with

2005-05-29 Thread Neil Conway
Log Message: --- Create separate ON INSERT and ON UPDATE triggers on tables with foreign keys, rather than a single trigger for both events. This should not change functionality, but it is more consistent: previously, there were trigger functions for both "check_insert" and "check_update",