[COMMITTERS] pgsql: Applied Zoltan's patch to remove hardware dependant offset

Log Message: --- Applied Zoltan's patch to remove hardware dependant offset logging and superfluous include files. Modified Files: -- pgsql/src/interfaces/ecpg/ecpglib: sqlda.c (r1.1 -> r1.2) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ec

Re: [COMMITTERS] pgsql: And another one

On Tue, Jan 05, 2010 at 06:20:07PM +0100, Magnus Hagander wrote: > This kind of commit message is pretty much useless. If you want to do > a git blame/cvs annotate/whatever later, it gives exactly zero > information. No, I didn't want to blame anything. I was just trying to fix this before leaving

Re: [COMMITTERS] pgsql: pg_dump --only-analyze Implement pg_dump --only-analyze for use

On Wed, 2010-01-06 at 02:59 +, Bruce Momjian wrote: > Log Message: > --- > pg_dump --only-analyze > > Implement pg_dump --only-analyze for use by pg_migrator to only analyze > all databases. You mean vacuumdb, don't you? pg_dump wasn't touched -- Simon Riggs www.2ndQuadra

[COMMITTERS] plproxy - plproxy: Adjustments for PostgreSQL 8.5

Log Message: --- Adjustments for PostgreSQL 8.5 Modified Files: -- plproxy: Makefile (r1.41 -> r1.42) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/plproxy/plproxy/Makefile?r1=1.41&r2=1.42) plproxy/expected: plproxy_test.out (r1.8 -> r1.9)

Re: [COMMITTERS] pgsql: And another one

On Wed, Jan 6, 2010 at 10:48, Michael Meskes wrote: > On Tue, Jan 05, 2010 at 06:20:07PM +0100, Magnus Hagander wrote: >> This kind of commit message is pretty much useless. If you want to do >> a git blame/cvs annotate/whatever later, it gives exactly zero >> information. > > No, I didn't want to

[COMMITTERS] pgsql: Silence compiler warning about uninitialized variables.

Log Message: --- Silence compiler warning about uninitialized variables. This initialization is not necessary needed, but some compilers complain about it. Modified Files: -- pgsql/src/backend/commands: cluster.c (r1.191 -> r1.192) (http://anoncvs.postgresq

[COMMITTERS] pgsql: Removed more inttypes.h stuff.

Log Message: --- Removed more inttypes.h stuff. Modified Files: -- pgsql/src/interfaces/ecpg/test/compat_informix: sqlda.pgc (r1.1 -> r1.2) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/test/compat_informix/sqlda.pgc?r1=1.1&r2=1.2)

[COMMITTERS] pgsql: Removed test case using nan as float value because printf's

Log Message: --- Removed test case using nan as float value because printf's output for nan is OS specific with some distinguishing between signaling and quiet nans. It's not really importnat for us here anyway. Modified Files: -- pgsql/src/interfaces/ecpg/test/compat_infor

Re: [COMMITTERS] pgsql: Applied Zoltan's patch to remove hardware dependant offset

This patch still leaves in some uses of __FUNCTION__ which is breaking non-gcc compilers: see for example elog.h defines PG_FUNCNAME_MACRO which you should use instead. cheers andrew Michael Meskes wro

Re: [COMMITTERS] pgsql: Applied Zoltan's patch to remove hardware dependant offset

We are also breaking Windows by using int64_t. See You could possibly use int64, which is defined in c.h. cheers andrew Michael Meskes wrote: Log Message: --- Applied Zoltan's patch to remove hardw

[COMMITTERS] pg-migrator - pg_migrator: Support new backend API to preserve

Log Message: --- Support new backend API to preserve relfilenodes, avoiding complex toast renaming for 8.5. Modified Files: -- pg_migrator: INSTALL.jp (r1.5 -> r1.6) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pg-migrator/pg_migrator/INSTALL.jp?r1=1.5&r2=1

[COMMITTERS] pgsql: Remove __FUNCTION__ keyword that is not recognized by som

Log Message: --- Remove __FUNCTION__ keyword that is not recognized by som compilers. Modified Files: -- pgsql/src/interfaces/ecpg/ecpglib: sqlda.c (r1.2 -> r1.3) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/ecpglib/sqlda.c?r1=1.2&r2=

Re: [COMMITTERS] pgsql: Remove __FUNCTION__ keyword that is not recognized by som

Michael Meskes wrote: > Log Message: > --- > Remove __FUNCTION__ keyword that is not recognized by som compilers. You can use PG_FUNCNAME_MACRO instead -- that's portable (and in fact we use it in elog). -- Alvaro Herrerahttp://www.CommandPrompt.com/ The P

[COMMITTERS] pgsql: Replaced int64_t with int64 as Andrew suggested.

Log Message: --- Replaced int64_t with int64 as Andrew suggested. Modified Files: -- pgsql/src/interfaces/ecpg/ecpglib: sqlda.c (r1.3 -> r1.4) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/ecpglib/sqlda.c?r1=1.3&r2=1.4) -- Sent via p

[COMMITTERS] pg-migrator - pg_migrator: Add missing file to CVs.

Log Message: --- Add missing file to CVs. Added Files: --- pg_migrator/func: pg_migrator_toast.c (r1.1) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pg-migrator/pg_migrator/func/pg_migrator_toast.c?rev=1.1&content-type=text/x-cvsweb-markup) -- Sent via pgsql-

[COMMITTERS] pgsql: Corrected CVS entry: --only-analyze mode is for _vacuumdb_, not

Log Message: --- Corrected CVS entry: --only-analyze mode is for _vacuumdb_, not pg_dump. Modified Files: -- pgsql/src/bin/scripts: vacuumdb.c (r1.30 -> r1.31) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/scripts/vacuumdb.c?r1=1.30&r2=1.31) --

Re: [COMMITTERS] pgsql: pg_dump --only-analyze Implement pg_dump --only-analyze for use

Simon Riggs wrote: > On Wed, 2010-01-06 at 02:59 +, Bruce Momjian wrote: > > Log Message: > > --- > > pg_dump --only-analyze > > > > Implement pg_dump --only-analyze for use by pg_migrator to only analyze > > all databases. > > You mean vacuumdb, don't you? pg_dump wasn't touched Doh

[COMMITTERS] pgsql: Add missing 'static' keywords.

Log Message: --- Add missing 'static' keywords. Modified Files: -- pgsql/contrib/auto_explain: auto_explain.c (r1.11 -> r1.12) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/auto_explain/auto_explain.c?r1=1.11&r2=1.12) -- Sent via pgsql-committer

[COMMITTERS] pgsql: Fix missing markers in dblink reference entries.

Log Message: --- Fix missing markers in dblink reference entries. Silences complaints from "make man", and allows these man pages to be included in man3/. Modified Files: -- pgsql/doc/src/sgml: Makefile (r1.134 -> r1.135) (http://anoncvs.postgresql.org/cvs

[COMMITTERS] pg-migrator - pg_migrator: Skip rebuilding of relation array when we

Log Message: --- Skip rebuilding of relation array when we have not done any toast renaming. Modified Files: -- pg_migrator/src: pg_migrator.c (r1.86 -> r1.87) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pg-migrator/pg_migrator/src/pg_migrator.c?r1=1.86&r2

[COMMITTERS] pgsql: Make the makefile pass $MAJORVERSION to genbki.pl, not $VERSION

Log Message: --- Make the makefile pass $MAJORVERSION to genbki.pl, not $VERSION which is overridden in the snapshot build script. $MAJORVERSION is what it really wanted anyway, so we can tighten up the parsing of --set-version's argument. Modified Files: -- pgsql/src/back

[COMMITTERS] pgsql: Make error messages for bad --set-version argument more useful.

Log Message: --- Make error messages for bad --set-version argument more useful. Per Stefan. Modified Files: -- pgsql/src/backend/catalog: genbki.pl (r1.5 -> r1.6) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/catalog/genbki.pl?r1=1.5&r2=1.6)

[COMMITTERS] pgsql: Access hash entry before freeing it, not after.

Log Message: --- Access hash entry before freeing it, not after. Modified Files: -- pgsql/src/backend/utils/cache: spccache.c (r1.1 -> r1.2) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/cache/spccache.c?r1=1.1&r2=1.2) -- Sent via pgsq

[COMMITTERS] pgsql: Fix spccache.c to not suppose that a cache entry will live across

Log Message: --- Fix spccache.c to not suppose that a cache entry will live across database access, per testing with CLOBBER_CACHE_ALWAYS. Minor other editorialization. Modified Files: -- pgsql/src/backend/utils/cache: spccache.c (r1.2 -> r1.3) (http://ano

[COMMITTERS] pgsql: PG_MAJORVERSION: For simplicity, use PG_MAJORVERSION rather than

Log Message: --- PG_MAJORVERSION: For simplicity, use PG_MAJORVERSION rather than PG_VERSION for creation of the PG_VERSION file. Modified Files: -- pgsql/src/backend/commands: tablespace.c (r1.67 -> r1.68) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/s

Re: [COMMITTERS] pgsql: PG_MAJORVERSION: For simplicity, use PG_MAJORVERSION rather than

Bruce Momjian wrote: > Log Message: > --- > PG_MAJORVERSION: > > For simplicity, use PG_MAJORVERSION rather than PG_VERSION for creation > of the PG_VERSION file. I think this is a bad style to use for commit messages. For GIT, a good commit message is a first line being a summary, and a

Re: [COMMITTERS] pgsql: PG_MAJORVERSION: For simplicity, use PG_MAJORVERSION rather than

Alvaro Herrera wrote: > Bruce Momjian wrote: > > Log Message: > > --- > > PG_MAJORVERSION: > > > > For simplicity, use PG_MAJORVERSION rather than PG_VERSION for creation > > of the PG_VERSION file. > > I think this is a bad style to use for commit messages. For GIT, a good > commit mess

[COMMITTERS] pgsql: Alter the configure script to fail immediately if the C compiler

Log Message: --- Alter the configure script to fail immediately if the C compiler does not provide a working 64-bit integer datatype. As recently noted, we've been broken on such platforms since early in the 8.4 development cycle. Since it took nearly two years for anyone to even notice,

[COMMITTERS] pgsql: Alter the configure script to fail immediately if the C compiler

Log Message: --- Alter the configure script to fail immediately if the C compiler does not provide a working 64-bit integer datatype. As recently noted, we've been broken on such platforms since early in the 8.4 development cycle. Since it took nearly two years for anyone to even notice,

[COMMITTERS] pgsql: Make configure check the version of Perl we're building with, and

Log Message: --- Make configure check the version of Perl we're building with, and reject versions < 5.8. Also, if there's no Perl, emit a warning informing the user that he won't be able to build from a CVS pull. This is exactly the same treatment we give Bison and Perl, and for the same

[COMMITTERS] pgsql: Improve a couple of comments relating to large object snapshot

Log Message: --- Improve a couple of comments relating to large object snapshot management. Modified Files: -- pgsql/src/backend/catalog: aclchk.c (r1.160 -> r1.161) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/catalog/aclchk.c?r1=1.160&r2=1.

Re: [COMMITTERS] pgsql: PG_MAJORVERSION: For simplicity, use PG_MAJORVERSION rather than

Bruce Momjian wrote: > Alvaro Herrera wrote: > > I think this is a bad style to use for commit messages. For GIT, a good > > commit message is a first line being a summary, and a more extensive > > message below. > > That is just too odd. I think I forgot about the summary idea then. What is od

[COMMITTERS] pgsql: Fail in a nicer way if we have --with-perl and no Perl.

Log Message: --- Fail in a nicer way if we have --with-perl and no Perl. Modified Files: -- pgsql: configure (r1.667 -> r1.668) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/configure?r1=1.667&r2=1.668) configure.in (r1.619 -> r1.620) (ht

Re: [COMMITTERS] pgsql: PG_MAJORVERSION: For simplicity, use PG_MAJORVERSION rather than

Alvaro Herrera wrote: > Bruce Momjian wrote: > > Alvaro Herrera wrote: > > > > I think this is a bad style to use for commit messages. For GIT, a good > > > commit message is a first line being a summary, and a more extensive > > > message below. > > > > That is just too odd. I think I forgot ab

Re: [COMMITTERS] pgsql: PG_MAJORVERSION: For simplicity, use PG_MAJORVERSION rather than

On Wed, Jan 6, 2010 at 10:41 PM, Bruce Momjian wrote: > Alvaro Herrera wrote: >> Bruce Momjian wrote: >> > Alvaro Herrera wrote: >> >> > > I think this is a bad style to use for commit messages.  For GIT, a good >> > > commit message is a first line being a summary, and a more extensive >> > > mes

[COMMITTERS] pgsql: Further fixes for per-tablespace options patch.

Log Message: --- Further fixes for per-tablespace options patch. Add missing varlena header to TableSpaceOpts structure. And, per Tom Lane, instead of calling tablespace_reloptions in CacheMemoryContext, call it in the caller's memory context and copy the value over afterwards, to reduce

Re: [COMMITTERS] pgsql: PG_MAJORVERSION: For simplicity, use PG_MAJORVERSION rather than

Bruce Momjian wrote: > Well, having the description and then a blank line in the middle just is > too odd for too small a group of viewers. I might as well just type the > commit message as normal and users can see all they can. Think of the first line as a title. -- Alvaro Herrera

[COMMITTERS] pgsql: Clarify tablespace.c::TablespaceCreateDbspace() comments.

Log Message: --- Clarify tablespace.c::TablespaceCreateDbspace() comments. Modified Files: -- pgsql/src/backend/commands: tablespace.c (r1.68 -> r1.69) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/tablespace.c?r1=1.68&r2=1.69) -- S

[COMMITTERS] pgsql: More tablespace.c comment improvements.

Log Message: --- More tablespace.c comment improvements. Modified Files: -- pgsql/src/backend/commands: tablespace.c (r1.69 -> r1.70) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/tablespace.c?r1=1.69&r2=1.70) -- Sent via pgsql-comm

[COMMITTERS] pgsql: Remove all the special-case code for INT64_IS_BUSTED, per

Log Message: --- Remove all the special-case code for INT64_IS_BUSTED, per decision that we're not going to support that anymore. I did keep the 64-bit-CRC-with-32-bit-arithmetic code, since it has a performance excuse to live. It's a bit moot since that's all ifdef'd out, of course. Mod