On Fri, 2010-04-23 at 18:55 -0400, Tom Lane wrote:
> [email protected] (Simon Riggs) writes:
> > Log Message:
> > ---
> > Add missing optimizer hooks for function cost and number of rows.
> > Closely follow design of other optimizer hooks: if hook exists
> > retrieve value from plugin;
On Sat, Apr 24, 2010 at 3:31 AM, Simon Riggs wrote:
> On Fri, 2010-04-23 at 18:55 -0400, Tom Lane wrote:
>> [email protected] (Simon Riggs) writes:
>> > Log Message:
>> > ---
>> > Add missing optimizer hooks for function cost and number of rows.
>> > Closely follow design of other opti
Robert Haas writes:
> On Sat, Apr 24, 2010 at 3:31 AM, Simon Riggs wrote:
>> Existing hooks were not fully complete in their coverage. That has
>> happened before, and we have discussed that before on hackers, so I took
>> care not to deviate from that implementation. This is a very low impact
>>
Log Message:
---
Patch revoked because of objections.
Modified Files:
--
pgsql/src/backend/utils/cache:
lsyscache.c (r1.169 -> r1.170)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/cache/lsyscache.c?r1=1.169&r2=1.170)
pgsql/src/inclu
On Sat, 2010-04-24 at 11:17 -0400, Tom Lane wrote:
> Robert Haas writes:
> > On Sat, Apr 24, 2010 at 3:31 AM, Simon Riggs wrote:
> >> Existing hooks were not fully complete in their coverage. That has
> >> happened before, and we have discussed that before on hackers, so I took
> >> care not to d
Simon Riggs writes:
> We can override table stats but not functions stats. I noticed that hole
> in the previous implementation, and rectified it with the intention of
> helping users with what I saw as a small, low risk patch that exactly
> followed existing code. It would seem I did that too qui
On Sat, 2010-04-24 at 12:59 -0400, Tom Lane wrote:
> Well, you did it without much thought at all.
To the consequences, definitely.
> I think this episode is a
> perfect demonstration of why we ask for concrete use-cases for proposed
> hooks. If you'd actually tried to write something that used
Log Message:
---
Add C comments for recent to_char('L') fix for Win32.
Modified Files:
--
pgsql/src/backend/utils/adt:
pg_locale.c (r1.54 -> r1.55)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/pg_locale.c?r1=1.54&r2=1.55)
--
Sent
