[COMMITTERS] pgsql: Coerce 'unknown' type parameters to the right type in the

2010-08-18 Thread Heikki Linnakangas
Log Message: --- Coerce 'unknown' type parameters to the right type in the fixed-params parse_analyze() function. That case occurs e.g with PL/pgSQL EXECUTE ... USING 'stringconstant'. The coercion with a CoerceViaIO node. The result is similar to the coercion via input function performed

[COMMITTERS] pgsql: Coerce 'unknown' type parameters to the right type in the

2010-08-18 Thread Heikki Linnakangas
Log Message: --- Coerce 'unknown' type parameters to the right type in the fixed-params parse_analyze() function. That case occurs e.g with PL/pgSQL EXECUTE ... USING 'stringconstant'. The coercion with a CoerceViaIO node. The result is similar to the coercion via input function performed

Re: [COMMITTERS] pgsql: Coerce 'unknown' type parameters to the right type in the

2010-08-18 Thread Tom Lane
[email protected] (Heikki Linnakangas) writes: > Log Message: > --- > Coerce 'unknown' type parameters to the right type in the fixed-params > parse_analyze() function. That case occurs e.g with PL/pgSQL > EXECUTE ... USING 'stringconstant'. > The coercion with a CoerceViaIO node. The

Re: [COMMITTERS] pgsql: Coerce 'unknown' type parameters to the right type in the

2010-08-18 Thread Heikki Linnakangas
On 18/08/10 16:57, Tom Lane wrote: [email protected] (Heikki Linnakangas) writes: Log Message: --- Coerce 'unknown' type parameters to the right type in the fixed-params parse_analyze() function. That case occurs e.g with PL/pgSQL EXECUTE ... USING 'stringconstant'. The coercion w

[COMMITTERS] pgsql: Add missing handling of PlannedStmt.transientPlan in

2010-08-18 Thread Tom Lane
Log Message: --- Add missing handling of PlannedStmt.transientPlan in copyfuncs/outfuncs. _outPlannedStmt is only debug support, so the omission there was not very serious, but the omission in _copyPlannedStmt is a real bug. The consequence would be that a copied plan tree would never be

[COMMITTERS] pgsql: Add missing handling of PlannedStmt.transientPlan in

2010-08-18 Thread Tom Lane
Log Message: --- Add missing handling of PlannedStmt.transientPlan in copyfuncs/outfuncs. _outPlannedStmt is only debug support, so the omission there was not very serious, but the omission in _copyPlannedStmt is a real bug. The consequence would be that a copied plan tree would never be

[COMMITTERS] pgsql: Add missing handling of PlannedStmt.transientPlan in

2010-08-18 Thread Tom Lane
Log Message: --- Add missing handling of PlannedStmt.transientPlan in copyfuncs/outfuncs. _outPlannedStmt is only debug support, so the omission there was not very serious, but the omission in _copyPlannedStmt is a real bug. The consequence would be that a copied plan tree would never be

[COMMITTERS] pgsql: Add missing handling of PlannedStmt.transientPlan in

2010-08-18 Thread Tom Lane
Log Message: --- Add missing handling of PlannedStmt.transientPlan in copyfuncs/outfuncs. _outPlannedStmt is only debug support, so the omission there was not very serious, but the omission in _copyPlannedStmt is a real bug. The consequence would be that a copied plan tree would never be

[COMMITTERS] pgsql: Fix failure of "ALTER TABLE t ADD COLUMN c serial" when done by

2010-08-18 Thread Tom Lane
Log Message: --- Fix failure of "ALTER TABLE t ADD COLUMN c serial" when done by non-owner. The implicitly created sequence was created as owned by the current user, who could be different from the table owner, eg if current user is a superuser or some member of the table's owning role. T

[COMMITTERS] pgsql: Fix failure of "ALTER TABLE t ADD COLUMN c serial" when done by

2010-08-18 Thread Tom Lane
Log Message: --- Fix failure of "ALTER TABLE t ADD COLUMN c serial" when done by non-owner. The implicitly created sequence was created as owned by the current user, who could be different from the table owner, eg if current user is a superuser or some member of the table's owning role. T

[COMMITTERS] pgsql: Rename utf2ucs() to utf8_to_unicode(), and export it so it can be

2010-08-18 Thread Tom Lane
Log Message: --- Rename utf2ucs() to utf8_to_unicode(), and export it so it can be used elsewhere. Similarly rename the version in mbprint.c, not because this affects anything but just to keep the two copies in exact sync. There was some discussion of having only one copy in src/port/ ins

[COMMITTERS] pgsql: Reset the per-output-tuple exprcontext each time through the main

2010-08-18 Thread Tom Lane
Log Message: --- Reset the per-output-tuple exprcontext each time through the main loop in ExecModifyTable(). This avoids memory leakage when trigger functions leave junk behind in that context (as they more or less must). Problem and solution identified by Dean Rasheed. I'm a bit concer

[COMMITTERS] pgsql: Reset the per-output-tuple exprcontext each time through the main

2010-08-18 Thread Tom Lane
Log Message: --- Reset the per-output-tuple exprcontext each time through the main loop in ExecModifyTable(). This avoids memory leakage when trigger functions leave junk behind in that context (as they more or less must). Problem and solution identified by Dean Rasheed. I'm a bit concer

[COMMITTERS] pgsql: Tidy up a few calls to smrgextend().

2010-08-18 Thread Robert Haas
Log Message: --- Tidy up a few calls to smrgextend(). In the new API introduced by my patch to include the backend ID in temprel filenames, the last argument to smrgextend() became skipFsync rather than isTemp, but these calls didn't get the memo. It's not really a problem to pass rel->rd

[COMMITTERS] pgsql: Remove extra newlines at end and beginning of files, add missing

2010-08-18 Thread Peter Eisentraut
Log Message: --- Remove extra newlines at end and beginning of files, add missing newlines at end of files. Modified Files: -- pgsql: README (r1.37 -> r1.38) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/README?r1=1.37&r2=1.38) pgsql/config: c-