Re: [COMMITTERS] pgsql: Speed up conversion of signed integers to C strings.

2010-11-20 Thread Andrew Dunstan
On 11/20/2010 01:10 AM, Robert Haas wrote: On Fri, Nov 19, 2010 at 11:47 PM, Tom Lane wrote: I wrote: Robert Haas writes: Speed up conversion of signed integers to C strings. This patch breaks the build here: ... and while I'm looking at it, the added int8 regression test cases definitel

[COMMITTERS] pgsql: Update int8-exp-three-digits.out to match new contents of int8.o

2010-11-20 Thread Robert Haas
Update int8-exp-three-digits.out to match new contents of int8.out. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=e8bf683fbee935181e207d7171630194ed01f6a1 Modified Files -- .../regress/expected/int8-exp-three-digits.out |

Re: [COMMITTERS] pgsql: Speed up conversion of signed integers to C strings.

2010-11-20 Thread Robert Haas
On Sat, Nov 20, 2010 at 5:23 AM, Andrew Dunstan wrote: >> Ugh.  I made an attempt at a fix to both of these issues, but I'm not >> totally sure I got it right, and I'm too tired to stay up any later to >> see what happens.  I'll check the BF in the morning. > > If you change a test that has altern

Re: [COMMITTERS] pgsql: Speed up conversion of signed integers to C strings.

2010-11-20 Thread Andrew Dunstan
On 11/20/2010 07:10 AM, Robert Haas wrote: Ah, the joy of debugging by buildfarm. Nothing better than having the whole world watch your mistakes in painstaking detail! At least this way you get to do it while your memory is fresh. In the old days we only found out some things were broken

[COMMITTERS] pgsql: Expose quote_literal_cstr() from core.

2010-11-20 Thread Robert Haas
Expose quote_literal_cstr() from core. This eliminates the need for inefficient implementions of this functionality in both contrib/dblink and contrib/tablefunc, so remove them. The upcoming patch implementing an in-core format() function will also require this functionality. In passing, add som

[COMMITTERS] pgsql: Assorted further cleanup for integer-conversion patch.

2010-11-20 Thread Tom Lane
Assorted further cleanup for integer-conversion patch. Avoid depending on LL notation, which is likely to not work in pre-C99 compilers; don't pointlessly use INT32_MIN/INT64_MIN in code that has the numerical value hard-wired into it anyway; remove some gratuitous style inconsistencies between pg

[COMMITTERS] psqlodbc - psqlodbc: addition of a change history.

2010-11-20 Thread Hiroshi Saito
Log Message: --- addition of a change history. Modified Files: -- psqlodbc/docs: release.html (r1.70 -> r1.71) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/psqlodbc/psqlodbc/docs/release.html?r1=1.70&r2=1.71) -- Sent via pgsql-committers mailing list (pgs

[COMMITTERS] pgsql: Minor cleanup of indxpath.c.

2010-11-20 Thread Robert Haas
Minor cleanup of indxpath.c. Eliminate some superfluous notational complexity around match_clause_to_indexcol(), and rip out the DoneMatchingIndexKeys crock. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=99bc012d5198bdfd2aa67336f645dbf887bb

[COMMITTERS] pgsql: Further cleanup of indxpath logic related to IndexOptInfo.opfami

2010-11-20 Thread Tom Lane
Further cleanup of indxpath logic related to IndexOptInfo.opfamily array. We no longer need the terminating zero entry in opfamily[], so get rid of it. Also replace assorted ad-hoc looping logic with simple for and foreach constructs. This code is now noticeably more readable than it was an hour

[COMMITTERS] pgsql: Add new SQL function, format(text).

2010-11-20 Thread Robert Haas
Add new SQL function, format(text). Currently, three conversion format specifiers are supported: %s for a string, %L for an SQL literal, and %I for an SQL identifier. The latter two are deliberately designed not to overlap with what sprintf() already supports, in case we want to add more of sprin