[COMMITTERS] pgsql: setlocale() on Windows doesn't work correctly if the locale name

2011-09-01 Thread Heikki Linnakangas
setlocale() on Windows doesn't work correctly if the locale name contains dots. I previously worked around this in initdb, mapping the known problematic locale names to aliases that work, but Hiroshi Inoue pointed out that that's not enough because even if you use one of the aliases, like "Chinese_

[COMMITTERS] pgsql: setlocale() on Windows doesn't work correctly if the locale name

2011-09-01 Thread Heikki Linnakangas
setlocale() on Windows doesn't work correctly if the locale name contains dots. I previously worked around this in initdb, mapping the known problematic locale names to aliases that work, but Hiroshi Inoue pointed out that that's not enough because even if you use one of the aliases, like "Chinese_

[COMMITTERS] pgsql: Fix MinGW build, broken by my previous patch to add a setlocale(

2011-09-01 Thread Heikki Linnakangas
Fix MinGW build, broken by my previous patch to add a setlocale() wrapper on Windows. ecpglib doesn't link with libpgport, but picks and compiles the .c files it needs individually. To cope with that, move the setlocale() wrapper from chklocale.c to a separate setlocale.c file, and include that in

[COMMITTERS] pgsql: Fix MinGW build, broken by my previous patch to add a setlocale(

2011-09-01 Thread Heikki Linnakangas
Fix MinGW build, broken by my previous patch to add a setlocale() wrapper on Windows. ecpglib doesn't link with libpgport, but picks and compiles the .c files it needs individually. To cope with that, move the setlocale() wrapper from chklocale.c to a separate setlocale.c file, and include that in

Re: [COMMITTERS] pgsql: Allow more include files to be compiled in their own by adding m

2011-09-01 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Andrew Dunstan wrote: > >> I'm not sure I understand the point of it anyway. > > > The idea is that include files should include all needed includes so > > they don't spill dependencies into files that use them. > > I think that's an unwarranted expans

Re: [COMMITTERS] pgsql: Allow more include files to be compiled in their own by adding m

2011-09-01 Thread Bruce Momjian
Bruce Momjian wrote: > Tom Lane wrote: > > Bruce Momjian writes: > > > Allow more include files to be compiled in their own by adding missing > > > include dependencies. > > > > This patch broke the build on buildfarm member mongoose. > > This is the change I made to contrib/cube. I see other c

[COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge

2011-09-01 Thread Bruce Momjian
Remove "fmgr.h" include in cube contrib --- caused crash on a Gentoo builfarm member. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d5321842528dfb73f8254a48556b4adb1b6d1c5a Modified Files -- contrib/cube/cubedata.h |2 -- 1 files changed, 0 insertion

[COMMITTERS] pgsql: Fix "is db labeled test?" in chkselinuxenv script.

2011-09-01 Thread Robert Haas
Fix "is db labeled test?" in chkselinuxenv script. Don't test whether the number of labels is numerically equal to zero; count(*) isn't going return zero anyway, and the current coding blows up if it returns an empty string or an error. Branch -- master Details --- http://git.postgresql.

[COMMITTERS] pgsql: Userspace access vector cache for contrib/sepgsql.

2011-09-01 Thread Robert Haas
Userspace access vector cache for contrib/sepgsql. KaiGai Kohei Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4232c4b406c94b433c149ac792d7e68665948cf1 Modified Files -- configure | 24 +- configure.in |4 +- contrib/s

[COMMITTERS] pgsql: Minor improvements to mbregress.sh script.

2011-09-01 Thread Robert Haas
Minor improvements to mbregress.sh script. 1. Use new dropdb --if-exists option, to avoid alarming the user if the database being dropped doesn't already exist. 2. Bail out if createdb fails. 3. exit 1 if the checks fail. 4. Make it executable. Josh Kupershmidt, with some kibitzing by me. Bra

[COMMITTERS] pgsql: In ecpglib restore LC_NUMERIC in case of an error.

2011-09-01 Thread Michael Meskes
In ecpglib restore LC_NUMERIC in case of an error. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/63d06ef59156719efd0208c62e764a69611b3f12 Modified Files -- src/interfaces/ecpg/ecpglib/execute.c |9 - 1 files changed, 8 insertions(+), 1 deleti

[COMMITTERS] pgsql: In ecpglib restore LC_NUMERIC in case of an error.

2011-09-01 Thread Michael Meskes
In ecpglib restore LC_NUMERIC in case of an error. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/5ad0e899f08136a00f56bf224a6b9729b2f4c69f Modified Files -- src/interfaces/ecpg/ecpglib/execute.c |9 - 1 files changed, 8 insertions(+), 1

[COMMITTERS] pgsql: In ecpglib restore LC_NUMERIC in case of an error.

2011-09-01 Thread Michael Meskes
In ecpglib restore LC_NUMERIC in case of an error. Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/f8c74422010e63506fa69635ea61920bc042b70e Modified Files -- src/interfaces/ecpg/ecpglib/execute.c |9 - 1 files changed, 8 insertions(+), 1

[COMMITTERS] pgsql: In ecpglib restore LC_NUMERIC in case of an error.

2011-09-01 Thread Michael Meskes
In ecpglib restore LC_NUMERIC in case of an error. Branch -- REL8_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/12613cb6b83cac1aa1e7882e84902c445fce3e74 Modified Files -- src/interfaces/ecpg/ecpglib/execute.c |4 1 files changed, 4 insertions(+), 0 dele

[COMMITTERS] pgsql: In ecpglib restore LC_NUMERIC in case of an error.

2011-09-01 Thread Michael Meskes
In ecpglib restore LC_NUMERIC in case of an error. Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/a6d72ac344a8643142d76abe2c9d0b1ea68847fb Modified Files -- src/interfaces/ecpg/ecpglib/execute.c |6 +- 1 files changed, 5 insertions(+), 1 de

[COMMITTERS] pgsql: Remove unnecessary #include references, per pgrminclude script.

2011-09-01 Thread Bruce Momjian
Remove unnecessary #include references, per pgrminclude script. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6416a82a62db4e66b2edb0fa8fc83a580c3f1931 Modified Files -- contrib/auto_explain/auto_explain.c |1 - contrib/btree_gin/btree_gin

Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge

2011-09-01 Thread Tom Lane
Bruce Momjian writes: > Remove "fmgr.h" include in cube contrib --- caused crash on a Gentoo > builfarm member. mongoose is still crashing, so it must have been some other aspect of commit 4bd7333 that caused this. regards, tom lane -- Sent via pgsql-committers mailing

[COMMITTERS] pgsql: In SGML we only need to worry about "<", not ">"; update script

2011-09-01 Thread Bruce Momjian
In SGML we only need to worry about "<", not ">"; update scripts. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b3d32ebac62d89eaedc740af5d3592ac019b8533 Modified Files -- src/tools/RELEASE_CHANGES |2 +- src/tools/find_gt_lt |6 -- src/t

[COMMITTERS] pgsql: Add missing hba.h include for NetBSD.

2011-09-01 Thread Bruce Momjian
Add missing hba.h include for NetBSD. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5352bf39ffc5e5f54c3729d61e36b8a9568e4c35 Modified Files -- src/include/libpq/hba.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- Sent via pgsql-committ

Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge

2011-09-01 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Remove "fmgr.h" include in cube contrib --- caused crash on a Gentoo > > builfarm member. > > mongoose is still crashing, so it must have been some other aspect of > commit 4bd7333 that caused this. Agreed. Let me look some more. Odd this succeeds:

[COMMITTERS] pgsql: Add C comment about necessary NetBSD include.

2011-09-01 Thread Bruce Momjian
Add C comment about necessary NetBSD include. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7805b118560fa8a394823c57b46b70799e2431bb Modified Files -- src/include/libpq/hba.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsq

Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge

2011-09-01 Thread Jeremy Drake
On Thu, 1 Sep 2011, Bruce Momjian wrote: > Tom Lane wrote: > > Bruce Momjian writes: > > > Remove "fmgr.h" include in cube contrib --- caused crash on a Gentoo > > > builfarm member. > > > > mongoose is still crashing, so it must have been some other aspect of > > commit 4bd7333 that caused this.

[COMMITTERS] pgsql: Put back improperly removed #include.

2011-09-01 Thread Tom Lane
Put back improperly removed #include. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e5b012b788800470f3b670e013e9e52b615a018c Modified Files -- src/backend/utils/adt/inet_net_pton.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- Sent via

[COMMITTERS] pgsql: libpq compiles various pgport files like ecpg does, and needs si

2011-09-01 Thread Heikki Linnakangas
libpq compiles various pgport files like ecpg does, and needs similar Makefile changes for the win32 setlocale() wrapper I put into ecpg, to make it compile on MinGW. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/4fcceef0de221ba98d3f273b6d69ef0d17e43e74 Modi

[COMMITTERS] pgsql: libpq compiles various pgport files like ecpg does, and needs si

2011-09-01 Thread Heikki Linnakangas
libpq compiles various pgport files like ecpg does, and needs similar Makefile changes for the win32 setlocale() wrapper I put into ecpg, to make it compile on MinGW. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5066e55d612788cd17c536558f8e5b0aa44d9f31 Modified Fi

Re: [COMMITTERS] pgsql: libpq compiles various pgport files like ecpg does, and needs si

2011-09-01 Thread Tom Lane
Heikki Linnakangas writes: > libpq compiles various pgport files like ecpg does, and needs similar Makefile > changes for the win32 setlocale() wrapper I put into ecpg, to make it compile > on MinGW. The comma added in OBJS macro looks wrong. regards, tom lane -- Sent v

[COMMITTERS] pgsql: Add C comment about needed include.

2011-09-01 Thread Bruce Momjian
Add C comment about needed include. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/10af3ab2b29186735308f49f50520839a75352cb Modified Files -- src/backend/utils/adt/inet_net_pton.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via

[COMMITTERS] pgsql: Remove spurious comma. Spotted by Tom.

2011-09-01 Thread Heikki Linnakangas
Remove spurious comma. Spotted by Tom. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/8027e4d4be11e19784908671bf5cee0c6472fb14 Modified Files -- src/interfaces/libpq/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent vi

[COMMITTERS] pgsql: Remove spurious comma. Spotted by Tom.

2011-09-01 Thread Heikki Linnakangas
Remove spurious comma. Spotted by Tom. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e4df03733086543accba97be241d9d133b273dda Modified Files -- src/interfaces/libpq/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql

Re: [COMMITTERS] pgsql: libpq compiles various pgport files like ecpg does, and needs si

2011-09-01 Thread Heikki Linnakangas
On 01.09.2011 19:47, Tom Lane wrote: Heikki Linnakangas writes: libpq compiles various pgport files like ecpg does, and needs similar Makefile changes for the win32 setlocale() wrapper I put into ecpg, to make it compile on MinGW. The comma added in OBJS macro looks wrong. Thanks, fixed. -

Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge

2011-09-01 Thread Bruce Momjian
Jeremy Drake wrote: > On Thu, 1 Sep 2011, Bruce Momjian wrote: > > > Tom Lane wrote: > > > Bruce Momjian writes: > > > > Remove "fmgr.h" include in cube contrib --- caused crash on a Gentoo > > > > builfarm member. > > > > > > mongoose is still crashing, so it must have been some other aspect of

[COMMITTERS] pgsql: Improve method of avoiding fcinfo compile errors.

2011-09-01 Thread Bruce Momjian
Improve method of avoiding fcinfo compile errors. Fix pgrminclude C comment marker. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/418d04ea73afd3df1fec9670f5f47827aeaf5a25 Modified Files -- src/include/libpq/hba.h |2 +- src/tools/pginclude

[COMMITTERS] pgsql: Supply missing brace omitted by commit 12613cb6b83cac1aa1e7882e8

2011-09-01 Thread Andrew Dunstan
Supply missing brace omitted by commit 12613cb6b83cac1aa1e7882e84902c445fce3e74. Branch -- REL8_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/97464012a0347d7b4456a6b9401f5897522542ee Modified Files -- src/interfaces/ecpg/ecpglib/execute.c |1 + 1 files chang

Re: [COMMITTERS] pgsql: In ecpglib restore LC_NUMERIC in case of an error.

2011-09-01 Thread Andrew Dunstan
On 09/01/2011 09:46 AM, Michael Meskes wrote: In ecpglib restore LC_NUMERIC in case of an error. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/5ad0e899f08136a00f56bf224a6b9729b2f4c69f This commit and all the others in the family except the one for 8.3

Re: [COMMITTERS] pgsql: In ecpglib restore LC_NUMERIC in case of an error.

2011-09-01 Thread Tom Lane
Michael Meskes writes: > In ecpglib restore LC_NUMERIC in case of an error. The 8.3 version of this patch doesn't compile, according to the buildfarm. regards, tom lane -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your s

Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge

2011-09-01 Thread Jeremy Drake
On Thu, 1 Sep 2011, Bruce Momjian wrote: > Jeremy Drake wrote: > > > I am the owner of both mongoose and okapi. Let me know if there's > > anything you want me to try. > > Thanks. I would either like to email you patches to test or get ssh > access so I can compile it myself. You can send me pa