[COMMITTERS] pgsql: Avoid crashing when we have problems unlinking files post-commit

2011-12-20 Thread Tom Lane
Avoid crashing when we have problems unlinking files post-commit. smgrdounlink takes care to not throw an ERROR if it fails to unlink something, but that caution was rendered useless by commit 3396000684b41e7e9467d1abc67152b39e697035, which put an smgrexists call in front of it; smgrexists *does*

[COMMITTERS] pgsql: Avoid crashing when we have problems unlinking files post-commit

2011-12-20 Thread Tom Lane
Avoid crashing when we have problems unlinking files post-commit. smgrdounlink takes care to not throw an ERROR if it fails to unlink something, but that caution was rendered useless by commit 3396000684b41e7e9467d1abc67152b39e697035, which put an smgrexists call in front of it; smgrexists *does*

[COMMITTERS] pgsql: Avoid crashing when we have problems unlinking files post-commit

2011-12-20 Thread Tom Lane
Avoid crashing when we have problems unlinking files post-commit. smgrdounlink takes care to not throw an ERROR if it fails to unlink something, but that caution was rendered useless by commit 3396000684b41e7e9467d1abc67152b39e697035, which put an smgrexists call in front of it; smgrexists *does*

[COMMITTERS] pgsql: Avoid crashing when we have problems unlinking files post-commit

2011-12-20 Thread Tom Lane
Avoid crashing when we have problems unlinking files post-commit. smgrdounlink takes care to not throw an ERROR if it fails to unlink something, but that caution was rendered useless by commit 3396000684b41e7e9467d1abc67152b39e697035, which put an smgrexists call in front of it; smgrexists *does*

[COMMITTERS] pgsql: Fix gincostestimate to handle ScalarArrayOpExpr reasonably.

2011-12-20 Thread Tom Lane
Fix gincostestimate to handle ScalarArrayOpExpr reasonably. The original coding of this function overlooked the possibility that it could be passed anything except simple OpExpr indexquals. But ScalarArrayOpExpr is possible too, and the code would probably crash (and surely give ridiculous answer

[COMMITTERS] pgsql: Fix gincostestimate to handle ScalarArrayOpExpr reasonably.

2011-12-20 Thread Tom Lane
Fix gincostestimate to handle ScalarArrayOpExpr reasonably. The original coding of this function overlooked the possibility that it could be passed anything except simple OpExpr indexquals. But ScalarArrayOpExpr is possible too, and the code would probably crash (and surely give ridiculous answer