[COMMITTERS] pgsql: Fix variable confusion in BufferSync().

2012-01-06 Thread Robert Haas
Fix variable confusion in BufferSync(). As noted by Heikki Linnakangas, the previous coding confused the "flags" variable with the "mask" variable. The affect of this appears to be that unlogged buffers would get written out at every checkpoint rather than only at shutdown time. Although that's

[COMMITTERS] pgsql: Fix variable confusion in BufferSync().

2012-01-06 Thread Robert Haas
Fix variable confusion in BufferSync(). As noted by Heikki Linnakangas, the previous coding confused the "flags" variable with the "mask" variable. The affect of this appears to be that unlogged buffers would get written out at every checkpoint rather than only at shutdown time. Although that's

[COMMITTERS] pgsql: Fix pg_restore's direct-to-database mode for INSERT-style table

2012-01-06 Thread Tom Lane
Fix pg_restore's direct-to-database mode for INSERT-style table data. In commit 6545a901aaf84cb05212bb6a7674059908f527c3, I removed the mini SQL lexer that was in pg_backup_db.c, thinking that it had no real purpose beyond separating COPY data from SQL commands, which purpose had been obsoleted by

[COMMITTERS] pgsql: Fix pg_restore's direct-to-database mode for INSERT-style table

2012-01-06 Thread Tom Lane
Fix pg_restore's direct-to-database mode for INSERT-style table data. In commit 6545a901aaf84cb05212bb6a7674059908f527c3, I removed the mini SQL lexer that was in pg_backup_db.c, thinking that it had no real purpose beyond separating COPY data from SQL commands, which purpose had been obsoleted by

[COMMITTERS] pgsql: Fix pg_restore's direct-to-database mode for INSERT-style table

2012-01-06 Thread Tom Lane
Fix pg_restore's direct-to-database mode for INSERT-style table data. In commit 6545a901aaf84cb05212bb6a7674059908f527c3, I removed the mini SQL lexer that was in pg_backup_db.c, thinking that it had no real purpose beyond separating COPY data from SQL commands, which purpose had been obsoleted by

[COMMITTERS] pgsql: Fix pg_restore's direct-to-database mode for INSERT-style table

2012-01-06 Thread Tom Lane
Fix pg_restore's direct-to-database mode for INSERT-style table data. In commit 6545a901aaf84cb05212bb6a7674059908f527c3, I removed the mini SQL lexer that was in pg_backup_db.c, thinking that it had no real purpose beyond separating COPY data from SQL commands, which purpose had been obsoleted by

[COMMITTERS] pgsql: Fix pg_restore's direct-to-database mode for INSERT-style table

2012-01-06 Thread Tom Lane
Fix pg_restore's direct-to-database mode for INSERT-style table data. In commit 6545a901aaf84cb05212bb6a7674059908f527c3, I removed the mini SQL lexer that was in pg_backup_db.c, thinking that it had no real purpose beyond separating COPY data from SQL commands, which purpose had been obsoleted by

[COMMITTERS] pgsql: Fix typo, pg_types_date.h => pgtypes_date.h.

2012-01-06 Thread Tom Lane
Fix typo, pg_types_date.h => pgtypes_date.h. Spotted by Koizumi Satoru. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7a72efda72a85eef1513f2a02449e24dc4bdfc74 Modified Files -- doc/src/sgml/ecpg.sgml |2 +- 1 files changed, 1 insertions(+), 1 deleti

[COMMITTERS] pgsql: Fix typo, pg_types_date.h => pgtypes_date.h.

2012-01-06 Thread Tom Lane
Fix typo, pg_types_date.h => pgtypes_date.h. Spotted by Koizumi Satoru. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/f517ece06379125a554472c94eb55f7fc82ff658 Modified Files -- doc/src/sgml/ecpg.sgml |2 +- 1 files changed, 1 insertions(+), 1

[COMMITTERS] pgsql: Make the number of CLOG buffers adaptive, based on shared_buffer

2012-01-06 Thread Robert Haas
Make the number of CLOG buffers adaptive, based on shared_buffers. Previously, this was hardcoded: we always had 8. Performance testing shows that isn't enough, especially on big SMP systems, so we allow it to scale up as high as 32 when there's adequate memory. On the flip side, when shared_buf

[COMMITTERS] pgsql: Improve behavior of concurrent ALTER TABLE, and do some refactor

2012-01-06 Thread Robert Haas
Improve behavior of concurrent ALTER TABLE, and do some refactoring. ALTER TABLE (and ALTER VIEW, ALTER SEQUENCE, etc.) now use a RangeVarGetRelid callback to check permissions before acquiring a table lock. We also now use the same callback for all forms of ALTER TABLE, rather than having separa

[COMMITTERS] pgsql: Fix backwards logic in previous commit.

2012-01-06 Thread Robert Haas
Fix backwards logic in previous commit. I wrote this code before committing it, but managed not to include it in the actual commit. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/df970a0ac8fb416b179825a135c18ad3293076af Modified Files -- src/backend/com

[COMMITTERS] pgsql: Slightly reorganize struct SnapshotData.

2012-01-06 Thread Robert Haas
Slightly reorganize struct SnapshotData. This squeezes out a bunch of alignment padding, reducing the size from 72 to 56 bytes on my machine. At least in my testing, this didn't produce any measurable performance improvement, but the space savings seem like enough justification. Andres Freund B