[COMMITTERS] pgsql: Add some enumeration commas, for consistency

2012-02-24 Thread Peter Eisentraut
Add some enumeration commas, for consistency Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9cfd800aab9ee3c3b0b2b11ab41e129cc92dc15b Modified Files -- src/backend/access/gist/gistbuild.c |2 +- src/backend/commands/async.c |2 +- src/bac

Re: [COMMITTERS] pgsql: Add some enumeration commas, for consistency

2012-02-24 Thread Thom Brown
On 24 February 2012 09:05, Peter Eisentraut wrote: > Add some enumeration commas, for consistency Are you sure about this? Generally a serial comma isn't used before "and" unless splitting a list into larger sub-groups. e.g. The sun and the moon, flora and fauna, and flotsam and jetsam. -- Th

Re: [COMMITTERS] pgsql: Add some enumeration commas, for consistency

2012-02-24 Thread Peter Eisentraut
On fre, 2012-02-24 at 09:16 +, Thom Brown wrote: > On 24 February 2012 09:05, Peter Eisentraut wrote: > > Add some enumeration commas, for consistency > > Are you sure about this? Generally a serial comma isn't used before > "and" It is in our source code. See also http://en.wikipedia.org/

Re: [COMMITTERS] pgsql: Add some enumeration commas, for consistency

2012-02-24 Thread Thom Brown
On 24 February 2012 09:28, Peter Eisentraut wrote: > On fre, 2012-02-24 at 09:16 +, Thom Brown wrote: >> On 24 February 2012 09:05, Peter Eisentraut wrote: >> > Add some enumeration commas, for consistency >> >> Are you sure about this?  Generally a serial comma isn't used before >> "and" > >

[COMMITTERS] pginstaller - pginst: Bump version number

2012-02-24 Thread Dave Page
Log Message: --- Bump version number Tags: REL8_3_STABLE Modified Files: -- pginst/package: README.TXT (r1.7.2.17 -> r1.7.2.18) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pginstaller/pginst/package/README.TXT?r1=1.7.2.17&r2=1.7.2.18) -- Sent via p

[COMMITTERS] pgsql: Put Debian package list back in alphabetical order

2012-02-24 Thread Peter Eisentraut
Put Debian package list back in alphabetical order Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3aa42c25c3d1cab8dcbdff913aa60e404f67de1f Modified Files -- doc/src/sgml/docguide.sgml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent

[COMMITTERS] pgsql: Update src/tools/make_ctags to avoid Exuberant tags option

2012-02-24 Thread Bruce Momjian
Update src/tools/make_ctags to avoid Exuberant tags option that has been renamed and undocumented since 2003; instead, use the documented option. Add comments. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7c19f9d139e76529bbb94b1bde7bc4c19f1bc37a Modified Files -

[COMMITTERS] pgsql: Mention original ctags option name.

2012-02-24 Thread Bruce Momjian
Mention original ctags option name. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1fbacbf998678ae8d5868aeea3e83c915e940d0a Modified Files -- src/tools/make_ctags |1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- Sent via pgsql-committers m

[COMMITTERS] pgsql: Avoid repeated creation/freeing of per-subre DFAs during regex s

2012-02-24 Thread Tom Lane
Avoid repeated creation/freeing of per-subre DFAs during regex search. In nested sub-regex trees, lower-level nodes created DFAs and then destroyed them again before exiting, which is a bit dumb considering that the recursive search is likely to call those nodes again later. Instead cache each cr

[COMMITTERS] pgsql: Remove useless "retry memory" logic within regex engine.

2012-02-24 Thread Tom Lane
Remove useless "retry memory" logic within regex engine. Apparently some primordial version of Spencer's engine needed cdissect() and child functions to be able to continue matching from a previous position when re-called. That is dead code, though, since trivial inspection shows that cdissect ca

[COMMITTERS] pgsql: Merge dissect() into cdissect() to remove a pile of near-duplica

2012-02-24 Thread Tom Lane
Merge dissect() into cdissect() to remove a pile of near-duplicate code. The "uncomplicated" case isn't materially less complicated than the full case, certainly not enough so to justify duplicating nearly 500 lines of code. The only extra work being done in the full path is zaptreesubs, which is