[COMMITTERS] pgsql: Fix function argument tab completion for schema-qualified or quo

2012-07-05 Thread Magnus Hagander
Fix function argument tab completion for schema-qualified or quoted function names Dean Rasheed, reviewed by Josh Kupershmidt Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3644a63984cbdba2c78c22fd9a0cdb0f4701b600 Modified Files -- src/bin/psql/tab-com

[COMMITTERS] pgsql: pg_upgrade: abstract out copying of files from old cluster to ne

2012-07-05 Thread Alvaro Herrera
pg_upgrade: abstract out copying of files from old cluster to new Currently only pg_clog is copied, but some other directories could need the same treatment as well, so create a subroutine to do it. Extracted from my (somewhat larger) FOR KEY SHARE patch. Branch -- master Details --- ht

[COMMITTERS] pgsql: Remove support for using wait3() in place of waitpid().

2012-07-05 Thread Tom Lane
Remove support for using wait3() in place of waitpid(). All Unix-oid platforms that we currently support should have waitpid(), since it's in V2 of the Single Unix Spec. Our git history shows that the wait3 code was added to support NextStep, which we officially dropped support for as of 9.2. So

[COMMITTERS] pgsql: Fix mapping of PostgreSQL encodings to Python encodings.

2012-07-05 Thread Heikki Linnakangas
Fix mapping of PostgreSQL encodings to Python encodings. Windows encodings, "win1252" and so forth, are named differently in Python, like "cp1252". Also, if the PyUnicode_AsEncodedString() function call fails for some reason, use a plain ereport(), not a PLy_elog(), to report that error. That avoi

[COMMITTERS] pgsql: Fix mapping of PostgreSQL encodings to Python encodings.

2012-07-05 Thread Heikki Linnakangas
Fix mapping of PostgreSQL encodings to Python encodings. Windows encodings, "win1252" and so forth, are named differently in Python, like "cp1252". Also, if the PyUnicode_AsEncodedString() function call fails for some reason, use a plain ereport(), not a PLy_elog(), to report that error. That avoi

[COMMITTERS] pgsql: Fix mapping of PostgreSQL encodings to Python encodings.

2012-07-05 Thread Heikki Linnakangas
Fix mapping of PostgreSQL encodings to Python encodings. Windows encodings, "win1252" and so forth, are named differently in Python, like "cp1252". Also, if the PyUnicode_AsEncodedString() function call fails for some reason, use a plain ereport(), not a PLy_elog(), to report that error. That avoi

[COMMITTERS] pgsql: Fix mapping of PostgreSQL encodings to Python encodings.

2012-07-05 Thread Heikki Linnakangas
Fix mapping of PostgreSQL encodings to Python encodings. Windows encodings, "win1252" and so forth, are named differently in Python, like "cp1252". Also, if the PyUnicode_AsEncodedString() function call fails for some reason, use a plain ereport(), not a PLy_elog(), to report that error. That avoi

Re: [COMMITTERS] pgsql: Fix mapping of PostgreSQL encodings to Python encodings.

2012-07-05 Thread Tom Lane
Heikki Linnakangas writes: > Fix mapping of PostgreSQL encodings to Python encodings. The buildfarm doesn't like this --- did you check for side effects on regression test results? regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.

[COMMITTERS] pgsql: Revert part of the previous patch that avoided using PLy_elog().

2012-07-05 Thread Heikki Linnakangas
Revert part of the previous patch that avoided using PLy_elog(). That caused the plpython_unicode regression test to fail on SQL_ASCII encoding, as evidenced by the buildfarm. The reason is that with the patch, you don't get the detail in the error message that you got before. That detail is actua

[COMMITTERS] pgsql: Revert part of the previous patch that avoided using PLy_elog().

2012-07-05 Thread Heikki Linnakangas
Revert part of the previous patch that avoided using PLy_elog(). That caused the plpython_unicode regression test to fail on SQL_ASCII encoding, as evidenced by the buildfarm. The reason is that with the patch, you don't get the detail in the error message that you got before. That detail is actua

[COMMITTERS] pgsql: Revert part of the previous patch that avoided using PLy_elog().

2012-07-05 Thread Heikki Linnakangas
Revert part of the previous patch that avoided using PLy_elog(). That caused the plpython_unicode regression test to fail on SQL_ASCII encoding, as evidenced by the buildfarm. The reason is that with the patch, you don't get the detail in the error message that you got before. That detail is actua

[COMMITTERS] pgsql: Revert part of the previous patch that avoided using PLy_elog().

2012-07-05 Thread Heikki Linnakangas
Revert part of the previous patch that avoided using PLy_elog(). That caused the plpython_unicode regression test to fail on SQL_ASCII encoding, as evidenced by the buildfarm. The reason is that with the patch, you don't get the detail in the error message that you got before. That detail is actua

[COMMITTERS] pgsql: Don't try to trim "../" in join_path_components().

2012-07-05 Thread Tom Lane
Don't try to trim "../" in join_path_components(). join_path_components() tried to remove leading ".." components from its tail argument, but it was not nearly bright enough to do so correctly unless the head argument was (a) absolute and (b) canonicalized. Rather than try to fix that logic, let's

[COMMITTERS] pgsql: Don't try to trim "../" in join_path_components().

2012-07-05 Thread Tom Lane
Don't try to trim "../" in join_path_components(). join_path_components() tried to remove leading ".." components from its tail argument, but it was not nearly bright enough to do so correctly unless the head argument was (a) absolute and (b) canonicalized. Rather than try to fix that logic, let's

[COMMITTERS] pgsql: Don't try to trim "../" in join_path_components().

2012-07-05 Thread Tom Lane
Don't try to trim "../" in join_path_components(). join_path_components() tried to remove leading ".." components from its tail argument, but it was not nearly bright enough to do so correctly unless the head argument was (a) absolute and (b) canonicalized. Rather than try to fix that logic, let's

[COMMITTERS] pgsql: Don't try to trim "../" in join_path_components().

2012-07-05 Thread Tom Lane
Don't try to trim "../" in join_path_components(). join_path_components() tried to remove leading ".." components from its tail argument, but it was not nearly bright enough to do so correctly unless the head argument was (a) absolute and (b) canonicalized. Rather than try to fix that logic, let's

[COMMITTERS] pgsql: Don't try to trim "../" in join_path_components().

2012-07-05 Thread Tom Lane
Don't try to trim "../" in join_path_components(). join_path_components() tried to remove leading ".." components from its tail argument, but it was not nearly bright enough to do so correctly unless the head argument was (a) absolute and (b) canonicalized. Rather than try to fix that logic, let's

[COMMITTERS] pgsql: Don't try to trim "../" in join_path_components().

2012-07-05 Thread Tom Lane
Don't try to trim "../" in join_path_components(). join_path_components() tried to remove leading ".." components from its tail argument, but it was not nearly bright enough to do so correctly unless the head argument was (a) absolute and (b) canonicalized. Rather than try to fix that logic, let's

[COMMITTERS] pgsql: Fix PGDATAOLD and PGDATANEW to properly set pgconfig location, p

2012-07-05 Thread Bruce Momjian
Fix PGDATAOLD and PGDATANEW to properly set pgconfig location, per report from Tom. Backpatch to 9.2. Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/11da73ad9e2ab9b70fbc245f1830058c08cc2a60 Modified Files -- contrib/pg_upgrade/option.c | 23 +++

[COMMITTERS] pgsql: Fix PGDATAOLD and PGDATANEW to properly set pgconfig location, p

2012-07-05 Thread Bruce Momjian
Fix PGDATAOLD and PGDATANEW to properly set pgconfig location, per report from Tom. Backpatch to 9.2. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2eeb5eb23fa9ad1a2d636bbf2fd68e6709848d23 Modified Files -- contrib/pg_upgrade/option.c | 23 ++

[COMMITTERS] pgsql: Fix failure of new wchar->mb functions to advance from pointer.

2012-07-05 Thread Robert Haas
Fix failure of new wchar->mb functions to advance from pointer. Bug spotted by Tom Lane. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f6a05fd973a102f7e66c491d3f854864b8d24844 Modified Files -- src/backend/utils/mb/wchar.c |5 - 1 files changed,