[COMMITTERS] pgsql: Fix race condition in pg_ctl reading postmaster.pid.

2012-10-15 Thread Heikki Linnakangas
Fix race condition in pg_ctl reading postmaster.pid. If postmaster changed postmaster.pid while pg_ctl was reading it, pg_ctl could overrun the buffer it allocated for the file. Fix by reading the whole file to memory with one read() call. initdb contains an identical copy of the readfile() funct

[COMMITTERS] pgsql: Fix race condition in pg_ctl reading postmaster.pid.

2012-10-15 Thread Heikki Linnakangas
Fix race condition in pg_ctl reading postmaster.pid. If postmaster changed postmaster.pid while pg_ctl was reading it, pg_ctl could overrun the buffer it allocated for the file. Fix by reading the whole file to memory with one read() call. initdb contains an identical copy of the readfile() funct

[COMMITTERS] pgsql: Fix race condition in pg_ctl reading postmaster.pid.

2012-10-15 Thread Heikki Linnakangas
Fix race condition in pg_ctl reading postmaster.pid. If postmaster changed postmaster.pid while pg_ctl was reading it, pg_ctl could overrun the buffer it allocated for the file. Fix by reading the whole file to memory with one read() call. initdb contains an identical copy of the readfile() funct

[COMMITTERS] pgsql: Fix race condition in pg_ctl reading postmaster.pid.

2012-10-15 Thread Heikki Linnakangas
Fix race condition in pg_ctl reading postmaster.pid. If postmaster changed postmaster.pid while pg_ctl was reading it, pg_ctl could overrun the buffer it allocated for the file. Fix by reading the whole file to memory with one read() call. initdb contains an identical copy of the readfile() funct

[COMMITTERS] pgsql: Fix race condition in pg_ctl reading postmaster.pid.

2012-10-15 Thread Heikki Linnakangas
Fix race condition in pg_ctl reading postmaster.pid. If postmaster changed postmaster.pid while pg_ctl was reading it, pg_ctl could overrun the buffer it allocated for the file. Fix by reading the whole file to memory with one read() call. initdb contains an identical copy of the readfile() funct

[COMMITTERS] pgsql: Remove comment that is no longer true.

2012-10-15 Thread Heikki Linnakangas
Remove comment that is no longer true. AddToDataDirLockFile() supports out-of-order updates of the lockfile nowadays. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ff6c78c48009d667bf1eb66105b0c2e05dcd2fa2 Modified Files -- src/include/miscadmin.h |

[COMMITTERS] pgsql: Fix race condition in pg_ctl reading postmaster.pid.

2012-10-15 Thread Heikki Linnakangas
Fix race condition in pg_ctl reading postmaster.pid. If postmaster changed postmaster.pid while pg_ctl was reading it, pg_ctl could overrun the buffer it allocated for the file. Fix by reading the whole file to memory with one read() call. initdb contains an identical copy of the readfile() funct

[COMMITTERS] pgsql: Fix typo in comment.

2012-10-15 Thread Heikki Linnakangas
Fix typo in comment. Fujii Masao Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7d3ed5ae78df0f7b85f57b3cee9b70c7bd415645 Modified Files -- src/backend/replication/walreceiver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pg

Re: [COMMITTERS] pgsql: Fix race condition in pg_ctl reading postmaster.pid.

2012-10-15 Thread Tom Lane
Heikki Linnakangas writes: > Fix race condition in pg_ctl reading postmaster.pid. > If postmaster changed postmaster.pid while pg_ctl was reading it, pg_ctl > could overrun the buffer it allocated for the file. Fix by reading the > whole file to memory with one read() call. Maybe I'm just not awa

Re: [COMMITTERS] pgsql: Fix race condition in pg_ctl reading postmaster.pid.

2012-10-15 Thread Heikki Linnakangas
On 15.10.2012 17:05, Tom Lane wrote: Heikki Linnakangas writes: Fix race condition in pg_ctl reading postmaster.pid. If postmaster changed postmaster.pid while pg_ctl was reading it, pg_ctl could overrun the buffer it allocated for the file. Fix by reading the whole file to memory with one read

[COMMITTERS] pgsql: alter_generic regression test cannot run concurrently with privi

2012-10-15 Thread Tom Lane
alter_generic regression test cannot run concurrently with privileges test. ... because the latter plays games with the privileges for language SQL. It looks like running alter_generic in parallel with "misc" is OK though. Also, adjust serial_schedule to maintain the same test ordering (up to par