[COMMITTERS] pgsql: Clean environment for pg_upgrade test.

2012-11-30 Thread Andrew Dunstan
Clean environment for pg_upgrade test. This removes exisiting PG settings from the environment for pg_upgrade tests, just like pg_regress does. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/abece8af179f18af3b877220d83f743127ee1aa6 Modified Files -- con

Re: [COMMITTERS] pgsql: Clean environment for pg_upgrade test.

2012-11-30 Thread Tom Lane
Andrew Dunstan writes: > Clean environment for pg_upgrade test. Seems like this is a bug fix --- shouldn't it be backpatched into the 9.2 version of the script? regards, tom lane -- Sent via pgsql-committers mailing list ([email protected]) To make change

Re: [COMMITTERS] pgsql: Clean environment for pg_upgrade test.

2012-11-30 Thread Andrew Dunstan
On 11/30/2012 10:46 AM, Tom Lane wrote: Andrew Dunstan writes: Clean environment for pg_upgrade test. Seems like this is a bug fix --- shouldn't it be backpatched into the 9.2 version of the script? Oops, yes, you're right. Will do. cheers andrew -- Sent via

[COMMITTERS] pgsql: Clean environment for pg_upgrade test.

2012-11-30 Thread Andrew Dunstan
Clean environment for pg_upgrade test. This removes exisiting PG settings from the environment for pg_upgrade tests, just like pg_regress does. Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/2c55189b2b9e71a14bba1496da6be84614595983 Modified Files ---

[COMMITTERS] pgsql: Add missing buffer lock acquisition in GetTupleForTrigger().

2012-11-30 Thread Tom Lane
Add missing buffer lock acquisition in GetTupleForTrigger(). If we had not been holding buffer pin continuously since the tuple was initially fetched by the UPDATE or DELETE query, it would be possible for VACUUM or a page-prune operation to move the tuple while we're trying to copy it. This woul

[COMMITTERS] pgsql: Add missing buffer lock acquisition in GetTupleForTrigger().

2012-11-30 Thread Tom Lane
Add missing buffer lock acquisition in GetTupleForTrigger(). If we had not been holding buffer pin continuously since the tuple was initially fetched by the UPDATE or DELETE query, it would be possible for VACUUM or a page-prune operation to move the tuple while we're trying to copy it. This woul

[COMMITTERS] pgsql: Add missing buffer lock acquisition in GetTupleForTrigger().

2012-11-30 Thread Tom Lane
Add missing buffer lock acquisition in GetTupleForTrigger(). If we had not been holding buffer pin continuously since the tuple was initially fetched by the UPDATE or DELETE query, it would be possible for VACUUM or a page-prune operation to move the tuple while we're trying to copy it. This woul

[COMMITTERS] pgsql: Add missing buffer lock acquisition in GetTupleForTrigger().

2012-11-30 Thread Tom Lane
Add missing buffer lock acquisition in GetTupleForTrigger(). If we had not been holding buffer pin continuously since the tuple was initially fetched by the UPDATE or DELETE query, it would be possible for VACUUM or a page-prune operation to move the tuple while we're trying to copy it. This woul

[COMMITTERS] pgsql: Add missing buffer lock acquisition in GetTupleForTrigger().

2012-11-30 Thread Tom Lane
Add missing buffer lock acquisition in GetTupleForTrigger(). If we had not been holding buffer pin continuously since the tuple was initially fetched by the UPDATE or DELETE query, it would be possible for VACUUM or a page-prune operation to move the tuple while we're trying to copy it. This woul

[COMMITTERS] pgsql: Add missing buffer lock acquisition in GetTupleForTrigger().

2012-11-30 Thread Tom Lane
Add missing buffer lock acquisition in GetTupleForTrigger(). If we had not been holding buffer pin continuously since the tuple was initially fetched by the UPDATE or DELETE query, it would be possible for VACUUM or a page-prune operation to move the tuple while we're trying to copy it. This woul

[COMMITTERS] pgsql: Move long_options structures to the top of main() functions, for

2012-11-30 Thread Bruce Momjian
Move long_options structures to the top of main() functions, for consistency. Per suggestion from Tom. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bd9c8e741b5724e31b2a3d8da9f0218f7b3b44e5 Modified Files -- contrib/pg_test_fsync/pg_test_fsync.c |

[COMMITTERS] pgsql: In pg_upgrade, dump each database separately and use

2012-11-30 Thread Bruce Momjian
In pg_upgrade, dump each database separately and use --single-transaction to restore each database schema. This yields performance improvements for databases with many tables. Also, remove split_old_dump() as it is no longer needed. Branch -- master Details --- http://git.postgresql.org

[COMMITTERS] pgsql: Split initdb.c main() code into multiple functions, for easier

2012-11-30 Thread Bruce Momjian
Split initdb.c main() code into multiple functions, for easier maintenance. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b86327c1c53aab732e21666e8c8a97b11cded804 Modified Files -- src/bin/initdb/initdb.c | 668 ++---

[COMMITTERS] pgsql: Take buffer lock while inspecting btree index pages in contrib/p

2012-11-30 Thread Tom Lane
Take buffer lock while inspecting btree index pages in contrib/pageinspect. It's not safe to examine a shared buffer without any lock. Branch -- REL8_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/b10b1fa86169f6cc8ecb7f7005a67e59d3280e02 Modified Files -- contr

[COMMITTERS] pgsql: Take buffer lock while inspecting btree index pages in contrib/p

2012-11-30 Thread Tom Lane
Take buffer lock while inspecting btree index pages in contrib/pageinspect. It's not safe to examine a shared buffer without any lock. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/2b96c32d5361f443b00d17bfbe1fc84dcdd6fbc0 Modified Files -- contr

[COMMITTERS] pgsql: Take buffer lock while inspecting btree index pages in contrib/p

2012-11-30 Thread Tom Lane
Take buffer lock while inspecting btree index pages in contrib/pageinspect. It's not safe to examine a shared buffer without any lock. Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/0adcaeef21d18fc04879a08aeea6cd7efce21296 Modified Files -- contr

[COMMITTERS] pgsql: Take buffer lock while inspecting btree index pages in contrib/p

2012-11-30 Thread Tom Lane
Take buffer lock while inspecting btree index pages in contrib/pageinspect. It's not safe to examine a shared buffer without any lock. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d54a94b806825a119be86d5f73232b06dd9e9a16 Modified Files -- contrib/page

[COMMITTERS] pgsql: Take buffer lock while inspecting btree index pages in contrib/p

2012-11-30 Thread Tom Lane
Take buffer lock while inspecting btree index pages in contrib/pageinspect. It's not safe to examine a shared buffer without any lock. Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/de0849c28a90687d64ea6c5a5c39711cf4004e5f Modified Files -- contr

[COMMITTERS] pgsql: Take buffer lock while inspecting btree index pages in contrib/p

2012-11-30 Thread Tom Lane
Take buffer lock while inspecting btree index pages in contrib/pageinspect. It's not safe to examine a shared buffer without any lock. Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/f6a0170777a2c43307474e19785e3f11ae64b5a6 Modified Files -- contr

[COMMITTERS] pgsql: Change test ExceptionalCondition to return void

2012-11-30 Thread Alvaro Herrera
Change test ExceptionalCondition to return void Commit 81107282a changed it in assert.c, but overlooked this other file. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/113d25c4e6b113aa249640af0682f09c781a Modified Files -- src/backend/port/ipc_test.

[COMMITTERS] pgsql: Change test ExceptionalCondition to return void

2012-11-30 Thread Alvaro Herrera
Change test ExceptionalCondition to return void Commit 81107282a changed it in assert.c, but overlooked this other file. Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/f18c9510dcf9a5a6cbd6d99458be4a519714d665 Modified Files -- src/backend/port/ip

[COMMITTERS] pgsql: In pg_upgrade, improve status wording now that we have per-datab

2012-11-30 Thread Bruce Momjian
In pg_upgrade, improve status wording now that we have per-database status output for dump/restore. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5eeab9c85cfd7d7ddda4d72ea8a4f03aa2a74969 Modified Files -- contrib/pg_upgrade/dump.c |7 --- c

[COMMITTERS] pgsql: doc: Fix broken links to DocBook wiki

2012-11-30 Thread Peter Eisentraut
doc: Fix broken links to DocBook wiki Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/1b4359b55d8fe32a54460c3ea00567a2fafa6b9c Modified Files -- doc/src/sgml/docguide.sgml |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- Sent via

[COMMITTERS] pgsql: doc: Fix broken links to DocBook wiki

2012-11-30 Thread Peter Eisentraut
doc: Fix broken links to DocBook wiki Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/3f27f90cfe2d45169c6d726792a37bab78fe4fef Modified Files -- doc/src/sgml/docguide.sgml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pg

[COMMITTERS] pgsql: doc: Fix broken links to DocBook wiki

2012-11-30 Thread Peter Eisentraut
doc: Fix broken links to DocBook wiki Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/44c03efee3d15a1db3d64bc5a2da91c145a91873 Modified Files -- doc/src/sgml/docguide.sgml |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- Sent via pgsql-c

[COMMITTERS] pgsql: doc: Fix broken links to DocBook wiki

2012-11-30 Thread Peter Eisentraut
doc: Fix broken links to DocBook wiki Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/af09efda128173b2eb273e1882435baba2115aef Modified Files -- doc/src/sgml/docguide.sgml |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- Sent via

[COMMITTERS] pgsql: doc: Fix broken links to DocBook wiki

2012-11-30 Thread Peter Eisentraut
doc: Fix broken links to DocBook wiki Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/4ef41598171b93be06e2f46d4301ae173da62f34 Modified Files -- doc/src/sgml/docguide.sgml |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- Sent via