[COMMITTERS] pgsql: Add pg_upgrade comment about mismatch error

2012-12-20 Thread Bruce Momjian
Add pg_upgrade comment about mismatch error Add comment stating that constraint and index names must match. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/345fb82f1616b4d44d8a67a6c10e964400d29c09 Modified Files -- contrib/pg_upgrade/info.c |3 +++ 1

[COMMITTERS] pgsql: Don't set ThisTimeLineID in checkpointer & bgwriter during recov

2012-12-20 Thread Heikki Linnakangas
Don't set ThisTimeLineID in checkpointer & bgwriter during recovery. We used to set it to the current recovery target timeline, but the recovery target timeline can change during recovery, leaving ThisTimeLineID at an old value. That seems worse than always leaving it at zero to begin with. AFAIC

[COMMITTERS] pgsql: Follow TLI of last replayed record, not recovery target TLI, in

2012-12-20 Thread Heikki Linnakangas
Follow TLI of last replayed record, not recovery target TLI, in walsenders. Most of the time, the last replayed record comes from the recovery target timeline, but there is a corner case where it makes a difference. When the startup process scans for a new timeline, and decides to change recovery

[COMMITTERS] pgsql: Avoid using NAMEDATALEN in pg_upgrade

2012-12-20 Thread Bruce Momjian
Avoid using NAMEDATALEN in pg_upgrade Because the client encoding might not match the server encoding, pg_upgrade can't allocate NAMEDATALEN bytes for storage of database, relation, and namespace identifiers. Instead pg_strdup() the memory and free it. Also add C comment in initdb.c about safe N

[COMMITTERS] pgsql: Fix recycling of WAL segments after changing recovery target tim

2012-12-20 Thread Heikki Linnakangas
Fix recycling of WAL segments after changing recovery target timeline. After the recovery target timeline is changed, we would still recycle and preallocate WAL segments on the old target timeline. Those WAL segments created for the old timeline are a waste of space, although otherwise harmless.

[COMMITTERS] pgsql: Fix recycling of WAL segments after switching timeline during re

2012-12-20 Thread Heikki Linnakangas
Fix recycling of WAL segments after switching timeline during recovery. This was broken before, we would recycle old WAL segments on wrong timeline after the recovery target timeline had changed, but my recent commit to not initialize ThisTimeLineID at all in a standby's checkpointer process broke

[COMMITTERS] pgsql: Fix recycling of WAL segments after changing recovery target tim

2012-12-20 Thread Heikki Linnakangas
Fix recycling of WAL segments after changing recovery target timeline. After the recovery target timeline is changed, we would still recycle and preallocate WAL segments on the old target timeline. Those WAL segments created for the old timeline are a waste of space, although otherwise harmless.

[COMMITTERS] pgsql: Fix pg_extension_config_dump() to handle update cases more sanel

2012-12-20 Thread Tom Lane
Fix pg_extension_config_dump() to handle update cases more sanely. If pg_extension_config_dump() is executed again for a table already listed in the extension's extconfig, the code was blindly making a new array entry. This does not seem useful. Fix it to replace the existing array entry instead,

[COMMITTERS] pgsql: Fix pg_extension_config_dump() to handle update cases more sanel

2012-12-20 Thread Tom Lane
Fix pg_extension_config_dump() to handle update cases more sanely. If pg_extension_config_dump() is executed again for a table already listed in the extension's extconfig, the code was blindly making a new array entry. This does not seem useful. Fix it to replace the existing array entry instead,

[COMMITTERS] pgsql: Fix pg_extension_config_dump() to handle update cases more sanel

2012-12-20 Thread Tom Lane
Fix pg_extension_config_dump() to handle update cases more sanely. If pg_extension_config_dump() is executed again for a table already listed in the extension's extconfig, the code was blindly making a new array entry. This does not seem useful. Fix it to replace the existing array entry instead,

Re: [COMMITTERS] pgsql: Follow TLI of last replayed record, not recovery target TLI, in

2012-12-20 Thread Fujii Masao
On Thu, Dec 20, 2012 at 9:41 PM, Heikki Linnakangas wrote: > Follow TLI of last replayed record, not recovery target TLI, in walsenders. > > Most of the time, the last replayed record comes from the recovery target > timeline, but there is a corner case where it makes a difference. When > the star

[COMMITTERS] pgsql: Fix grammatical mistake in error message

2012-12-20 Thread Peter Eisentraut
Fix grammatical mistake in error message Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a0bfb7b36e0795a1c69c86b4184ee952dbb650d1 Modified Files -- src/backend/access/transam/xlog.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- Sent v

[COMMITTERS] pgsql: Fix grammatical mistake in error message

2012-12-20 Thread Peter Eisentraut
Fix grammatical mistake in error message Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/3463dacc5627b849bbddd3f395dca44f39430e19 Modified Files -- src/backend/access/transam/xlog.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) --

[COMMITTERS] pgsql: Make some messages more consistent in style

2012-12-20 Thread Peter Eisentraut
Make some messages more consistent in style Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/740ee42da5fc07e5b1be5c358673224d99cb2aae Modified Files -- src/backend/catalog/pg_proc.c|2 +- src/backend/commands/vacuumlazy.c|2 +- sr

[COMMITTERS] pgsql: Forgot to remove extern declaration of GetRecoveryTargetTLI()

2012-12-20 Thread Heikki Linnakangas
Forgot to remove extern declaration of GetRecoveryTargetTLI() Fujii Masao Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d57a97343ecec89ecb7d932c21c886058ad64e6b Modified Files -- src/include/access/xlog.h |1 - 1 files changed, 0 insertions(+), 1 de