[COMMITTERS] pgsql: Rely only on checkpoint 1 at end of recovery.

2013-02-07 Thread Simon Riggs
Rely only on checkpoint 1 at end of recovery. Searching for checkpoint 2 (previous) is not correct in all cases. Bug report from Heikki Linnakangas Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/072521b8c804cc15800e503244661d17c6202ccc Modified Files --

[COMMITTERS] pgsql: Fix possible failure to send final transaction counts to stats c

2013-02-07 Thread Tom Lane
Fix possible failure to send final transaction counts to stats collector. Normally, we suppress sending a tabstats message to the collector unless there were some actual table stats to send. However, during backend exit we should force out the message if there are any transaction commit/abort cou

[COMMITTERS] pgsql: Fix possible failure to send final transaction counts to stats c

2013-02-07 Thread Tom Lane
Fix possible failure to send final transaction counts to stats collector. Normally, we suppress sending a tabstats message to the collector unless there were some actual table stats to send. However, during backend exit we should force out the message if there are any transaction commit/abort cou

[COMMITTERS] pgsql: Fix possible failure to send final transaction counts to stats c

2013-02-07 Thread Tom Lane
Fix possible failure to send final transaction counts to stats collector. Normally, we suppress sending a tabstats message to the collector unless there were some actual table stats to send. However, during backend exit we should force out the message if there are any transaction commit/abort cou

[COMMITTERS] pgsql: Fix possible failure to send final transaction counts to stats c

2013-02-07 Thread Tom Lane
Fix possible failure to send final transaction counts to stats collector. Normally, we suppress sending a tabstats message to the collector unless there were some actual table stats to send. However, during backend exit we should force out the message if there are any transaction commit/abort cou

[COMMITTERS] pgsql: Fix possible failure to send final transaction counts to stats c

2013-02-07 Thread Tom Lane
Fix possible failure to send final transaction counts to stats collector. Normally, we suppress sending a tabstats message to the collector unless there were some actual table stats to send. However, during backend exit we should force out the message if there are any transaction commit/abort cou

[COMMITTERS] pgsql: Repair bugs in GiST page splitting code for multi-column indexes

2013-02-07 Thread Tom Lane
Repair bugs in GiST page splitting code for multi-column indexes. When considering a non-last column in a multi-column GiST index, gistsplit.c tries to improve on the split chosen by the opclass-specific pickSplit function by considering penalties for the next column. However, there were two bugs

[COMMITTERS] pgsql: Repair bugs in GiST page splitting code for multi-column indexes

2013-02-07 Thread Tom Lane
Repair bugs in GiST page splitting code for multi-column indexes. When considering a non-last column in a multi-column GiST index, gistsplit.c tries to improve on the split chosen by the opclass-specific pickSplit function by considering penalties for the next column. However, there were two bugs

[COMMITTERS] pgsql: Repair bugs in GiST page splitting code for multi-column indexes

2013-02-07 Thread Tom Lane
Repair bugs in GiST page splitting code for multi-column indexes. When considering a non-last column in a multi-column GiST index, gistsplit.c tries to improve on the split chosen by the opclass-specific pickSplit function by considering penalties for the next column. However, there were two bugs

[COMMITTERS] pgsql: Repair bugs in GiST page splitting code for multi-column indexes

2013-02-07 Thread Tom Lane
Repair bugs in GiST page splitting code for multi-column indexes. When considering a non-last column in a multi-column GiST index, gistsplit.c tries to improve on the split chosen by the opclass-specific pickSplit function by considering penalties for the next column. However, there were two bugs

[COMMITTERS] pgsql: Repair bugs in GiST page splitting code for multi-column indexes

2013-02-07 Thread Tom Lane
Repair bugs in GiST page splitting code for multi-column indexes. When considering a non-last column in a multi-column GiST index, gistsplit.c tries to improve on the split chosen by the opclass-specific pickSplit function by considering penalties for the next column. However, there were two bugs

[COMMITTERS] pgsql: Fix erroneous range-union logic for varlena types in contrib/btr

2013-02-07 Thread Tom Lane
Fix erroneous range-union logic for varlena types in contrib/btree_gist. gbt_var_bin_union() failed to do the right thing when the existing range needed to be widened at both ends rather than just one end. This could result in an invalid index in which keys that are present would not be found by

[COMMITTERS] pgsql: Fix erroneous range-union logic for varlena types in contrib/btr

2013-02-07 Thread Tom Lane
Fix erroneous range-union logic for varlena types in contrib/btree_gist. gbt_var_bin_union() failed to do the right thing when the existing range needed to be widened at both ends rather than just one end. This could result in an invalid index in which keys that are present would not be found by

[COMMITTERS] pgsql: Fix erroneous range-union logic for varlena types in contrib/btr

2013-02-07 Thread Tom Lane
Fix erroneous range-union logic for varlena types in contrib/btree_gist. gbt_var_bin_union() failed to do the right thing when the existing range needed to be widened at both ends rather than just one end. This could result in an invalid index in which keys that are present would not be found by

[COMMITTERS] pgsql: Fix erroneous range-union logic for varlena types in contrib/btr

2013-02-07 Thread Tom Lane
Fix erroneous range-union logic for varlena types in contrib/btree_gist. gbt_var_bin_union() failed to do the right thing when the existing range needed to be widened at both ends rather than just one end. This could result in an invalid index in which keys that are present would not be found by

[COMMITTERS] pgsql: Fix erroneous range-union logic for varlena types in contrib/btr

2013-02-07 Thread Tom Lane
Fix erroneous range-union logic for varlena types in contrib/btree_gist. gbt_var_bin_union() failed to do the right thing when the existing range needed to be widened at both ends rather than just one end. This could result in an invalid index in which keys that are present would not be found by

[COMMITTERS] pgsql: Make contrib/btree_gist's GiST penalty function a bit saner.

2013-02-07 Thread Tom Lane
Make contrib/btree_gist's GiST penalty function a bit saner. The previous coding supposed that the first differing bytes in two varlena datums must have the same sign difference as their overall comparison result. This is obviously bogus for text strings in non-C locales, and probably wrong for n

[COMMITTERS] pgsql: Make contrib/btree_gist's GiST penalty function a bit saner.

2013-02-07 Thread Tom Lane
Make contrib/btree_gist's GiST penalty function a bit saner. The previous coding supposed that the first differing bytes in two varlena datums must have the same sign difference as their overall comparison result. This is obviously bogus for text strings in non-C locales, and probably wrong for n

[COMMITTERS] pgsql: Make contrib/btree_gist's GiST penalty function a bit saner.

2013-02-07 Thread Tom Lane
Make contrib/btree_gist's GiST penalty function a bit saner. The previous coding supposed that the first differing bytes in two varlena datums must have the same sign difference as their overall comparison result. This is obviously bogus for text strings in non-C locales, and probably wrong for n

[COMMITTERS] pgsql: Make contrib/btree_gist's GiST penalty function a bit saner.

2013-02-07 Thread Tom Lane
Make contrib/btree_gist's GiST penalty function a bit saner. The previous coding supposed that the first differing bytes in two varlena datums must have the same sign difference as their overall comparison result. This is obviously bogus for text strings in non-C locales, and probably wrong for n

[COMMITTERS] pgsql: Make contrib/btree_gist's GiST penalty function a bit saner.

2013-02-07 Thread Tom Lane
Make contrib/btree_gist's GiST penalty function a bit saner. The previous coding supposed that the first differing bytes in two varlena datums must have the same sign difference as their overall comparison result. This is obviously bogus for text strings in non-C locales, and probably wrong for n

[COMMITTERS] pgsql: Fix performance issue in EXPLAIN (ANALYZE, TIMING OFF).

2013-02-07 Thread Tom Lane
Fix performance issue in EXPLAIN (ANALYZE, TIMING OFF). Commit af7914c6627bcf0b0ca614e9ce95d3f8056602bf, which added the TIMING option to EXPLAIN, had an oversight: if the TIMING option is disabled then control in InstrStartNode() goes through an elog(DEBUG2) call, which typically does nothing but

[COMMITTERS] pgsql: Fix performance issue in EXPLAIN (ANALYZE, TIMING OFF).

2013-02-07 Thread Tom Lane
Fix performance issue in EXPLAIN (ANALYZE, TIMING OFF). Commit af7914c6627bcf0b0ca614e9ce95d3f8056602bf, which added the TIMING option to EXPLAIN, had an oversight: if the TIMING option is disabled then control in InstrStartNode() goes through an elog(DEBUG2) call, which typically does nothing but

[COMMITTERS] pgsql: doc: Rewrite how to get the source code

2013-02-07 Thread Peter Eisentraut
doc: Rewrite how to get the source code Instead of hardcoding a specific link, give a general link to the download section of the web site. This gives the user more download options and the sysadmins more flexibility. Also, the previously presented link didn't work for devel versions. Branch --