[COMMITTERS] pgsql: Document and clean up gistsplit.c.

2013-02-10 Thread Tom Lane
Document and clean up gistsplit.c. Improve comments, rename some variables and functions, slightly simplify a couple of APIs, in an attempt to make this code readable by people other than its original author. Even though this is essentially just cosmetic, back-patch to all active branches, becaus

[COMMITTERS] pgsql: Document and clean up gistsplit.c.

2013-02-10 Thread Tom Lane
Document and clean up gistsplit.c. Improve comments, rename some variables and functions, slightly simplify a couple of APIs, in an attempt to make this code readable by people other than its original author. Even though this is essentially just cosmetic, back-patch to all active branches, becaus

[COMMITTERS] pgsql: Document and clean up gistsplit.c.

2013-02-10 Thread Tom Lane
Document and clean up gistsplit.c. Improve comments, rename some variables and functions, slightly simplify a couple of APIs, in an attempt to make this code readable by people other than its original author. Even though this is essentially just cosmetic, back-patch to all active branches, becaus

[COMMITTERS] pgsql: Document and clean up gistsplit.c.

2013-02-10 Thread Tom Lane
Document and clean up gistsplit.c. Improve comments, rename some variables and functions, slightly simplify a couple of APIs, in an attempt to make this code readable by people other than its original author. Even though this is essentially just cosmetic, back-patch to all active branches, becaus

[COMMITTERS] pgsql: Document and clean up gistsplit.c.

2013-02-10 Thread Tom Lane
Document and clean up gistsplit.c. Improve comments, rename some variables and functions, slightly simplify a couple of APIs, in an attempt to make this code readable by people other than its original author. Even though this is essentially just cosmetic, back-patch to all active branches, becaus

[COMMITTERS] pgsql: Remove vestigial secondary-split support in gist_box_picksplit()

2013-02-10 Thread Tom Lane
Remove vestigial secondary-split support in gist_box_picksplit(). Not only is this implementation of secondary-split not better than the default implementation in gistsplit.c, it's actually worse. The gistsplit.c code at least looks to see if switching the left and right sides would make a better

[COMMITTERS] pgsql: Remove vestigial secondary-split support in gist_box_picksplit()

2013-02-10 Thread Tom Lane
Remove vestigial secondary-split support in gist_box_picksplit(). Not only is this implementation of secondary-split not better than the default implementation in gistsplit.c, it's actually worse. The gistsplit.c code at least looks to see if switching the left and right sides would make a better

[COMMITTERS] pgsql: Remove useless picksplit-doesn't-support-secondary-split log spa

2013-02-10 Thread Tom Lane
Remove useless picksplit-doesn't-support-secondary-split log spam. This LOG message was put in over five years ago with the evident expectation that we'd make all GiST opclasses support secondary split directly. However, no such thing ever happened, and indeed the number of opclasses supporting i

[COMMITTERS] pgsql: Remove useless picksplit-doesn't-support-secondary-split log spa

2013-02-10 Thread Tom Lane
Remove useless picksplit-doesn't-support-secondary-split log spam. This LOG message was put in over five years ago with the evident expectation that we'd make all GiST opclasses support secondary split directly. However, no such thing ever happened, and indeed the number of opclasses supporting i

[COMMITTERS] pgsql: Remove useless picksplit-doesn't-support-secondary-split log spa

2013-02-10 Thread Tom Lane
Remove useless picksplit-doesn't-support-secondary-split log spam. This LOG message was put in over five years ago with the evident expectation that we'd make all GiST opclasses support secondary split directly. However, no such thing ever happened, and indeed the number of opclasses supporting i

[COMMITTERS] pgsql: Remove useless picksplit-doesn't-support-secondary-split log spa

2013-02-10 Thread Tom Lane
Remove useless picksplit-doesn't-support-secondary-split log spam. This LOG message was put in over five years ago with the evident expectation that we'd make all GiST opclasses support secondary split directly. However, no such thing ever happened, and indeed the number of opclasses supporting i

[COMMITTERS] pgsql: Remove useless picksplit-doesn't-support-secondary-split log spa

2013-02-10 Thread Tom Lane
Remove useless picksplit-doesn't-support-secondary-split log spam. This LOG message was put in over five years ago with the evident expectation that we'd make all GiST opclasses support secondary split directly. However, no such thing ever happened, and indeed the number of opclasses supporting i

[COMMITTERS] pgsql: Further cleanup of gistsplit.c.

2013-02-10 Thread Tom Lane
Further cleanup of gistsplit.c. After further reflection I was unconvinced that the existing coding is guaranteed to return valid union datums in every code path for multi-column indexes. Fix that by forcing a gistunionsubkey() call at the end of the recursion. Having done that, we can remove so

[COMMITTERS] pgsql: Further cleanup of gistsplit.c.

2013-02-10 Thread Tom Lane
Further cleanup of gistsplit.c. After further reflection I was unconvinced that the existing coding is guaranteed to return valid union datums in every code path for multi-column indexes. Fix that by forcing a gistunionsubkey() call at the end of the recursion. Having done that, we can remove so

[COMMITTERS] pgsql: Further cleanup of gistsplit.c.

2013-02-10 Thread Tom Lane
Further cleanup of gistsplit.c. After further reflection I was unconvinced that the existing coding is guaranteed to return valid union datums in every code path for multi-column indexes. Fix that by forcing a gistunionsubkey() call at the end of the recursion. Having done that, we can remove so

[COMMITTERS] pgsql: Further cleanup of gistsplit.c.

2013-02-10 Thread Tom Lane
Further cleanup of gistsplit.c. After further reflection I was unconvinced that the existing coding is guaranteed to return valid union datums in every code path for multi-column indexes. Fix that by forcing a gistunionsubkey() call at the end of the recursion. Having done that, we can remove so

[COMMITTERS] pgsql: Further cleanup of gistsplit.c.

2013-02-10 Thread Tom Lane
Further cleanup of gistsplit.c. After further reflection I was unconvinced that the existing coding is guaranteed to return valid union datums in every code path for multi-column indexes. Fix that by forcing a gistunionsubkey() call at the end of the recursion. Having done that, we can remove so