[COMMITTERS] pgsql: Move pqsignal() to libpgport.

2013-03-17 Thread Tom Lane
Move pqsignal() to libpgport. We had two copies of this function in the backend and libpq, which was already pretty bogus, but it turns out that we need it in some other programs that don't use libpq (such as pg_test_fsync). So put it where it probably should have been all along. The signal-mask

[COMMITTERS] pgsql: Fix inclusions in pg_receivexlog.c.

2013-03-17 Thread Tom Lane
Fix inclusions in pg_receivexlog.c. Apparently this was depending on pqsignal.h for . Not sure why I didn't see the failure on my other machine. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c68b5eff13b97ecaaa87b24406455fafe568aa3f Modified Files -- sr

[COMMITTERS] pgsql: Fix inclusions in pgbench.c.

2013-03-17 Thread Tom Lane
Fix inclusions in pgbench.c. Apparently this was depending on pqsignal.h for . Not sure why I didn't see the failure on my other machine. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8c41cb695cc5f90eee3d2226ad09016381700ca7 Modified Files -- contrib/p

[COMMITTERS] pgsql: Re-include pqsignal() in libpq.

2013-03-17 Thread Tom Lane
Re-include pqsignal() in libpq. We need this in non-ENABLE_THREAD_SAFETY builds, and also to satisfy the exports.txt entry; while it might be a good idea to remove the latter, I'm hesitant to do so except in the context of an intentional ABI break. At least we don't have a separately maintained s

[COMMITTERS] pgsql: initdb needs pqsignal() even on Windows.

2013-03-17 Thread Tom Lane
initdb needs pqsignal() even on Windows. I had thought we weren't using this version of pqsignal() at all on Windows, but that's wrong --- initdb is using it (and coping with the POSIX-ish semantics of bare signal() :-(). So allow the file to be built in WIN32+FRONTEND case, and add it to the MSV

[COMMITTERS] pgsql: Use pqsignal() in contrib programs rather than calling signal(2)

2013-03-17 Thread Tom Lane
Use pqsignal() in contrib programs rather than calling signal(2) directly. The semantics of signal(2) are more variable than one could wish; in particular, on strict-POSIX platforms the signal handler will be reset to SIG_DFL when the signal is delivered. This demonstrably breaks pg_test_fsync's

[COMMITTERS] pgsql: Improve signal-handler lockout mechanism in timeout.c.

2013-03-17 Thread Tom Lane
Improve signal-handler lockout mechanism in timeout.c. Rather than doing a fairly-expensive setitimer() call to prevent interrupts from happening, let's just invent a simple boolean flag that the signal handler is required to check. This is not only faster but considerably more robust than before

[COMMITTERS] pgsql: Extend object-access hook machinery to support post-alter events

2013-03-17 Thread Robert Haas
Extend object-access hook machinery to support post-alter events. This also slightly widens the scope of what we support in terms of post-create events. KaiGai Kohei, with a few changes, mostly to the comments, by me Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0

[COMMITTERS] pgsql: Increase timeout delays in new timeouts isolation test.

2013-03-17 Thread Tom Lane
Increase timeout delays in new timeouts isolation test. Buildfarm member friarbird doesn't like this test as-committed, evidently because it's so slow that the test framework doesn't reliably notice that the backend is waiting before the timeout goes off. (This is not totally surprising, since fr