Incidental cleanup of matviews code.
Move checking for unscannable matviews into ExecOpenScanRelation, which is
a better place for it first because the open relation is already available
(saving a relcache lookup cycle), and second because this eliminates the
problem of telling the difference betw
Dimitri Fontaine writes:
> Tom Lane writes:
>> Yeah, I was just looking at the IfSupported variant. In the structure
>> I just suggested (separate ProcessSlowUtility function), we could make
>> that work by having switch cases for some statements in both functions,
> I've done it the way you pr
pg_dump: Improve message formatting
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/bbb4db4e04d4691d7bc42fa19995aee3e80fe2dc
Modified Files
--
src/bin/pg_dump/pg_dump.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
--
Sent via pgsql-
Fix unsafe event-trigger coding in ProcessUtility().
We mustn't run any of the event-trigger support code when handling
utility statements like START TRANSACTION or ABORT, because that code
may need to refresh event-trigger cache data, which requires being
inside a valid transaction. (This mistak
Editorialize a bit on new ProcessUtility() API.
Choose a saner ordering of parameters (adding a new input param after
the output params seemed a bit random), update the function's header
comment to match reality (cmon folks, is this really that hard?),
get rid of useless and sloppily-defined disti
Dimitri Fontaine writes:
> Tom Lane writes:
>> Yeah, I was just looking at the IfSupported variant. In the structure
>> I just suggested (separate ProcessSlowUtility function), we could make
>> that work by having switch cases for some statements in both functions,
> I've done it the way you pr