[COMMITTERS] pgsql: Remove fixed limit on the number of concurrent AllocateFile() re

2013-06-09 Thread Tom Lane
Remove fixed limit on the number of concurrent AllocateFile() requests. AllocateFile(), AllocateDir(), and some sister routines share a small array for remembering requests, so that the files can be closed on transaction failure. Previously that array had a fixed size, MAX_ALLOCATED_DESCS (32). W

[COMMITTERS] pgsql: Remove fixed limit on the number of concurrent AllocateFile() re

2013-06-09 Thread Tom Lane
Remove fixed limit on the number of concurrent AllocateFile() requests. AllocateFile(), AllocateDir(), and some sister routines share a small array for remembering requests, so that the files can be closed on transaction failure. Previously that array had a fixed size, MAX_ALLOCATED_DESCS (32). W

[COMMITTERS] pgsql: Remove fixed limit on the number of concurrent AllocateFile() re

2013-06-09 Thread Tom Lane
Remove fixed limit on the number of concurrent AllocateFile() requests. AllocateFile(), AllocateDir(), and some sister routines share a small array for remembering requests, so that the files can be closed on transaction failure. Previously that array had a fixed size, MAX_ALLOCATED_DESCS (32). W

[COMMITTERS] pgsql: Remove ALTER DEFAULT PRIVILEGES' requirement of schema CREATE pe

2013-06-09 Thread Tom Lane
Remove ALTER DEFAULT PRIVILEGES' requirement of schema CREATE permissions. Per discussion, this restriction isn't needed for any real security reason, and it seems to confuse people more often than it helps them. It could also result in some database states being unrestorable. So just drop it.

[COMMITTERS] pgsql: Remove ALTER DEFAULT PRIVILEGES' requirement of schema CREATE pe

2013-06-09 Thread Tom Lane
Remove ALTER DEFAULT PRIVILEGES' requirement of schema CREATE permissions. Per discussion, this restriction isn't needed for any real security reason, and it seems to confuse people more often than it helps them. It could also result in some database states being unrestorable. So just drop it.

[COMMITTERS] pgsql: Remove ALTER DEFAULT PRIVILEGES' requirement of schema CREATE pe

2013-06-09 Thread Tom Lane
Remove ALTER DEFAULT PRIVILEGES' requirement of schema CREATE permissions. Per discussion, this restriction isn't needed for any real security reason, and it seems to confuse people more often than it helps them. It could also result in some database states being unrestorable. So just drop it.

[COMMITTERS] pgsql: Remove ALTER DEFAULT PRIVILEGES' requirement of schema CREATE pe

2013-06-09 Thread Tom Lane
Remove ALTER DEFAULT PRIVILEGES' requirement of schema CREATE permissions. Per discussion, this restriction isn't needed for any real security reason, and it seems to confuse people more often than it helps them. It could also result in some database states being unrestorable. So just drop it.

[COMMITTERS] pgsql: Remove unnecessary restrictions about RowExprs in transformAExpr

2013-06-09 Thread Tom Lane
Remove unnecessary restrictions about RowExprs in transformAExprIn(). When the existing code here was written, it made sense to special-case RowExprs because that was the only way that we could handle row comparisons at all. Now that we have record_eq() and arrays of composites, the generic logic

[COMMITTERS] pgsql: Remove unnecessary restrictions about RowExprs in transformAExpr

2013-06-09 Thread Tom Lane
Remove unnecessary restrictions about RowExprs in transformAExprIn(). When the existing code here was written, it made sense to special-case RowExprs because that was the only way that we could handle row comparisons at all. Now that we have record_eq() and arrays of composites, the generic logic

[COMMITTERS] pgsql: Remove unnecessary restrictions about RowExprs in transformAExpr

2013-06-09 Thread Tom Lane
Remove unnecessary restrictions about RowExprs in transformAExprIn(). When the existing code here was written, it made sense to special-case RowExprs because that was the only way that we could handle row comparisons at all. Now that we have record_eq() and arrays of composites, the generic logic

[COMMITTERS] pgsql: Remove unnecessary restrictions about RowExprs in transformAExpr

2013-06-09 Thread Tom Lane
Remove unnecessary restrictions about RowExprs in transformAExprIn(). When the existing code here was written, it made sense to special-case RowExprs because that was the only way that we could handle row comparisons at all. Now that we have record_eq() and arrays of composites, the generic logic

[COMMITTERS] pgsql: Remove unnecessary restrictions about RowExprs in transformAExpr

2013-06-09 Thread Tom Lane
Remove unnecessary restrictions about RowExprs in transformAExprIn(). When the existing code here was written, it made sense to special-case RowExprs because that was the only way that we could handle row comparisons at all. Now that we have record_eq() and arrays of composites, the generic logic

[COMMITTERS] pgsql: Tweak postgres_fdw regression test so autovacuum doesn't change

2013-06-09 Thread Tom Lane
Tweak postgres_fdw regression test so autovacuum doesn't change results. Autovacuum occurring while the test runs could allow some of the inserts to go into recycled space, thus changing the output ordering of later queries. While we could complicate those queries to force sorting of their output

[COMMITTERS] pgsql: Fix ordering of obj id for Rules and EventTriggers in pg_dump.

2013-06-09 Thread Joe Conway
Fix ordering of obj id for Rules and EventTriggers in pg_dump. getSchemaData() must identify extension member objects and mark them as not to be dumped. This must happen after reading all objects that can be direct members of extensions, but before we begin to process table subsidiary objects. Bot

[COMMITTERS] pgsql: Fix ordering of obj id for Rules and EventTriggers in pg_dump.

2013-06-09 Thread Joe Conway
Fix ordering of obj id for Rules and EventTriggers in pg_dump. getSchemaData() must identify extension member objects and mark them as not to be dumped. This must happen after reading all objects that can be direct members of extensions, but before we begin to process table subsidiary objects. Bot

[COMMITTERS] pgsql: Fix ordering of obj id for Rules and EventTriggers in pg_dump.

2013-06-09 Thread Joe Conway
Fix ordering of obj id for Rules and EventTriggers in pg_dump. getSchemaData() must identify extension member objects and mark them as not to be dumped. This must happen after reading all objects that can be direct members of extensions, but before we begin to process table subsidiary objects. Bot