[COMMITTERS] pgsql: During parallel pg_dump, free commands from master

2013-07-14 Thread Stephen Frost
During parallel pg_dump, free commands from master The command strings read by the child processes during parallel pg_dump, after being read and handled, were not being free'd. This patch corrects this relatively minor memory leak. Leak found by the Coverity scanner. Back patch to 9.3 where para

[COMMITTERS] pgsql: During parallel pg_dump, free commands from master

2013-07-14 Thread Stephen Frost
During parallel pg_dump, free commands from master The command strings read by the child processes during parallel pg_dump, after being read and handled, were not being free'd. This patch corrects this relatively minor memory leak. Leak found by the Coverity scanner. Back patch to 9.3 where para

[COMMITTERS] pgsql: pg_receivexlog - Exit on failure to parse

2013-07-14 Thread Stephen Frost
pg_receivexlog - Exit on failure to parse In streamutil.c:GetConnection(), upgrade failure to parse the connection string to an exit(1) instead of simply returning NULL. Most callers already immediately exited, but pg_receivexlog would loop on this case, continually trying to re-parse the connecti

[COMMITTERS] pgsql: pg_receivexlog - Exit on failure to parse

2013-07-14 Thread Stephen Frost
pg_receivexlog - Exit on failure to parse In streamutil.c:GetConnection(), upgrade failure to parse the connection string to an exit(1) instead of simply returning NULL. Most callers already immediately exited, but pg_receivexlog would loop on this case, continually trying to re-parse the connecti

[COMMITTERS] pgsql: pg_isready: Message improvement

2013-07-14 Thread Peter Eisentraut
pg_isready: Message improvement Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/5ab811106b58b06242047ee5dc69001bc983c3a1 Modified Files -- src/bin/scripts/pg_isready.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-com

[COMMITTERS] pgsql: pg_isready: Message improvement

2013-07-14 Thread Peter Eisentraut
pg_isready: Message improvement Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1f75a5f9c1307257c7682f2968a835435fd2b4b2 Modified Files -- src/bin/scripts/pg_isready.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers

[COMMITTERS] pgsql: Ensure 64bit arithmetic when calculating tapeSpace

2013-07-14 Thread Stephen Frost
Ensure 64bit arithmetic when calculating tapeSpace In tuplesort.c:inittapes(), we calculate tapeSpace by first figuring out how many 'tapes' we can use (maxTapes) and then multiplying the result by the tape buffer overhead for each. Unfortunately, when we are on a system with an 8-byte long, we a

[COMMITTERS] pgsql: Ensure 64bit arithmetic when calculating tapeSpace

2013-07-14 Thread Stephen Frost
Ensure 64bit arithmetic when calculating tapeSpace In tuplesort.c:inittapes(), we calculate tapeSpace by first figuring out how many 'tapes' we can use (maxTapes) and then multiplying the result by the tape buffer overhead for each. Unfortunately, when we are on a system with an 8-byte long, we a

[COMMITTERS] pgsql: Ensure 64bit arithmetic when calculating tapeSpace

2013-07-14 Thread Stephen Frost
Ensure 64bit arithmetic when calculating tapeSpace In tuplesort.c:inittapes(), we calculate tapeSpace by first figuring out how many 'tapes' we can use (maxTapes) and then multiplying the result by the tape buffer overhead for each. Unfortunately, when we are on a system with an 8-byte long, we a

[COMMITTERS] pgsql: Ensure 64bit arithmetic when calculating tapeSpace

2013-07-14 Thread Stephen Frost
Ensure 64bit arithmetic when calculating tapeSpace In tuplesort.c:inittapes(), we calculate tapeSpace by first figuring out how many 'tapes' we can use (maxTapes) and then multiplying the result by the tape buffer overhead for each. Unfortunately, when we are on a system with an 8-byte long, we a

[COMMITTERS] pgsql: Ensure 64bit arithmetic when calculating tapeSpace

2013-07-14 Thread Stephen Frost
Ensure 64bit arithmetic when calculating tapeSpace In tuplesort.c:inittapes(), we calculate tapeSpace by first figuring out how many 'tapes' we can use (maxTapes) and then multiplying the result by the tape buffer overhead for each. Unfortunately, when we are on a system with an 8-byte long, we a

[COMMITTERS] pgsql: Ensure 64bit arithmetic when calculating tapeSpace

2013-07-14 Thread Stephen Frost
Ensure 64bit arithmetic when calculating tapeSpace In tuplesort.c:inittapes(), we calculate tapeSpace by first figuring out how many 'tapes' we can use (maxTapes) and then multiplying the result by the tape buffer overhead for each. Unfortunately, when we are on a system with an 8-byte long, we a

[COMMITTERS] pgsql: Be sure to close() file descriptor on error case

2013-07-14 Thread Stephen Frost
Be sure to close() file descriptor on error case In receivelog.c:writeTimeLineHistoryFile(), we were not properly closing the open'd file descriptor in error cases. While this wouldn't matter much if we were about to exit due to such an error, that's not the case with pg_receivexlog as it can be

[COMMITTERS] pgsql: Be sure to close() file descriptor on error case

2013-07-14 Thread Stephen Frost
Be sure to close() file descriptor on error case In receivelog.c:writeTimeLineHistoryFile(), we were not properly closing the open'd file descriptor in error cases. While this wouldn't matter much if we were about to exit due to such an error, that's not the case with pg_receivexlog as it can be

[COMMITTERS] pgsql: Fix resource leak in initdb -X option

2013-07-14 Thread Stephen Frost
Fix resource leak in initdb -X option When creating the symlink for the xlog directory, free the string which stores the link location. Not really an issue but it doesn't hurt to be good about this- prior cleanups have fixed similar issues. Leak found by the Coverity scanner. Not back-patching

[COMMITTERS] pgsql: Document the OVER keyword as being unreserved.

2013-07-14 Thread Noah Misch
Document the OVER keyword as being unreserved. It became so in commit 5893ffa79c03824f34ae3d37f211381fd1c17283. David Fetter, extracted from a larger patch. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/01337d46eb34503b81b989885d0aa3e25da5a96d Modified Files

[COMMITTERS] pgsql: Check version before allocating PQExpBuffer

2013-07-14 Thread Stephen Frost
Check version before allocating PQExpBuffer In pg_dump.c:getEventTriggers, check what major version we are on before calling createPQExpBuffer() to avoid leaking that bit of memory. Leak discovered by the Coverity scanner. Back-patch to 9.3 where support for dumping event triggers was added. Br

[COMMITTERS] pgsql: Check version before allocating PQExpBuffer

2013-07-14 Thread Stephen Frost
Check version before allocating PQExpBuffer In pg_dump.c:getEventTriggers, check what major version we are on before calling createPQExpBuffer() to avoid leaking that bit of memory. Leak discovered by the Coverity scanner. Back-patch to 9.3 where support for dumping event triggers was added. Br