[COMMITTERS] pgsql: Additional regression tests for ALTER OPERATOR FAMILY.

2013-07-23 Thread Robert Haas
Additional regression tests for ALTER OPERATOR FAMILY. Robins Tharakan, reviewed by Szymon Guz Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e6055061c524698918ab0b7a0c51b822c03ef1fa Modified Files -- src/test/regress/expected/alter_generic.out | 175 +

[COMMITTERS] pgsql: Use InvalidSnapshot, now SnapshotNow, as the default snapshot.

2013-07-23 Thread Robert Haas
Use InvalidSnapshot, now SnapshotNow, as the default snapshot. As far as I can determine, there's no code in the core distribution that fails to explicitly set the snapshot of a scan or executor state. If there is any such code, this will probably cause it to seg fault; friendlier suggestions wer

[COMMITTERS] pgsql: Tweak FOR UPDATE/SHARE error message wording (again)

2013-07-23 Thread Alvaro Herrera
Tweak FOR UPDATE/SHARE error message wording (again) In commit 0ac5ad5134 I changed some error messages from "FOR UPDATE/SHARE" to a rather long gobbledygook which nobody liked. Then, in commit cb9b66d31 I changed them again, but the alternative chosen there was deemed suboptimal by Peter Eisentr

[COMMITTERS] pgsql: Tweak FOR UPDATE/SHARE error message wording (again)

2013-07-23 Thread Alvaro Herrera
Tweak FOR UPDATE/SHARE error message wording (again) In commit 0ac5ad5134 I changed some error messages from "FOR UPDATE/SHARE" to a rather long gobbledygook which nobody liked. Then, in commit cb9b66d31 I changed them again, but the alternative chosen there was deemed suboptimal by Peter Eisentr

[COMMITTERS] pgsql: Change post-rewriter representation of dropped columns in joinal

2013-07-23 Thread Tom Lane
Change post-rewriter representation of dropped columns in joinaliasvars. It's possible to drop a column from an input table of a JOIN clause in a view, if that column is nowhere actually referenced in the view. But it will still be there in the JOIN clause's joinaliasvars list. We used to replac

[COMMITTERS] pgsql: Change post-rewriter representation of dropped columns in joinal

2013-07-23 Thread Tom Lane
Change post-rewriter representation of dropped columns in joinaliasvars. It's possible to drop a column from an input table of a JOIN clause in a view, if that column is nowhere actually referenced in the view. But it will still be there in the JOIN clause's joinaliasvars list. We used to replac

[COMMITTERS] pgsql: Change post-rewriter representation of dropped columns in joinal

2013-07-23 Thread Tom Lane
Change post-rewriter representation of dropped columns in joinaliasvars. It's possible to drop a column from an input table of a JOIN clause in a view, if that column is nowhere actually referenced in the view. But it will still be there in the JOIN clause's joinaliasvars list. We used to replac

[COMMITTERS] pgsql: Change post-rewriter representation of dropped columns in joinal

2013-07-23 Thread Tom Lane
Change post-rewriter representation of dropped columns in joinaliasvars. It's possible to drop a column from an input table of a JOIN clause in a view, if that column is nowhere actually referenced in the view. But it will still be there in the JOIN clause's joinaliasvars list. We used to replac

[COMMITTERS] pgsql: Change post-rewriter representation of dropped columns in joinal

2013-07-23 Thread Tom Lane
Change post-rewriter representation of dropped columns in joinaliasvars. It's possible to drop a column from an input table of a JOIN clause in a view, if that column is nowhere actually referenced in the view. But it will still be there in the JOIN clause's joinaliasvars list. We used to replac

[COMMITTERS] pgsql: Change post-rewriter representation of dropped columns in joinal

2013-07-23 Thread Tom Lane
Change post-rewriter representation of dropped columns in joinaliasvars. It's possible to drop a column from an input table of a JOIN clause in a view, if that column is nowhere actually referenced in the view. But it will still be there in the JOIN clause's joinaliasvars list. We used to replac

[COMMITTERS] pgsql: Check for NULL result from strdup

2013-07-23 Thread Alvaro Herrera
Check for NULL result from strdup Per Coverity Scan Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/0883c85334f80ff9cc54607aac508618f871c82c Modified Files -- src/interfaces/libpq/fe-secure.c | 12 +++- 1 file changed, 11 insertions(+), 1

[COMMITTERS] pgsql: Check for NULL result from strdup

2013-07-23 Thread Alvaro Herrera
Check for NULL result from strdup Per Coverity Scan Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/f6a6d204fd33f89f3f472790b58a9992bce1358e Modified Files -- src/interfaces/libpq/fe-secure.c | 12 +++- 1 file changed, 11 insertions(+), 1

[COMMITTERS] pgsql: Check for NULL result from strdup

2013-07-23 Thread Alvaro Herrera
Check for NULL result from strdup Per Coverity Scan Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/15fdf7302a99b0f63394bc49c2528b4731a6627e Modified Files -- src/interfaces/libpq/fe-secure.c | 12 +++- 1 file changed, 11 insertions(+), 1

[COMMITTERS] pgsql: Check for NULL result from strdup

2013-07-23 Thread Alvaro Herrera
Check for NULL result from strdup Per Coverity Scan Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/5ef42547c3c55a0d743ea3fabe165ce3bcc3d3c8 Modified Files -- src/interfaces/libpq/fe-secure.c | 12 +++- 1 file changed, 11 insertions(+), 1

[COMMITTERS] pgsql: Check for NULL result from strdup

2013-07-23 Thread Alvaro Herrera
Check for NULL result from strdup Per Coverity Scan Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/980c24e1e80223ccd70e50d9d64c2b38cf50879e Modified Files -- src/interfaces/libpq/fe-secure.c | 12 +++- 1 file changed, 11 insertions(+), 1

[COMMITTERS] pgsql: Check for NULL result from strdup

2013-07-23 Thread Alvaro Herrera
Check for NULL result from strdup Per Coverity Scan Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bb686c9a865dc15a704e6a96367b3d7bfe79df6f Modified Files -- src/interfaces/libpq/fe-secure.c | 12 +++- 1 file changed, 11 insertions(+), 1 deleti

[COMMITTERS] pgsql: Further hacking on ruleutils' new column-alias-assignment code.

2013-07-23 Thread Tom Lane
Further hacking on ruleutils' new column-alias-assignment code. After further thought about implicit coercions appearing in a joinaliasvars list, I realized that they represent an additional reason why we might need to reference the join output column directly instead of referencing an underlying

[COMMITTERS] pgsql: Further hacking on ruleutils' new column-alias-assignment code.

2013-07-23 Thread Tom Lane
Further hacking on ruleutils' new column-alias-assignment code. After further thought about implicit coercions appearing in a joinaliasvars list, I realized that they represent an additional reason why we might need to reference the join output column directly instead of referencing an underlying

[COMMITTERS] pgsql: Move strip_implicit_coercions() from optimizer to nodeFuncs.c.

2013-07-23 Thread Tom Lane
Move strip_implicit_coercions() from optimizer to nodeFuncs.c. Use of this function has spread into the parser and rewriter, so it seems like time to pull it out of the optimizer and put it into the more central nodeFuncs module. This eliminates the need to #include optimizer/clauses.h in most of

[COMMITTERS] pgsql: Fix booltestsel() for case where we have NULL stats but not MCV

2013-07-23 Thread Tom Lane
Fix booltestsel() for case where we have NULL stats but not MCV stats. In a boolean column that contains mostly nulls, ANALYZE might not find enough non-null values to populate the most-common-values stats, but it would still create a pg_statistic entry with stanullfrac set. The logic in booltests

[COMMITTERS] pgsql: Fix booltestsel() for case where we have NULL stats but not MCV

2013-07-23 Thread Tom Lane
Fix booltestsel() for case where we have NULL stats but not MCV stats. In a boolean column that contains mostly nulls, ANALYZE might not find enough non-null values to populate the most-common-values stats, but it would still create a pg_statistic entry with stanullfrac set. The logic in booltests

[COMMITTERS] pgsql: Fix booltestsel() for case where we have NULL stats but not MCV

2013-07-23 Thread Tom Lane
Fix booltestsel() for case where we have NULL stats but not MCV stats. In a boolean column that contains mostly nulls, ANALYZE might not find enough non-null values to populate the most-common-values stats, but it would still create a pg_statistic entry with stanullfrac set. The logic in booltests

[COMMITTERS] pgsql: Fix booltestsel() for case where we have NULL stats but not MCV

2013-07-23 Thread Tom Lane
Fix booltestsel() for case where we have NULL stats but not MCV stats. In a boolean column that contains mostly nulls, ANALYZE might not find enough non-null values to populate the most-common-values stats, but it would still create a pg_statistic entry with stanullfrac set. The logic in booltests

[COMMITTERS] pgsql: Fix booltestsel() for case where we have NULL stats but not MCV

2013-07-23 Thread Tom Lane
Fix booltestsel() for case where we have NULL stats but not MCV stats. In a boolean column that contains mostly nulls, ANALYZE might not find enough non-null values to populate the most-common-values stats, but it would still create a pg_statistic entry with stanullfrac set. The logic in booltests

[COMMITTERS] pgsql: Fix booltestsel() for case where we have NULL stats but not MCV

2013-07-23 Thread Tom Lane
Fix booltestsel() for case where we have NULL stats but not MCV stats. In a boolean column that contains mostly nulls, ANALYZE might not find enough non-null values to populate the most-common-values stats, but it would still create a pg_statistic entry with stanullfrac set. The logic in booltests