[COMMITTERS] pgsql: Fix setting of right bound at GIN page split.

2013-11-07 Thread Heikki Linnakangas
Fix setting of right bound at GIN page split. Broken by my refactoring. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/fde7172d932bc0c6e62be50293876916efada016 Modified Files -- src/backend/access/gin/gindatapage.c | 14 +++--- 1 file changed,

[COMMITTERS] pgsql: Fix generation of MergeAppend plans for optimized min/max on exp

2013-11-07 Thread Tom Lane
Fix generation of MergeAppend plans for optimized min/max on expressions. Before jamming a desired targetlist into a plan node, one really ought to make sure the plan node can handle projections, and insert a buffering Result plan node if not. planagg.c forgot to do this, which is a hangover from

[COMMITTERS] pgsql: Fix generation of MergeAppend plans for optimized min/max on exp

2013-11-07 Thread Tom Lane
Fix generation of MergeAppend plans for optimized min/max on expressions. Before jamming a desired targetlist into a plan node, one really ought to make sure the plan node can handle projections, and insert a buffering Result plan node if not. planagg.c forgot to do this, which is a hangover from

[COMMITTERS] pgsql: Fix generation of MergeAppend plans for optimized min/max on exp

2013-11-07 Thread Tom Lane
Fix generation of MergeAppend plans for optimized min/max on expressions. Before jamming a desired targetlist into a plan node, one really ought to make sure the plan node can handle projections, and insert a buffering Result plan node if not. planagg.c forgot to do this, which is a hangover from

[COMMITTERS] pgsql: Fix generation of MergeAppend plans for optimized min/max on exp

2013-11-07 Thread Tom Lane
Fix generation of MergeAppend plans for optimized min/max on expressions. Before jamming a desired targetlist into a plan node, one really ought to make sure the plan node can handle projections, and insert a buffering Result plan node if not. planagg.c forgot to do this, which is a hangover from

[COMMITTERS] pgsql: Prevent display of dropped columns in row constraint violation m

2013-11-07 Thread Tom Lane
Prevent display of dropped columns in row constraint violation messages. ExecBuildSlotValueDescription() printed "null" for each dropped column in a row being complained of by ExecConstraints(). This has some sanity in terms of the underlying implementation, but is of course pretty surprising to

[COMMITTERS] pgsql: Prevent display of dropped columns in row constraint violation m

2013-11-07 Thread Tom Lane
Prevent display of dropped columns in row constraint violation messages. ExecBuildSlotValueDescription() printed "null" for each dropped column in a row being complained of by ExecConstraints(). This has some sanity in terms of the underlying implementation, but is of course pretty surprising to

[COMMITTERS] pgsql: Prevent display of dropped columns in row constraint violation m

2013-11-07 Thread Tom Lane
Prevent display of dropped columns in row constraint violation messages. ExecBuildSlotValueDescription() printed "null" for each dropped column in a row being complained of by ExecConstraints(). This has some sanity in terms of the underlying implementation, but is of course pretty surprising to

[COMMITTERS] pgsql: Be more robust when strerror() doesn't give a useful result.

2013-11-07 Thread Tom Lane
Be more robust when strerror() doesn't give a useful result. Back-patch commits 8e68816cc2567642c6fcca4eaac66c25e0ae5ced and 8dace66e0735ca39b779922d02c24ea2686e6521 into the stable branches. Buildfarm testing revealed no great portability surprises, and it seems useful to have this robustness imp

[COMMITTERS] pgsql: Be more robust when strerror() doesn't give a useful result.

2013-11-07 Thread Tom Lane
Be more robust when strerror() doesn't give a useful result. Back-patch commits 8e68816cc2567642c6fcca4eaac66c25e0ae5ced and 8dace66e0735ca39b779922d02c24ea2686e6521 into the stable branches. Buildfarm testing revealed no great portability surprises, and it seems useful to have this robustness imp

[COMMITTERS] pgsql: Be more robust when strerror() doesn't give a useful result.

2013-11-07 Thread Tom Lane
Be more robust when strerror() doesn't give a useful result. Back-patch commits 8e68816cc2567642c6fcca4eaac66c25e0ae5ced and 8dace66e0735ca39b779922d02c24ea2686e6521 into the stable branches. Buildfarm testing revealed no great portability surprises, and it seems useful to have this robustness imp

[COMMITTERS] pgsql: Be more robust when strerror() doesn't give a useful result.

2013-11-07 Thread Tom Lane
Be more robust when strerror() doesn't give a useful result. Back-patch commits 8e68816cc2567642c6fcca4eaac66c25e0ae5ced and 8dace66e0735ca39b779922d02c24ea2686e6521 into the stable branches. Buildfarm testing revealed no great portability surprises, and it seems useful to have this robustness imp

[COMMITTERS] pgsql: Be more robust when strerror() doesn't give a useful result.

2013-11-07 Thread Tom Lane
Be more robust when strerror() doesn't give a useful result. Back-patch commits 8e68816cc2567642c6fcca4eaac66c25e0ae5ced and 8dace66e0735ca39b779922d02c24ea2686e6521 into the stable branches. Buildfarm testing revealed no great portability surprises, and it seems useful to have this robustness imp

[COMMITTERS] pgsql: Silence benign warnings from clang version 3.0-6ubuntu3.

2013-11-07 Thread Kevin Grittner
Silence benign warnings from clang version 3.0-6ubuntu3. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b64b5ccb6a9c6877080b8ef86790e738031089d5 Modified Files -- contrib/pg_standby/pg_standby.c|2 +- src/backend/utils/cache/catcache.c |6

Re: [COMMITTERS] pgsql: Silence benign warnings from clang version 3.0-6ubuntu3.

2013-11-07 Thread Tom Lane
Kevin Grittner writes: > Silence benign warnings from clang version 3.0-6ubuntu3. What in the world is the rationale for these changes in catcache.c? If that really fixes a compiler warning, I would say that that compiler is broken and should not be heeded. regards, tom l

[COMMITTERS] pgsql: Make LOCK_PRINT & PROCLOCK_PRINT expand to ((void) 0) when not i

2013-11-07 Thread Tom Lane
Make LOCK_PRINT & PROCLOCK_PRINT expand to ((void) 0) when not in use. This avoids warnings from more-anal-than-average compilers, and might prevent hidden syntax problems in the future. Andres Freund Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/20803d7881c3865ed