[COMMITTERS] pgsql: Avoid out-of-bounds read in errfinish if error_stack_depth < 0.

2013-12-02 Thread Robert Haas
Avoid out-of-bounds read in errfinish if error_stack_depth < 0. If errordata_stack_depth < 0, we won't find that out and correct the problem until CHECK_STACK_DEPTH() is invoked. In the meantime, elevel will be set based on an invalid read. This is probably harmless in practice, but it seems cle

[COMMITTERS] pgsql: Make NUM_TOCHAR_prepare and NUM_TOCHAR_finish macros declare "le

2013-12-02 Thread Robert Haas
Make NUM_TOCHAR_prepare and NUM_TOCHAR_finish macros declare "len". Remove the variable from the enclosing scopes so that nothing can be relying on it. The net result of this refactoring is that we get rid of a few unnecessary strlen() calls. Original patch from Greg Jaskiewicz, substantially ex

[COMMITTERS] pgsql: Flag mmap implemenation of dynamic shared memory as resize-capab

2013-12-02 Thread Robert Haas
Flag mmap implemenation of dynamic shared memory as resize-capable. Error noted by Heikki Linnakangas Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c6d4b1dd3e9eabca68caea6256ed8bc58dfa0917 Modified Files -- src/backend/storage/ipc/dsm_impl.c |2 +-

[COMMITTERS] pgsql: Increase git_changelog's timestamp_slop from 10 min to 1 day.

2013-12-02 Thread Tom Lane
Increase git_changelog's timestamp_slop from 10 min to 1 day. Many committers seem to now be using a work flow in which back-patched commits are timestamped minutes or even hours apart in different branches (most likely because they commit in one branch before starting work on the next one). git_

[COMMITTERS] pgsql: Improve draft release notes.

2013-12-02 Thread Tom Lane
Improve draft release notes. Per suggestions from Andres Freund. Also fix spelling of Sergey Burladyan's name. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b8b7b723f29e39769486545aef61d71edcadff80 Modified Files -- doc/src/sgml/release-9.3.sgml | 7

[COMMITTERS] pgsql: Fix incomplete backpatch of pg_multixact truncation changes to

2013-12-02 Thread Alvaro Herrera
Fix incomplete backpatch of pg_multixact truncation changes to <= 9.2 The backpatch of a95335b544d9c8377e9dc7a399d8e9a155895f82 to 9.2, 9.1 and 9.0 was incomplete, missing changes to xlog.c, primarily the call to TrimMultiXact(). Testing presumably didn't show a problem without these changes becau

[COMMITTERS] pgsql: Fix incomplete backpatch of pg_multixact truncation changes to

2013-12-02 Thread Alvaro Herrera
Fix incomplete backpatch of pg_multixact truncation changes to <= 9.2 The backpatch of a95335b544d9c8377e9dc7a399d8e9a155895f82 to 9.2, 9.1 and 9.0 was incomplete, missing changes to xlog.c, primarily the call to TrimMultiXact(). Testing presumably didn't show a problem without these changes becau

[COMMITTERS] pgsql: Fix incomplete backpatch of pg_multixact truncation changes to

2013-12-02 Thread Alvaro Herrera
Fix incomplete backpatch of pg_multixact truncation changes to <= 9.2 The backpatch of a95335b544d9c8377e9dc7a399d8e9a155895f82 to 9.2, 9.1 and 9.0 was incomplete, missing changes to xlog.c, primarily the call to TrimMultiXact(). Testing presumably didn't show a problem without these changes becau

Re: [COMMITTERS] pgsql: Improve draft release notes.

2013-12-02 Thread Simon Riggs
>On 2 December 2013 17:17, Tom Lane wrote: > Improve draft release notes. > > Per suggestions from Andres Freund. Also fix spelling of > Sergey Burladyan's name. > > Branch > -- > master > > Details > --- > http://git.postgresql.org/pg/commitdiff/b8b7b723f29e39769486545aef61d71edcadff80 >

Re: [COMMITTERS] pgsql: Improve draft release notes.

2013-12-02 Thread Tom Lane
Simon Riggs writes: > What does this text mean in the SGML? > + That's chunks of the git_changelog output I was working from. I use it as a guide to know which changelog items should go into which back branches. I'll strip the comments after I've finished making all the back-branch notes, but

Re: [COMMITTERS] pgsql: Improve draft release notes.

2013-12-02 Thread Andres Freund
On 2013-12-02 12:44:56 -0500, Tom Lane wrote: > Simon Riggs writes: > > What does this text mean in the SGML? > > > + > > That's chunks of the git_changelog output I was working from. I use it > as a guide to know which changelog items should go into which back > branches. I'll strip the comme

[COMMITTERS] pgsql: doc: update wording of ineffective SET and ABORT commands

2013-12-02 Thread Bruce Momjian
doc: update wording of ineffective SET and ABORT commands Wording by Alvaro Herrera Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/54916b99f7e97aa6e32a4f265527f7517539d802 Modified Files -- doc/src/sgml/ref/abort.sgml |3 ++- doc/src/sgml/

Re: [COMMITTERS] pgsql: Improve draft release notes.

2013-12-02 Thread Tom Lane
Andres Freund writes: > On 2013-12-02 12:44:56 -0500, Tom Lane wrote: >> That's chunks of the git_changelog output I was working from. I use it >> as a guide to know which changelog items should go into which back >> branches. I'll strip the comments after I've finished making all the >> back-br

[COMMITTERS] pgsql: Update release notes for 9.3.2, 9.2.6, 9.1.11, 9.0.15, 8.4.19.

2013-12-02 Thread Tom Lane
Update release notes for 9.3.2, 9.2.6, 9.1.11, 9.0.15, 8.4.19. Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/4993336220996955c41e273bdee4b65895054053 Modified Files -- doc/src/sgml/release-8.4.sgml | 242 +++-- doc/src/sgml/re

[COMMITTERS] pgsql: Update release notes for 9.3.2, 9.2.6, 9.1.11, 9.0.15, 8.4.19.

2013-12-02 Thread Tom Lane
Update release notes for 9.3.2, 9.2.6, 9.1.11, 9.0.15, 8.4.19. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/02bb4bbc66ce2ce7ebfcb27a8a9e002ed9cadd2a Modified Files -- doc/src/sgml/release-8.4.sgml | 201 doc/src/sgml/release-9.

[COMMITTERS] pgsql: Update release notes for 9.3.2, 9.2.6, 9.1.11, 9.0.15, 8.4.19.

2013-12-02 Thread Tom Lane
Update release notes for 9.3.2, 9.2.6, 9.1.11, 9.0.15, 8.4.19. Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/81fb8ff617df7a474a6a9dee9c7edf088fcaf06a Modified Files -- doc/src/sgml/release-8.4.sgml | 242 +++--- doc/sr

[COMMITTERS] pgsql: Update release notes for 9.3.2, 9.2.6, 9.1.11, 9.0.15, 8.4.19.

2013-12-02 Thread Tom Lane
Update release notes for 9.3.2, 9.2.6, 9.1.11, 9.0.15, 8.4.19. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/45f0620fc7ef1e331d77cf93cd72464ecaa4a523 Modified Files -- doc/src/sgml/release-8.4.sgml | 242 +--- doc/src/

[COMMITTERS] pgsql: Update release notes for 9.3.2, 9.2.6, 9.1.11, 9.0.15, 8.4.19.

2013-12-02 Thread Tom Lane
Update release notes for 9.3.2, 9.2.6, 9.1.11, 9.0.15, 8.4.19. Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/9cb631d98443b64a6ac8f5d14ffb95a45a9adad4 Modified Files -- doc/src/sgml/release-8.4.sgml | 242 ++-- doc/src/sgml/release

[COMMITTERS] pgsql: Update release notes for 9.3.2, 9.2.6, 9.1.11, 9.0.15, 8.4.19.

2013-12-02 Thread Tom Lane
Update release notes for 9.3.2, 9.2.6, 9.1.11, 9.0.15, 8.4.19. Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/67f898bd36f1dff19ab6fc741371f0a441b1ed72 Modified Files -- doc/src/sgml/release-8.4.sgml | 242 ++---

[COMMITTERS] pgsql: Stamp 9.2.6.

2013-12-02 Thread Tom Lane
Stamp 9.2.6. Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/8b47c9d413b10a482b21aa9aad9d4f8569de8798 Modified Files -- configure| 18 +- configure.in |2 +- doc/bug.template

[COMMITTERS] pgsql: Stamp 9.3.2.

2013-12-02 Thread Tom Lane
Stamp 9.3.2. Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/05ec931add20f201e579e960b18c1cf770da6ee3 Modified Files -- configure| 18 +- configure.in |2 +- doc/bug.template

[COMMITTERS] pgsql: Stamp 9.1.11.

2013-12-02 Thread Tom Lane
Stamp 9.1.11. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/c53cbb39f880959d7ca04f43943e787ec5cad830 Modified Files -- configure| 18 +- configure.in |2 +- doc/bug.template

[COMMITTERS] pgsql: Stamp 9.0.15.

2013-12-02 Thread Tom Lane
Stamp 9.0.15. Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/ad670a5d7344b81633ab6ac9efd150f5caac97c2 Modified Files -- configure| 18 +- configure.in |2 +- doc/bug.template

[COMMITTERS] pgsql: Stamp 8.4.19.

2013-12-02 Thread Tom Lane
Stamp 8.4.19. Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/be26515fc381c2fa112f57198c2b09e005d094ab Modified Files -- configure| 18 +- configure.in |2 +- doc/bug.template

[COMMITTERS] pgsql: Fix crash in assign_collations_walker for EXISTS with empty SELE

2013-12-02 Thread Tom Lane
Fix crash in assign_collations_walker for EXISTS with empty SELECT list. We (I think I, actually) forgot about this corner case while coding collation resolution. Per bug #8648 from Arjen Nienhuis. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7ab321404c4f721a22e8

[COMMITTERS] pgsql: Fix crash in assign_collations_walker for EXISTS with empty SELE

2013-12-02 Thread Tom Lane
Fix crash in assign_collations_walker for EXISTS with empty SELECT list. We (I think I, actually) forgot about this corner case while coding collation resolution. Per bug #8648 from Arjen Nienhuis. Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/b44ae4893db20

[COMMITTERS] pgsql: Fix crash in assign_collations_walker for EXISTS with empty SELE

2013-12-02 Thread Tom Lane
Fix crash in assign_collations_walker for EXISTS with empty SELECT list. We (I think I, actually) forgot about this corner case while coding collation resolution. Per bug #8648 from Arjen Nienhuis. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/f67b8aeab3a54

[COMMITTERS] pgsql: Fix crash in assign_collations_walker for EXISTS with empty SELE

2013-12-02 Thread Tom Lane
Fix crash in assign_collations_walker for EXISTS with empty SELECT list. We (I think I, actually) forgot about this corner case while coding collation resolution. Per bug #8648 from Arjen Nienhuis. Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/6698782f19d93

[COMMITTERS] pgsql: doc: Refine documentation about recovery command exist status

2013-12-02 Thread Peter Eisentraut
doc: Refine documentation about recovery command exist status Add more documentation about how different exit codes and signals are handled in each case. Reviewed-by: Peter Geoghegan Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/95e3d50539afcdcd4b75b4ac5baa9f8fc0

[COMMITTERS] pgsql: Report exit code from external recovery commands properly

2013-12-02 Thread Peter Eisentraut
Report exit code from external recovery commands properly When an external recovery command such as restore_command or archive_cleanup_command fails, report the exit code properly, distinguishing signals and normal exists, using the existing wait_result_to_str() facility, instead of just reporting