Re: [COMMITTERS] pgsql: Get rid of pg_class.reltoastidxid.

Hi Fujii, Michael, Coverity indicated that there's a problem with this - a quick look confirms that: foreach(lc, indexlist) (*toastidxs)[i++] = index_open(lfirst_oid(lc), lock); /* Fetch the first valid index in list */ for (i = 0; i < *num_indexes; i++) { Relatio

Re: [COMMITTERS] pgsql: Get rid of pg_class.reltoastidxid.

On Wed, Jan 15, 2014 at 9:29 PM, Andres Freund wrote: > Hi Fujii, Michael, > > Coverity indicated that there's a problem with this - a quick look > confirms that: > > foreach(lc, indexlist) > (*toastidxs)[i++] = index_open(lfirst_oid(lc), lock); > > /* Fetch the first valid index i

Re: [COMMITTERS] pgsql: Get rid of pg_class.reltoastidxid.

On Wed, Jan 15, 2014 at 7:54 AM, Michael Paquier wrote: > Oops, good catch. If someone could show up and commit the attached to > master and REL9_3_STABLE... Hmm, I don't see an attachment. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via

Re: [COMMITTERS] pgsql: Get rid of pg_class.reltoastidxid.

On Wed, Jan 15, 2014 at 10:02 PM, Robert Haas wrote: > On Wed, Jan 15, 2014 at 7:54 AM, Michael Paquier > wrote: >> Oops, good catch. If someone could show up and commit the attached to >> master and REL9_3_STABLE... > > Hmm, I don't see an attachment. Re-oops. Sorry I forgot it. -- Michael diff

[COMMITTERS] pgsql: Fix compiler warning: Size isn't 64 bits on 32 bit platforms.

Fix compiler warning: Size isn't 64 bits on 32 bit platforms. Report by Peter Eisentraut. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/be361ef2a0b58ce1f3faff7ccabe174e20d50497 Modified Files -- contrib/test_shm_mq/setup.c |2 +- 1 file changed, 1 i

[COMMITTERS] pgsql: Fix compiler warning.

Fix compiler warning. Kevin Gritter reports that his compiler complains about inq and outq being possibly-uninitialized at the point where they are passed to shm_mq_attach(). They are initialized by the call to setup_dynamic_shared_memory, but apparently his compiler is inlining that function and

[COMMITTERS] pgsql: test_shm_mq: Fix checks for negative queue size.

test_shm_mq: Fix checks for negative queue size. Noted while addressing compiler warnings pointed out on pgsql-hackers. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b5763cedde2541a6629f64cccf77e37b21348714 Modified Files -- contrib/test_shm_mq/setup.c

[COMMITTERS] pgsql: Fix missing parentheses resulting in wrong order of dereference.

Fix missing parentheses resulting in wrong order of dereference. This could result in referencing uninitialized memory. Michael Paquier, in response to a complaint from Andres Freund Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d02c0ddb152978980ea17f9214c7ac734e4

Re: [COMMITTERS] pgsql: Get rid of pg_class.reltoastidxid.

On Wed, Jan 15, 2014 at 8:14 AM, Michael Paquier wrote: > On Wed, Jan 15, 2014 at 10:02 PM, Robert Haas wrote: >> On Wed, Jan 15, 2014 at 7:54 AM, Michael Paquier >> wrote: >>> Oops, good catch. If someone could show up and commit the attached to >>> master and REL9_3_STABLE... >> >> Hmm, I don'

[COMMITTERS] pgsql: Logging running transactions every 15 seconds.

Logging running transactions every 15 seconds. Previously, we did this just once per checkpoint, but that could make Hot Standby take a long time to initialize. To avoid busying an otherwise-idle system, we don't do this if no WAL has been written since we did it last. Andres Freund Branch

[COMMITTERS] pgsql: test_shm_mq: Try again to fix compiler warning.

test_shm_mq: Try again to fix compiler warning. Per complaints from Andres Freund and Tom Lane. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b1365ff7a811760c56ae88a1e819b2529fb5452b Modified Files -- contrib/test_shm_mq/setup.c |2 +- 1 file change

[COMMITTERS] pgsql: Fix whitespace

Fix whitespace Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a687ec7d5bf11fd16a68ffba6185aabe9100f98f Modified Files -- contrib/test_shm_mq/setup.c |2 +- contrib/test_shm_mq/worker.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --