[COMMITTERS] pgsql: Cygwin build fixes.

2014-02-11 Thread Tom Lane
Cygwin build fixes. Get rid of use of dlltool for linking the main postgres executable. dlltool is obsolete and we'd prefer to stop depending on it. Also, include $(LDAP_LIBS_FE) in $(libpq_pgport). (It's not clear that this is really needed, or why it's not a linker bug if it is needed. But rep

[COMMITTERS] pgsql: Get rid of use of dlltool in Mingw builds.

2014-02-11 Thread Tom Lane
Get rid of use of dlltool in Mingw builds. We are almost completely out of the dlltool game, if this works. Hiroshi Inoue Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/846e91e0223cf9f2821c3ad4dfbb929cb027 Modified Files -- src/Makefile.shlib

[COMMITTERS] pgsql: Flush a stray definition of $(DLLTOOL).

2014-02-11 Thread Tom Lane
Flush a stray definition of $(DLLTOOL). Even if this is needed, it'd be configure's responsibility to set it. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7a98d323df2d0839ebb4aab2004c626b64343b76 Modified Files -- src/makefiles/Makefile.cygwin |4

[COMMITTERS] pgsql: Make gendef.pl emit DATA annotations for global variables.

2014-02-11 Thread Tom Lane
Make gendef.pl emit DATA annotations for global variables. This should make the MSVC build act more like builds for other platforms, i.e. backend global variables will be automatically available to loadable libraries without need for explicit PGDLLIMPORT marking. Craig Ringer Branch -- maste

Re: [COMMITTERS] pgsql: Minor pg_dump improvements

2014-02-11 Thread Andres Freund
On 2014-02-09 02:29:25 +, Stephen Frost wrote: > Minor pg_dump improvements > > Improve pg_dump by checking results on various fgetc() calls which > previously were unchecked, ditto for ftello. Also clean up a couple > of very minor memory leaks by waiting to allocate structures until > after

Re: [COMMITTERS] pgsql: Assert(IsTransactionState()) in RelationIdGetRelation().

2014-02-11 Thread Andres Freund
On 2014-02-06 16:28:23 +, Tom Lane wrote: > Assert(IsTransactionState()) in RelationIdGetRelation(). > > Commit 42c80c696e9c8323841180029cc62741c21bd356 added an > Assert(IsTransactionState()) in SearchCatCache(), to catch > any code that thought it could do a catcache lookup outside > transact

Re: [COMMITTERS] pgsql: Assert(IsTransactionState()) in RelationIdGetRelation().

2014-02-11 Thread Tom Lane
Andres Freund writes: > On 2014-02-06 16:28:23 +, Tom Lane wrote: >> Assert(IsTransactionState()) in RelationIdGetRelation(). > Hm, I am not sure if it works this way. In a patched postgres I just > got: > #2 0x008b4b27 in ExceptionalCondition (conditionName=0xa90a78 > "!(IsTransact

Re: [COMMITTERS] pgsql: Assert(IsTransactionState()) in RelationIdGetRelation().

2014-02-11 Thread Andres Freund
On 2014-02-11 14:45:00 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2014-02-06 16:28:23 +, Tom Lane wrote: > >> Assert(IsTransactionState()) in RelationIdGetRelation(). > > > Hm, I am not sure if it works this way. In a patched postgres I just > > got: > > #2 0x008b4b27 in E