Re: [COMMITTERS] pgsql: Use --disable-auto-import linker switch in Mingw builds, too.

2014-02-15 Thread Andrew Dunstan
On 02/14/2014 08:18 PM, Andres Freund wrote: On 2014-02-14 19:44:11 -0500, Andrew Dunstan wrote: On 02/12/2014 12:04 PM, Tom Lane wrote: Use --disable-auto-import linker switch in Mingw builds, too. This is evidently the default on buildfarm member narwhal, but that is a pretty ancient Mingw

Re: [COMMITTERS] pgsql: Use --disable-auto-import linker switch in Mingw builds, too.

2014-02-15 Thread Andres Freund
On 2014-02-15 09:47:08 -0500, Andrew Dunstan wrote: > However, the build now fails like this: >pg_buffercache_pages.o: In function `pg_buffercache_pages': > > c:/MinGW/msys/1.0/home/pgrunner/bf/root/HEAD/pgsql.6024/../pgsql/contrib/pg_buffercache/pg_buffercache_pages.c:119: >undefined r

Re: [COMMITTERS] pgsql: Use --disable-auto-import linker switch in Mingw builds, too.

2014-02-15 Thread Andrew Dunstan
On 02/15/2014 09:49 AM, Andres Freund wrote: On 2014-02-15 09:47:08 -0500, Andrew Dunstan wrote: However, the build now fails like this: pg_buffercache_pages.o: In function `pg_buffercache_pages': c:/MinGW/msys/1.0/home/pgrunner/bf/root/HEAD/pgsql.6024/../pgsql/contrib/pg_buffercache/p

Re: [COMMITTERS] pgsql: Use --disable-auto-import linker switch in Mingw builds, too.

2014-02-15 Thread Andres Freund
On 2014-02-15 10:02:39 -0500, Andrew Dunstan wrote: > > On 02/15/2014 09:49 AM, Andres Freund wrote: > >On 2014-02-15 09:47:08 -0500, Andrew Dunstan wrote: > >>However, the build now fails like this: > >>pg_buffercache_pages.o: In function `pg_buffercache_pages': > >> > >> c:/MinGW/msys/1.

Re: [COMMITTERS] pgsql: Use --disable-auto-import linker switch in Mingw builds, too.

2014-02-15 Thread Tom Lane
Andrew Dunstan writes: > However, the build now fails like this: > pg_buffercache_pages.o: In function `pg_buffercache_pages': > > c:/MinGW/msys/1.0/home/pgrunner/bf/root/HEAD/pgsql.6024/../pgsql/contrib/pg_buffercache/pg_buffercache_pages.c:119: > undefined reference to `MainLWLockA

Re: [COMMITTERS] pgsql: Use --disable-auto-import linker switch in Mingw builds, too.

2014-02-15 Thread Andrew Dunstan
On 02/15/2014 10:12 AM, Tom Lane wrote: Andrew Dunstan writes: However, the build now fails like this: pg_buffercache_pages.o: In function `pg_buffercache_pages': c:/MinGW/msys/1.0/home/pgrunner/bf/root/HEAD/pgsql.6024/../pgsql/contrib/pg_buffercache/pg_buffercache_pages.c:119:

[COMMITTERS] pgsql: Remove use of sscanf in pg_upgrade, and add C comment to pg_dump

2014-02-15 Thread Bruce Momjian
Remove use of sscanf in pg_upgrade, and add C comment to pg_dump Per report from Jackie Chang Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/32be1c8e900b89a89ec5e3a064c6b6010869d062 Modified Files -- contrib/pg_upgrade/option.c |5 +++-- sr

[COMMITTERS] pgsql: Centralize getopt-related declarations in a new header file pg_g

2014-02-15 Thread Tom Lane
Centralize getopt-related declarations in a new header file pg_getopt.h. We used to have externs for getopt() and its API variables scattered all over the place. Now that we find we're going to need to tweak the variable declarations for Cygwin, it seems like a good idea to have just one place to

[COMMITTERS] pgsql: Fix unportable coding in DetermineSleepTime().

2014-02-15 Thread Tom Lane
Fix unportable coding in DetermineSleepTime(). We should not assume that struct timeval.tv_sec is a long, because it ain't necessarily. (POSIX says that it's a time_t, which might well be 64 bits now or in the future; or for that matter might be 32 bits on machines with 64-bit longs.) Per buildf

[COMMITTERS] pgsql: Fix unportable coding in DetermineSleepTime().

2014-02-15 Thread Tom Lane
Fix unportable coding in DetermineSleepTime(). We should not assume that struct timeval.tv_sec is a long, because it ain't necessarily. (POSIX says that it's a time_t, which might well be 64 bits now or in the future; or for that matter might be 32 bits on machines with 64-bit longs.) Per buildf

[COMMITTERS] pgsql: Fix unportable coding in BackgroundWorkerStateChange().

2014-02-15 Thread Tom Lane
Fix unportable coding in BackgroundWorkerStateChange(). PIDs aren't necessarily ints; our usual practice for printing them is to explicitly cast to long. Per buildfarm member rover_firefly. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/643f75ca9b5b3883395576aaf524

[COMMITTERS] pgsql: First-draft release notes for 9.3.3.

2014-02-15 Thread Tom Lane
First-draft release notes for 9.3.3. As usual, the release notes for older branches will be made by cutting these down, but put them up for community review first. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cefd3e507d7cc402225e5da100d05dcafb90c0bd Modified File