[COMMITTERS] pgsql: Make it easy to detach completely from shared memory.

2014-03-18 Thread Robert Haas
Make it easy to detach completely from shared memory. The new function dsm_detach_all() can be used either by postmaster children that don't wish to take any risk of accidentally corrupting shared memory; or by forked children of regular backends with the same need. This patch also updates the po

[COMMITTERS] pgsql: Fix help message and document in pg_receivexlog.

2014-03-18 Thread Fujii Masao
Fix help message and document in pg_receivexlog. Add SLOTNAME placeholder to --slot option in help message and document. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e726e59dc4845fff1e0e5849ef8d0bae958002fd Modified Files -- doc/src/sgml/ref/pg_receiv

[COMMITTERS] pgsql: Fix pg_dumpall option parsing: -i doesn't take an argument.

2014-03-18 Thread Tom Lane
Fix pg_dumpall option parsing: -i doesn't take an argument. This used to work properly, but got fat-fingered in commit 3dee636e0404885d07885d41c0d70e50c784f324. Per bug #9620 from Nicolas Payart. Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/63817f86b57fc3d

[COMMITTERS] pgsql: Fix pg_dumpall option parsing: -i doesn't take an argument.

2014-03-18 Thread Tom Lane
Fix pg_dumpall option parsing: -i doesn't take an argument. This used to work properly, but got fat-fingered in commit 3dee636e0404885d07885d41c0d70e50c784f324. Per bug #9620 from Nicolas Payart. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/19f2d6cdae2bfa97c2ce8a

[COMMITTERS] pgsql: Improve shm_mq portability around MAXIMUM_ALIGNOF and sizeof(Siz

2014-03-18 Thread Robert Haas
Improve shm_mq portability around MAXIMUM_ALIGNOF and sizeof(Size). Revise the original decision to expose a uint64-based interface and use Size everywhere possible. Avoid assuming that MAXIMUM_ALIGNOF is 8, or making any assumption about the relationship between that value and sizeof(Size). If

[COMMITTERS] pgsql: Fix relcache reference leak in refresh_by_match_merge().

2014-03-18 Thread Tom Lane
Fix relcache reference leak in refresh_by_match_merge(). One path through the loop over indexes forgot to do index_close(). Rather than adding a fourth call, restructure slightly so that there's only one. In passing, get rid of an unnecessary syscache lookup: the pg_index struct for the index is

[COMMITTERS] pgsql: Rewrite comment for shm_mq_receive_bytes.

2014-03-18 Thread Robert Haas
Rewrite comment for shm_mq_receive_bytes. The comment and the code diverged at some point before the initial commit of this feature, and I failed to notice. Noted by Tom Lane. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/250f8a7bbe83a7dbc9618c0a506f7170ab610e4b

[COMMITTERS] pgsql: Add pg_recvlogical, a tool to receive data logical decoding data

2014-03-18 Thread Robert Haas
Add pg_recvlogical, a tool to receive data logical decoding data. This is fairly basic at the moment, but it's at least useful for testing and debugging, and possibly more. Andres Freund Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8bdd12bbf093c846c9383c205e363d6

Re: [COMMITTERS] pgsql: Add pg_recvlogical, a tool to receive data logical decoding data

2014-03-18 Thread Heikki Linnakangas
On 03/18/2014 06:26 PM, Robert Haas wrote: Add pg_recvlogical, a tool to receive data logical decoding data. This is fairly basic at the moment, but it's at least useful for testing and debugging, and possibly more. Andres Freund Branch -- master Details --- http://git.postgresql.org/

Re: [COMMITTERS] pgsql: Add pg_recvlogical, a tool to receive data logical decoding data

2014-03-18 Thread Andres Freund
On 2014-03-18 18:51:29 +0200, Heikki Linnakangas wrote: > I have a few questions about this: > > 1. Why is this in src/bin/pg_basebackup? As far as I can see, this has > nothing to do with taking base backups. I guess one could say the same thing > about pg_receivexlog, but that one is at least so

[COMMITTERS] pgsql: Documentation for logical decoding.

2014-03-18 Thread Robert Haas
Documentation for logical decoding. Craig Ringer, Andres Freund, Christian Kruse, with edits by me. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/49c0864d7ef5227faa24f903902db90e5c9d5d69 Modified Files -- doc/src/sgml/catalogs.sgml | 27 +-

[COMMITTERS] pgsql: test_shm_mq: Use Size rather than uint64.

2014-03-18 Thread Robert Haas
test_shm_mq: Use Size rather than uint64. Commit 3bd261ca18c67eafe18088e58fab511e3b965418 updated the API but neglected to make the corresponding edits here. Per Tom Lane and the buildfarm. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c676ac0f3fc87911588ca8e5f924

Re: [COMMITTERS] pgsql: Add pg_recvlogical, a tool to receive data logical decoding data

2014-03-18 Thread Andres Freund
Hi, On 2014-03-18 16:26:19 +, Robert Haas wrote: > Add pg_recvlogical, a tool to receive data logical decoding data. > > This is fairly basic at the moment, but it's at least useful for > testing and debugging, and possibly more. Inspecting the output by different compilers shows a screwup o

Re: [COMMITTERS] pgsql: Documentation for logical decoding.

2014-03-18 Thread Thom Brown
On 18 March 2014 17:21, Robert Haas wrote: > Documentation for logical decoding. > > Craig Ringer, Andres Freund, Christian Kruse, with edits by me. In doc/src/sgml/logicaldecoding.sgml: s/demonstartes/demonstrates/ s/ot at least 1/to at least 1/ In this example: +postgres=# SELECT * FROM pg

Re: [COMMITTERS] pgsql: Documentation for logical decoding.

2014-03-18 Thread Andres Freund
On 2014-03-18 18:12:25 +, Thom Brown wrote: > I'd have put this in a patch, but I don't know if the output in the > example is wrong, or just dependent on environmental factors. It's out of date, it should be integer now, so please submit a bug. I wonder if we should change stuff that types a

Re: [COMMITTERS] pgsql: Documentation for logical decoding.

2014-03-18 Thread Thom Brown
On 18 March 2014 18:16, Andres Freund wrote: > On 2014-03-18 18:12:25 +, Thom Brown wrote: >> I'd have put this in a patch, but I don't know if the output in the >> example is wrong, or just dependent on environmental factors. > > It's out of date, it should be integer now, so please submit a

[COMMITTERS] pgsql: Fix some remaining int64 vestiges in contrib/test_shm_mq.

2014-03-18 Thread Tom Lane
Fix some remaining int64 vestiges in contrib/test_shm_mq. Andres Freund and Tom Lane Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b6ec7c92ac7ab6223b3c45dc554efffd1953758f Modified Files -- contrib/test_shm_mq/setup.c | 15 ++- contrib/tes

[COMMITTERS] pgsql: Make the handling of interrupted B-tree page splits more robust.

2014-03-18 Thread Heikki Linnakangas
Make the handling of interrupted B-tree page splits more robust. Splitting a page consists of two separate steps: splitting the child page, and inserting the downlink for the new right page to the parent. Previously, we handled the case that you crash in between those steps with a cleanup routine

[COMMITTERS] pgsql: Fix uninitialized variable.

2014-03-18 Thread Robert Haas
Fix uninitialized variable. Report from Andres Freund, but not his fix. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a3b30d4cfe5f3ae718fd2cc6aa05b7707cac88dd Modified Files -- src/bin/pg_basebackup/pg_recvlogical.c |2 +- 1 file changed, 1 insertio

[COMMITTERS] pgsql: Logical decoding documentation corrections.

2014-03-18 Thread Robert Haas
Logical decoding documentation corrections. Thom Brown Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3ee4fcfc63452a1ab5586b2d4cb4b6908d1badff Modified Files -- doc/src/sgml/logicaldecoding.sgml | 28 ++-- 1 file changed, 14 ins

[COMMITTERS] pgsql: Fix misc typos in comments.

2014-03-18 Thread Heikki Linnakangas
Fix misc typos in comments. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1d3b258cbe4aedfb49c92c28b9cbd7c18d277e04 Modified Files -- src/bin/pg_basebackup/pg_recvlogical.c |6 +++--- src/test/regress/expected/replica_identity.out |2 +- sr

[COMMITTERS] pgsql: Remove rm_safe_restartpoint machinery.

2014-03-18 Thread Heikki Linnakangas
Remove rm_safe_restartpoint machinery. It is no longer used, none of the resource managers have multi-record actions that would make it unsafe to perform a restartpoint. Also don't allow rm_cleanup to write WAL records, it's also no longer required. Move the call to rm_cleanup routines to make it

Re: [COMMITTERS] pgsql: Remove rm_safe_restartpoint machinery.

2014-03-18 Thread Andres Freund
Hi, On 2014-03-18 20:11:37 +, Heikki Linnakangas wrote: > Remove rm_safe_restartpoint machinery. Neato, but I think you forgot to update contrib/pg_xlogdump. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, T

[COMMITTERS] pgsql: Fix compilation of pg_xlogdump, now that rm_safe_restartpoint is

2014-03-18 Thread Heikki Linnakangas
Fix compilation of pg_xlogdump, now that rm_safe_restartpoint is no more. Oops. Pointed out by Andres Freund. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/033dc1c92cf018d396e983d425b821dda420cfff Modified Files -- contrib/pg_xlogdump/rmgrdesc.c |2

Re: [COMMITTERS] pgsql: Remove rm_safe_restartpoint machinery.

2014-03-18 Thread Heikki Linnakangas
On 03/18/2014 10:19 PM, Andres Freund wrote: On 2014-03-18 20:11:37 +, Heikki Linnakangas wrote: Remove rm_safe_restartpoint machinery. Neato, but I think you forgot to update contrib/pg_xlogdump. Oops, indeed. Fixed, thanks! - Heikki -- Sent via pgsql-committers mailing list (pgsql-c