Re: [COMMITTERS] pgsql: Allow opclasses to provide tri-valued GIN consistent functions.

2014-03-22 Thread Andrew Dunstan
On 03/21/2014 06:43 PM, Heikki Linnakangas wrote: On 03/21/2014 10:47 PM, Andres Freund wrote: On 2014-03-21 17:37:35 -0400, Tom Lane wrote: Andres Freund writes: I think the GinLogicValueEnum is supposed to be an enum's name, not a variable name, right? I think the whole thing is too cute

[COMMITTERS] pgsql: Improve comments about AfterTriggerBeginQuery() query level usag

2014-03-22 Thread Noah Misch
Improve comments about AfterTriggerBeginQuery() query level usage. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6115480c543c0141011a99db78987ad13540be59 Modified Files -- src/backend/commands/trigger.c | 16 +++- 1 file changed, 11 inserti

[COMMITTERS] pgsql: Address ccvalid/ccnoinherit in TupleDesc support functions.

2014-03-22 Thread Noah Misch
Address ccvalid/ccnoinherit in TupleDesc support functions. equalTupleDescs() neglected both of these ConstrCheck fields, and CreateTupleDescCopyConstr() neglected ccnoinherit. At this time, the only known behavior defect resulting from these omissions is constraint exclusion disregarding a CHECK

[COMMITTERS] pgsql: Offer triggers on foreign tables.

2014-03-22 Thread Noah Misch
Offer triggers on foreign tables. This covers all the SQL-standard trigger types supported for regular tables; it does not cover constraint triggers. The approach for acquiring the old row mirrors that for view INSTEAD OF triggers. For AFTER ROW triggers, we spool the foreign tuples to a tuplest

[COMMITTERS] pgsql: Address ccvalid/ccnoinherit in TupleDesc support functions.

2014-03-22 Thread Noah Misch
Address ccvalid/ccnoinherit in TupleDesc support functions. equalTupleDescs() neglected both of these ConstrCheck fields, and CreateTupleDescCopyConstr() neglected ccnoinherit. At this time, the only known behavior defect resulting from these omissions is constraint exclusion disregarding a CHECK

[COMMITTERS] pgsql: Address ccvalid/ccnoinherit in TupleDesc support functions.

2014-03-22 Thread Noah Misch
Address ccvalid/ccnoinherit in TupleDesc support functions. equalTupleDescs() neglected both of these ConstrCheck fields, and CreateTupleDescCopyConstr() neglected ccnoinherit. At this time, the only known behavior defect resulting from these omissions is constraint exclusion disregarding a CHECK