[COMMITTERS] pgsql: Fix 'recheck' flag in tsquery's GIN tri-consistent function.

2014-03-26 Thread Heikki Linnakangas
Fix 'recheck' flag in tsquery's GIN tri-consistent function. It needs to be initialized, like in the boolean gin_tsquery_consistent version. Peter Geoghegan. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/86cf41ed27f6e822a8505ecffb42f2662662 Modified Files ---

[COMMITTERS] pgsql: Add -f/--follow option to pg_xlogdump.

2014-03-26 Thread Heikki Linnakangas
Add -f/--follow option to pg_xlogdump. This is useful for seeing what WAL records are inserted in real-time, by pointing pg_xlogdump to a live server. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ce9bb92f8fb8d25cf00ec939797ffdb5930fb792 Modified Files ---

Re: [COMMITTERS] pgsql: Add -f/--follow option to pg_xlogdump.

2014-03-26 Thread Andrew Dunstan
On 03/26/2014 07:50 AM, Heikki Linnakangas wrote: Add -f/--follow option to pg_xlogdump. This is useful for seeing what WAL records are inserted in real-time, by pointing pg_xlogdump to a live server. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ce9bb92f8fb8d25

[COMMITTERS] pgsql: Use pg_usleep() instead of plain sleep(), to fix Windows build

2014-03-26 Thread Heikki Linnakangas
Use pg_usleep() instead of plain sleep(), to fix Windows build Per buildfarm. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/28475f8e58bd5da2b44a42203665a543f335c6a3 Modified Files -- contrib/pg_xlogdump/pg_xlogdump.c |2 +- 1 file changed, 1 inserti

Re: [COMMITTERS] pgsql: Add -f/--follow option to pg_xlogdump.

2014-03-26 Thread Heikki Linnakangas
On 03/26/2014 03:15 PM, Andrew Dunstan wrote: On 03/26/2014 07:50 AM, Heikki Linnakangas wrote: Add -f/--follow option to pg_xlogdump. This is useful for seeing what WAL records are inserted in real-time, by pointing pg_xlogdump to a live server. Branch -- master Details --- http://g

Re: [COMMITTERS] pgsql: Add -f/--follow option to pg_xlogdump.

2014-03-26 Thread Andrew Dunstan
On 03/26/2014 09:27 AM, Heikki Linnakangas wrote: On 03/26/2014 03:15 PM, Andrew Dunstan wrote: On 03/26/2014 07:50 AM, Heikki Linnakangas wrote: Add -f/--follow option to pg_xlogdump. This is useful for seeing what WAL records are inserted in real-time, by pointing pg_xlogdump to a live s

Re: [COMMITTERS] pgsql: Add -f/--follow option to pg_xlogdump.

2014-03-26 Thread Michael Paquier
On Wed, Mar 26, 2014 at 10:42 PM, Andrew Dunstan wrote: > Which is another way of doing it, I guess. I'm not sure why the usual way > wasn't adopted there. Perhaps it was simply forgotten, it is done like that since pg_upgrade a couple of years back with c2e9b2f. -- Michael -- Sent via pgsql-c

[COMMITTERS] pgsql: Cleanup around json_to_record/json_to_recordset

2014-03-26 Thread Andrew Dunstan
Cleanup around json_to_record/json_to_recordset Set function parameter names and defaults. Add jsonb versions (which the code already provided for so the actual new code is trivial). Add jsonb regression tests and docs. Bump catalog version (which I apparently forgot to do when jsonb was committe

[COMMITTERS] pgsql: pg_upgrade: use pg_usleep(); remove Windows workaround

2014-03-26 Thread Bruce Momjian
pg_upgrade: use pg_usleep(); remove Windows workaround Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ba08155bd5e6dffe5cd4bda9e7d6616b5e20d564 Modified Files -- contrib/pg_upgrade/exec.c |2 +- contrib/pg_upgrade/pg_upgrade.h |1 - 2 files c

Re: [COMMITTERS] pgsql: Add -f/--follow option to pg_xlogdump.

2014-03-26 Thread Bruce Momjian
On Wed, Mar 26, 2014 at 10:54:04PM +0900, Michael Paquier wrote: > On Wed, Mar 26, 2014 at 10:42 PM, Andrew Dunstan wrote: > > Which is another way of doing it, I guess. I'm not sure why the usual way > > wasn't adopted there. > Perhaps it was simply forgotten, it is done like that since pg_upgrad

[COMMITTERS] pgsql: psql: update "replica identity" display for \d+

2014-03-26 Thread Bruce Momjian
psql: update "replica identity" display for \d+ Display "replica identity" only for \d plus mode, exclude system schema objects, and display all possible values, not just non-default, non-index ones. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b69c4e65bea92ef617

[COMMITTERS] pgsql: Pass more than the first XLogRecData entry to rm_desc, with WAL_

2014-03-26 Thread Heikki Linnakangas
Pass more than the first XLogRecData entry to rm_desc, with WAL_DEBUG. If you compile with WAL_DEBUG and enable it with wal_debug=on, we used to only pass the first XLogRecData entry to the rm_desc routine. I think the original assumprion was that the first XLogRecData entry contains all the neces

[COMMITTERS] pgsql: Fix refcounting bug in PLy_modify_tuple().

2014-03-26 Thread Tom Lane
Fix refcounting bug in PLy_modify_tuple(). We must increment the refcount on "plntup" as soon as we have the reference, not sometime later. Otherwise, if an error is thrown in between, the Py_XDECREF(plntup) call in the PG_CATCH block removes a refcount we didn't add, allowing the object to be fr

[COMMITTERS] pgsql: Fix refcounting bug in PLy_modify_tuple().

2014-03-26 Thread Tom Lane
Fix refcounting bug in PLy_modify_tuple(). We must increment the refcount on "plntup" as soon as we have the reference, not sometime later. Otherwise, if an error is thrown in between, the Py_XDECREF(plntup) call in the PG_CATCH block removes a refcount we didn't add, allowing the object to be fr

[COMMITTERS] pgsql: Fix refcounting bug in PLy_modify_tuple().

2014-03-26 Thread Tom Lane
Fix refcounting bug in PLy_modify_tuple(). We must increment the refcount on "plntup" as soon as we have the reference, not sometime later. Otherwise, if an error is thrown in between, the Py_XDECREF(plntup) call in the PG_CATCH block removes a refcount we didn't add, allowing the object to be fr

[COMMITTERS] pgsql: Fix refcounting bug in PLy_modify_tuple().

2014-03-26 Thread Tom Lane
Fix refcounting bug in PLy_modify_tuple(). We must increment the refcount on "plntup" as soon as we have the reference, not sometime later. Otherwise, if an error is thrown in between, the Py_XDECREF(plntup) call in the PG_CATCH block removes a refcount we didn't add, allowing the object to be fr

[COMMITTERS] pgsql: Fix refcounting bug in PLy_modify_tuple().

2014-03-26 Thread Tom Lane
Fix refcounting bug in PLy_modify_tuple(). We must increment the refcount on "plntup" as soon as we have the reference, not sometime later. Otherwise, if an error is thrown in between, the Py_XDECREF(plntup) call in the PG_CATCH block removes a refcount we didn't add, allowing the object to be fr

[COMMITTERS] pgsql: Fix refcounting bug in PLy_modify_tuple().

2014-03-26 Thread Tom Lane
Fix refcounting bug in PLy_modify_tuple(). We must increment the refcount on "plntup" as soon as we have the reference, not sometime later. Otherwise, if an error is thrown in between, the Py_XDECREF(plntup) call in the PG_CATCH block removes a refcount we didn't add, allowing the object to be fr

[COMMITTERS] pgsql: Fix uninitialized variables in json's populate_record_worker().

2014-03-26 Thread Andrew Dunstan
Fix uninitialized variables in json's populate_record_worker(). Peter Geoghegan. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7e4d1600a621ee4e786e715bc82eaad1113dba0e Modified Files -- src/backend/utils/adt/jsonfuncs.c |2 ++ 1 file changed, 2 inse

[COMMITTERS] pgsql: Document that Python 2.3 requires cdecimal module for full funct

2014-03-26 Thread Tom Lane
Document that Python 2.3 requires cdecimal module for full functionality. This has been true for some time, but we were leaving users to discover it the hard way. Back-patch to 9.2. It might've been true before that, but we were claiming Python 2.2 compatibility before that, so I won't guess at

[COMMITTERS] pgsql: Document that Python 2.3 requires cdecimal module for full funct

2014-03-26 Thread Tom Lane
Document that Python 2.3 requires cdecimal module for full functionality. This has been true for some time, but we were leaving users to discover it the hard way. Back-patch to 9.2. It might've been true before that, but we were claiming Python 2.2 compatibility before that, so I won't guess at

[COMMITTERS] pgsql: Document that Python 2.3 requires cdecimal module for full funct

2014-03-26 Thread Tom Lane
Document that Python 2.3 requires cdecimal module for full functionality. This has been true for some time, but we were leaving users to discover it the hard way. Back-patch to 9.2. It might've been true before that, but we were claiming Python 2.2 compatibility before that, so I won't guess at